View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0024315Open CASCADEOCCT:Visualizationpublic2013-11-05 08:022013-12-19 13:59
ReporteraplAssigned Tobugmaster  
PrioritynormalSeveritytrivial 
Status closedResolutionfixed 
PlatformAOSL 
Target Version6.7.0Fixed in Version6.7.0 
Summary0024315: Use delayed release of resources in OpenGl aspects for consistency
DescriptionFor shared OpenGl resources the common style is to use delayed release procedure. There is an inconsistency in release approaches used within OpenGl aspects - it should be revised in a unified manner.

Delayed release here:
void OpenGl_AspectMarker::Release (...)
{
  ...
      if (myResources.SpriteKey.IsEmpty())
      {
        ...
      }
      else
      {
        ...
        theCtx->ReleaseResource (myResources.SpriteKey,  Standard_True);
        theCtx->ReleaseResource (myResources.SpriteAKey, Standard_True);
      }
  ...
}


But instant release here:
void OpenGl_AspectMarker::Resources::BuildSprites (...)
{
  if (aNewResource)
  {
    if (!Sprite.IsNull())
    {
      if (SpriteKey.IsEmpty())
      {
        ...
      }
      else
      {
        Sprite.Nullify(); // we need nullify all handles before ReleaseResource() call
        aContext->ReleaseResource (SpriteKey);
      }
    }
    ...
  }
  ...
}
TagsNo tags attached.
Test case numberNot needed

Relationships

related to 0024309 closedabv TKOpenGl - Shader resources should be released with delay 

Activities

apl

2013-11-18 20:36

developer   ~0026719

Dear kgv,

Could you please review CR24315?

kgv

2013-11-18 23:39

developer   ~0026721

Please test the patch.

mkv

2013-11-19 11:23

tester   ~0026730

Dear BugMaster,

Branch CR24315 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
SHA-1: ce56e9c195a03c623874bbcc2690924e5990396c

Number of compiler warnings:

occt component :
Linux: 317 (317 on master)
Windows: 0 (0 on master)

products component :
Linux: 188 (189 on master)
Windows: 287 (287 on master)

Regressions/Differences:
No regressions/differences

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 357181336 / 357253212
Total CPU difference: 43580.85000000006 / 43279.94000000018

Testing on Windows:
Total MEMORY difference: 411875724 / 411574748
Total CPU difference: 33102.0 / 34417.59375

There are not differences in images found by testdiff.

Related Changesets

occt: master 95eef64d

2013-11-18 16:38:26

apl


Committer: bugmaster Details Diff		 0024315: Use delayed release of resources in OpenGl aspects for consistency

- Do delayed release of face texture resource of OpenGl_AspectFace, point sprite texture of OpenGl_AspectMarker		 Affected Issues
0024315
mod - src/OpenGl/OpenGl_AspectFace.cxx Diff File
mod - src/OpenGl/OpenGl_AspectMarker.cxx Diff File

Issue History

Date Modified Username Field Change
2013-11-05 08:02 apl New Issue
2013-11-05 08:02 apl Assigned To => apl
2013-11-05 08:03 apl Status new => assigned
2013-11-05 08:03 apl Relationship added related to 0024309
2013-11-05 08:05 apl Target Version 6.7.1 => 6.7.0
2013-11-18 20:36 apl Note Added: 0026719
2013-11-18 20:36 apl Assigned To apl => kgv
2013-11-18 20:36 apl Status assigned => resolved
2013-11-18 23:39 kgv Note Added: 0026721
2013-11-18 23:39 kgv Assigned To kgv => bugmaster
2013-11-18 23:39 kgv Status resolved => reviewed
2013-11-18 23:39 kgv Description Updated
2013-11-19 07:04 mkv Assigned To bugmaster => mkv
2013-11-19 11:23 mkv Note Added: 0026730
2013-11-19 11:24 mkv Test case number => Not needed
2013-11-19 11:24 mkv Assigned To mkv => bugmaster
2013-11-19 11:24 mkv Status reviewed => tested
2013-11-25 13:17 bugmaster Changeset attached => occt master 95eef64d
2013-11-25 13:17 bugmaster Status tested => verified
2013-11-25 13:17 bugmaster Resolution open => fixed
2013-12-19 13:50 bugmaster Status verified => closed
2013-12-19 13:59 bugmaster Fixed in Version => 6.7.0