0024095: Eliminate compiler warning C4512 in MSVC++ with warning level 4

ID	Project	Category	View Status	Date Submitted	Last Update

0024095	Open CASCADE	OCCT:Coding	public	2013-08-01 10:13	2013-12-19 13:56

Reporter	~~omy~~	Assigned To	bugmaster
Priority	normal	Severity	minor
Status	closed	Resolution	fixed
Platform	Windows	OS	VC++ 2008
Product Version	6.6.0
Target Version	6.7.0	Fixed in Version	6.7.0

Summary	0024095: Eliminate compiler warning C4512 in MSVC++ with warning level 4
Description	When compiling OCCT 6.6.0 with warning level set to 4, MSVC 2008 compiler produces many warnings c4512: assignment operator couldn't be generated.
Tags	No tags attached.

Test case number	Not needed

~~omy~~ 2013-08-01 16:24 developer ~0025219	Dear abv, Please, review the changes made by the branch CR24095.

~~abv~~ 2013-08-06 09:13 manager ~0025242	Reviewed... though it would be nice to have all the dummy copy constructors and assignment operators private (this is not the case now for some structs) and accompanied by appropriate comment (protection against compiler warning).

~~mkv~~ 2013-08-06 12:18 tester ~0025244	Dear omy, could you please rebase this fix to current master.

~~omy~~ 2013-08-06 18:31 developer ~0025248	Dear mkv, the branch has been rebased. Please, test.

~~mkv~~ 2013-08-07 11:08 tester ~0025259	Dear BugMaster, Branch CR24095 (and products from GIT master) was compiled on Linux and Windows platforms and tested. SHA-1: 85bc263fcd842654058d31468a2e30b1044c82a9 Number of compiler warnings: http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/Warnings/ occt component : Linux: 954 (947 on master) Windows: 883 (891 on master) products component : Linux: 188 (188 on master) Windows: 287 (287 on master) Regressions: No regressions Improvements: No improvements Testing cases: Not needed Testing on Linux: Total MEMORY difference: 363994252 / 363673640 Total CPU difference: 62219.93000000034 / 43423.94000000051 Testing on Windows: Total MEMORY difference: 425760848 / 424306804 Total CPU difference: 39447.109375 / 54556.21875 There are not differences in images found by testdiff.

~~abv~~ 2013-08-07 11:31 manager ~0025260	One of new warnings is: ../../../../inc/LDOM_MemManager.hxx: In member function ‘LDOM_MemManager::HashTable& LDOM_MemManager::HashTable::operator=(const LDOM_MemManager::HashTable&)’: ../../../../inc/LDOM_MemManager.hxx:112: warning: no return statement in function returning non-void Empty assignment operators should have return type void

~~mkv~~ 2013-08-07 12:45 tester ~0025262	Dear Bugmaster, see following new warning compilation on Linux: ------- http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24095/job/mnt-CR24095-master_build_occt_linux/1/warnings14Result/package.-671474530/ IntImpParGen_Intersector.gxx:47 NCollection_IndexedDataMap.hxx:228 dereferencing type-punned pointer will break strict-aliasing rulesIn file included from ../../../../inc/BOPCol_MapOfInteger.hxx:33 NCollection_Map.hxx:179 dereferencing type-punned pointer will break strict-aliasing rulesIn file included from ../../../../inc/BOPCol_MapOfInteger.hxx:33 SelectMgr_CompareResults.hxx:37 no return statement in function returning non-void VrmlData_InBuffer.hxx:41 no return statement in function returning non-void VrmlData_ShapeConvert.hxx:115 no return statement in function returning non-void ------- http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24095/job/mnt-CR24095-master_build_occt_linux/1/warnings14Result/package.103948317/ Extrema_GenExtPS.cxx:79 no return statement in function returning non-void ------- http://jenkins-test-02.nnov.opencascade.com:8080/user/mnt/my-views/view/CR24095/job/mnt-CR24095-master_build_occt_linux/1/warnings14Result/package.-827086367/ LDOM_CharReference.cxx:43 no return statement in function returning non-void

~~omy~~ 2013-08-07 15:40 developer ~0025263	Dear abv, I've made necessary corrections. Please, review.

~~abv~~ 2013-08-07 18:07 manager ~0025267	No remarks, please test

~~mkv~~ 2013-08-08 09:28 tester ~0025273	Dear BugMaster, Branch CR24095 (and products from GIT master) was compiled on Linux and Windows platforms and tested. SHA-1: 831c5fbc793fb1003faff68e10f4b5b0c401a010 Number of compiler warnings: occt component : Linux: 947 (947 on master) Windows: 883 (891 on master) products component : Linux: 188 (188 on master) Windows: 287 (287 on master) Regressions: No regressions Improvements: No improvements Testing cases: Not needed Testing on Linux: Total MEMORY difference: 363962632 / 363651324 Total CPU difference: 43495.390000000654 / 43422.890000000516 Testing on Windows: Total MEMORY difference: 424135848 / 424101868 Total CPU difference: 41627.421875 / 53402.609375 There are not differences in images found by testdiff.

occt: master 79591ef7 2013-08-06 14:25:08 ~~omy~~ Details Diff	0024095: Eliminate compiler warning C4512 in MSVC++ with warning level 4 Removed most of warnings C4512 for non-copyable objects	Affected Issues 0024095
	mod - src/Extrema/Extrema_GenExtPS.cxx	Diff File
	mod - src/LDOM/LDOM_CharReference.cxx	Diff File
	mod - src/LDOM/LDOM_MemManager.hxx	Diff File
	mod - src/SelectMgr/SelectMgr_CompareResults.hxx	Diff File
	mod - src/VrmlData/VrmlData_InBuffer.hxx	Diff File
	mod - src/VrmlData/VrmlData_ShapeConvert.hxx	Diff File
occt: master d390b166 2013-08-06 14:25:08 ~~omy~~ Committer: bugmaster Details Diff	0024095: Eliminate compiler warning C4512 in MSVC++ with warning level 4 Removed most of warnings C4512 for non-copyable objects	Affected Issues 0024095
	mod - src/Extrema/Extrema_GenExtPS.cxx	Diff File
	mod - src/LDOM/LDOM_CharReference.cxx	Diff File
	mod - src/LDOM/LDOM_MemManager.hxx	Diff File
	mod - src/SelectMgr/SelectMgr_CompareResults.hxx	Diff File
	mod - src/VrmlData/VrmlData_InBuffer.hxx	Diff File
	mod - src/VrmlData/VrmlData_ShapeConvert.hxx	Diff File

Date Modified	Username	Field	Change
2013-08-01 10:13	~~omy~~	New Issue
2013-08-01 10:13	~~omy~~	Assigned To	=> omy
2013-08-01 10:13	~~omy~~	Status	new => assigned
2013-08-01 16:23	~~omy~~	Relationship added	child of 0023947
2013-08-01 16:24	~~omy~~	Note Added: 0025219
2013-08-01 16:24	~~omy~~	Assigned To	omy => abv
2013-08-01 16:24	~~omy~~	Status	assigned => resolved
2013-08-06 09:13	~~abv~~	Note Added: 0025242
2013-08-06 09:13	~~abv~~	Status	resolved => reviewed
2013-08-06 09:13	~~abv~~	Assigned To	abv => omy
2013-08-06 12:18	~~mkv~~	Note Added: 0025244
2013-08-06 12:18	~~mkv~~	Status	reviewed => feedback
2013-08-06 18:31	~~omy~~	Note Added: 0025248
2013-08-06 18:31	~~omy~~	Assigned To	omy => mkv
2013-08-06 18:31	~~omy~~	Status	feedback => resolved
2013-08-06 18:48	~~abv~~	Status	resolved => reviewed
2013-08-07 11:08	~~mkv~~	Note Added: 0025259
2013-08-07 11:09	~~mkv~~	Test case number	=> Not needed
2013-08-07 11:09	~~mkv~~	Assigned To	mkv => omy
2013-08-07 11:09	~~mkv~~	Status	reviewed => assigned
2013-08-07 11:31	~~abv~~	Note Added: 0025260
2013-08-07 12:45	~~mkv~~	Note Added: 0025262
2013-08-07 15:40	~~omy~~	Note Added: 0025263
2013-08-07 15:40	~~omy~~	Assigned To	omy => abv
2013-08-07 15:40	~~omy~~	Status	assigned => resolved
2013-08-07 18:07	~~abv~~	Note Added: 0025267
2013-08-07 18:07	~~abv~~	Status	resolved => reviewed
2013-08-07 18:14	~~mkv~~	Assigned To	abv => mkv
2013-08-08 09:28	~~mkv~~	Note Added: 0025273
2013-08-08 09:28	~~mkv~~	Assigned To	mkv => bugmaster
2013-08-08 09:28	~~mkv~~	Status	reviewed => tested
2013-08-09 11:49	~~omy~~	Changeset attached	=> occt master 79591ef7
2013-08-09 11:49	~~omy~~	Assigned To	bugmaster => omy
2013-08-09 11:49	~~omy~~	Status	tested => verified
2013-08-09 11:49	~~omy~~	Resolution	open => fixed
2013-08-17 12:50	bugmaster	Changeset attached	=> occt master d390b166
2013-08-17 12:50	bugmaster	Assigned To	omy => bugmaster
2013-12-19 13:52	bugmaster	Status	verified => closed
2013-12-19 13:56	bugmaster	Fixed in Version	=> 6.7.0
2014-01-11 11:58	~~abv~~	Category	OCCT Release:BUILD => OCCT:Coding

View Issue Details

Relationships

Activities

Related Changesets

Issue History