View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0023965 | Community | OCCT:Visualization | public | 2013-05-15 19:11 | 2013-12-19 13:55 |
| Reporter | Pawel | Assigned To | Pawel | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | A | OS | L | ||
| Product Version | 6.6.0 | ||||
| Target Version | 6.7.0 | Fixed in Version | 6.7.0 | ||
| Summary | 0023965: Making unnecessary copies of TopoDS_Face in Voxel_FastConverter when checking triangulation | ||||
| Description | In Voxel_FastConverter.cxx there are three lines where faces are copied. Using reference should be enough. | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Branch CR23965 pushed. Please review. |
|
|
Vlad, Please make reviewing |
|
|
Thank you for improvement of the code! |
|
|
Reviewed! |
|
|
Dear BugMaster, Branch CR23965 (and products from GIT master) was compiled on Linux and Windows platforms and tested. SHA-1: a499ba08f4f0b04c85a3e628f5b73d6c41de45e0 Number of compiler warnings: occt component : Linux: 2 (2 on master) Windows: 11 (11 on master) products component : Linux: 0 (0 on master) Windows: 64 (64 on master) Regressions: No regressions Improvements: No improvements Testing cases: Not needed Testing on Linux: Total MEMORY difference: 365998340 / 365885296 Total CPU difference: 46744.110000000976 / 45787.42000000135 Testing on Windows: Total MEMORY difference: 417289536 / 420905440 Total CPU difference: 31821.921875 / 30779.234375 There are not differences in images found by testdiff. |
|
occt: master 034b4775 2013-05-15 15:24:43 Details Diff |
0023965: Making unnecessary copies of TopoDS_Face in Voxel_FastConverter when checking triangulation Using reference of TopoDS_Face instead of a copy. Checking if the obtained triangulation is not Null before continuing. |
Affected Issues 0023965 |
|
| mod - src/Voxel/Voxel_FastConverter.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-05-15 19:11 | Pawel | New Issue | |
| 2013-05-15 19:11 | Pawel | Assigned To | => Pawel |
| 2013-05-15 19:19 | Pawel | Summary | Making unnecessary copies of TopoDS_Face when checking triangulation => Making unnecessary copies of TopoDS_Face in Voxel_FastConverter when checking triangulation |
| 2013-05-15 19:25 | Pawel | Note Added: 0024406 | |
| 2013-05-15 19:25 | Pawel | Assigned To | Pawel => bugmaster |
| 2013-05-15 19:25 | Pawel | Status | new => resolved |
| 2013-05-22 12:01 | bugmaster | Note Added: 0024459 | |
| 2013-05-22 12:01 | bugmaster | Assigned To | bugmaster => vro |
| 2013-05-22 12:01 | bugmaster | Status | resolved => assigned |
| 2013-05-22 14:22 | vro | Note Added: 0024464 | |
| 2013-05-22 14:22 | vro | Status | assigned => resolved |
| 2013-05-22 14:22 | vro | Note Added: 0024465 | |
| 2013-05-22 14:22 | vro | Status | resolved => reviewed |
| 2013-05-22 14:56 |
|
Assigned To | vro => mkv |
| 2013-05-29 16:24 |
|
Note Added: 0024545 | |
| 2013-05-29 16:25 |
|
Test case number | => Not needed |
| 2013-05-29 16:25 |
|
Assigned To | mkv => bugmaster |
| 2013-05-29 16:25 |
|
Status | reviewed => tested |
| 2013-06-03 14:48 | Pawel | Changeset attached | => occt master 034b4775 |
| 2013-06-03 14:48 | Pawel | Assigned To | bugmaster => Pawel |
| 2013-06-03 14:48 | Pawel | Status | tested => verified |
| 2013-06-03 14:48 | Pawel | Resolution | open => fixed |
| 2013-12-19 13:53 | bugmaster | Status | verified => closed |
| 2013-12-19 13:55 | bugmaster | Fixed in Version | => 6.7.0 |
