View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0023872Open CASCADEOCCT:Visualizationpublic2013-03-30 19:292013-04-29 15:24
Reporterkgv Assigned Tokgv  
PrioritynoneSeveritytrivial 
Status closedResolutionfixed 
PlatformAOSL 
Target Version6.6.0Fixed in Version6.6.0 
Summary0023872: Remove outdated classes OpenGl_Polygon and OpenGl_Polyline
DescriptionOpenGl_Polygon and OpenGl_Polyline classes were introduced for backward compatibility during TKOpenGl redesign (C -> C++).
However currently them no more in use (superseded by OpenGl_PrimitiveArray) and could be dropped.
TagsNo tags attached.
Test case numberNot needed

Relationships

child of 0023484 closedbugmaster Visualization, TKOpenGl - primitive arrays to become the only way to render geometry 

Activities

kgv

2013-03-30 19:33

developer   ~0023945

Patch is ready for review in CR23872 branch

apl

2013-04-03 15:09

developer   ~0023982

Dear Bugmaster,

The patch reviewed without remarks, please test.

mkv

2013-04-04 14:45

tester   ~0023994

Dear BugMaster,

Branch CR23872 (and products from GIT master) was compiled on Linux and Windows platforms and tested without rebase.
SHA-1: 332d3a8f8e1237afe0870d0b45e0d443af945c48

Number of compiler warnings:

occt component :
Linux: 3 (3 on master)
Windows: 11 (11 on master)

products component :
Linux: 0 (0 on master)
Windows: 50 (50 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 238555892 / 238893624
Total CPU difference: 16421.200000000106 / 16289.240000000136

Testing on Windows:
Total MEMORY difference: 349684064 / 351604748
Total CPU difference: 21668.109375 / 20706.09375

There are not serious differences in images found by testdiff.

Related Changesets

occt: master 27eed937

2013-03-30 15:31:06

kgv

Details Diff		 0023872: Remove outdated classes OpenGl_Polygon and OpenGl_Polyline Affected Issues
0023872
mod - src/InterfaceGraphic/FILES Diff File
rm - src/InterfaceGraphic/InterfaceGraphic_Labels.hxx Diff File
rm - src/InterfaceGraphic/InterfaceGraphic_Portability.hxx Diff File
mod - src/InterfaceGraphic/InterfaceGraphic_telem.hxx Diff File
mod - src/InterfaceGraphic/InterfaceGraphic_tgl_all.hxx Diff File
mod - src/OpenGl/FILES Diff File
mod - src/OpenGl/OpenGl_Group.cxx Diff File
rm - src/OpenGl/OpenGl_Polygon.cxx Diff File
rm - src/OpenGl/OpenGl_Polygon.hxx Diff File
rm - src/OpenGl/OpenGl_Polyline.cxx Diff File
rm - src/OpenGl/OpenGl_Polyline.hxx Diff File
mod - src/OpenGl/OpenGl_Structure.cxx Diff File
mod - src/OpenGl/OpenGl_tsm.hxx Diff File

Issue History

Date Modified Username Field Change
2013-03-30 19:29 kgv New Issue
2013-03-30 19:29 kgv Assigned To => kgv
2013-03-30 19:29 kgv Relationship added child of 0023484
2013-03-30 19:33 kgv Note Added: 0023945
2013-03-30 19:33 kgv Assigned To kgv => san
2013-03-30 19:33 kgv Status new => resolved
2013-04-01 13:47 kgv Assigned To san => apl
2013-04-03 15:09 apl Note Added: 0023982
2013-04-03 15:09 apl Assigned To apl => bugmaster
2013-04-03 15:09 apl Status resolved => reviewed
2013-04-03 15:41 mkv Assigned To bugmaster => mkv
2013-04-04 14:45 mkv Note Added: 0023994
2013-04-04 14:45 mkv Test case number => Not needed
2013-04-04 14:45 mkv Assigned To mkv => bugmaster
2013-04-04 14:45 mkv Status reviewed => tested
2013-04-05 16:39 kgv Changeset attached => occt master 27eed937
2013-04-05 16:39 kgv Assigned To bugmaster => kgv
2013-04-05 16:39 kgv Status tested => verified
2013-04-05 16:39 kgv Resolution open => fixed
2013-04-11 10:27 abv Target Version 6.7.0 => 6.6.0
2013-04-23 13:35 aiv Status verified => closed
2013-04-29 15:24 aiv Fixed in Version => 6.6.0