0023844: It's odd to compare a bool type value with a value of 0.

Notes
(0023820) Pawel (developer) 2013-03-20 15:55	Branch CR23844 pushed. Please review.

(0023822) abv (manager) 2013-03-20 16:10	No remarks, please test

(0023829) Timo (developer) 2013-03-21 12:54	(myOwnWidth != 0.) would be easier to read an in line with the other methods like: inline Standard_Boolean AIS_InteractiveObject::HasHilightMode() const {return myHilightMode!=-1;}

(0023840) mkv (tester) 2013-03-21 18:26	Dear BugMaster, Branch CR23844 (and products from GIT master) was compiled on Linux and Windows platforms and tested without rebase. SHA-1: 4dbe3fe05a88c19a1f73e5ecce7b04d5a50baca5 Number of compiler warnings: occt component : Linux: 3 (3 on master) Windows: 11 (11 on master) products component : Linux: 0 (0 on master) Windows: 50 (50 on master) Regressions: No regressions Improvements: No improvements Testing cases: Not needed Testing on Linux: Total MEMORY difference: 243442684 / 241786268 Total CPU difference: 14673.969999999861 / 14999.000000000102 Testing on Windows: Total MEMORY difference: 352142436 / 354784388 Total CPU difference: 20409.75 / 22914.46875 There are not serious differences in images found by testdiff.

Related Changesets
occt: master 123e4db0 Timestamp: 2013-03-20 11:53:44 Author: Pawel [ Details ] [ Diff ]	0023844: It's odd to compare a bool type value with a value of 0. Comparing Standard_Real values instead of Standard_Real and Standard_Boolean
	mod - src/AIS/AIS_InteractiveObject.lxx	[ Diff ] [ File ]

Relationships