| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0023760 | Open CASCADE | [OCCT] OCCT:Visualization | public | 2013-02-14 10:41 | 2020-08-28 16:31 |
|
| Reporter | san | |
| Assigned To | kgv | |
| Priority | low | Severity | integration request | |
| Status | assigned | Resolution | open | |
| Platform | A | OS | L | OS Version | L |
| Product Version | [OCCT] 6.5.4 | |
| Target Version | [OCCT] 7.6.0* | Fixed in Version | | |
|
| Summary | 0023760: Visualization - drop redundant class AIS_Triangulation |
| Description | - AIS_Triangulation::Compute(): hasVColors and myFlagColors variables contain identical values, so one of them should be removed.
- AIS_Triangulation::Compute(): the purpose of the following line is unclear:
const TColStd_Array1OfInteger& colors = myColor->Array1();
Is it really needed? Most likely it is to be removed, and myColor variable should be used directly in the loop below.
- General remark concerning AIS_Triangulation class: myFlagColors, myNbNodes and myNbTriangles class fields should be removed as completely useless. Consistency of the color array should be checked in Compute() method and include standard non-null handle check and array size check.
- OCCT coding rules to be applied. |
| Tags | No tags attached. |
|
| Test case number | |
|
| Attached Files | |
|
Relationships 
Relationships 