View Issue Details

IDProjectCategoryView StatusLast Update
0023760Open CASCADEOCCT:Visualizationpublic2021-08-24 14:21
Reportersan Assigned Tokgv  
PrioritylowSeverityintegration request 
Status assignedResolutionopen 
PlatformAOSL 
Product Version6.5.4 
Target Version7.7.0 
Summary0023760: Visualization - drop redundant class AIS_Triangulation
Description- AIS_Triangulation::Compute(): hasVColors and myFlagColors variables contain identical values, so one of them should be removed.

- AIS_Triangulation::Compute(): the purpose of the following line is unclear:
const TColStd_Array1OfInteger& colors = myColor->Array1();
Is it really needed? Most likely it is to be removed, and myColor variable should be used directly in the loop below.

- General remark concerning AIS_Triangulation class: myFlagColors, myNbNodes and myNbTriangles class fields should be removed as completely useless. Consistency of the color array should be checked in Compute() method and include standard non-null handle check and array size check.

- OCCT coding rules to be applied.
TagsNo tags attached.
Test case number

Activities

kgv

2014-02-17 16:18

developer   ~0027928

This class seems to be not much usable in current state.
Probably better drop it entirely.

Remark by Roman Lygin:
> Why not use MeshVS instead?

Issue History

Date Modified Username Field Change
2013-02-14 10:41 san New Issue
2013-02-14 10:41 san Assigned To => san
2014-02-17 16:18 kgv Note Added: 0027928
2016-06-16 20:54 kgv Assigned To san => kgv
2016-06-16 20:54 kgv Severity tweak => integration request
2016-06-16 20:54 kgv Status new => assigned
2016-06-16 20:54 kgv Target Version => 7.1.0
2016-06-16 20:54 kgv Summary Revision of AIS_Triangulation class implementation => Visualization - drop redundant class AIS_Triangulation
2016-10-25 09:38 kgv Target Version 7.1.0 => 7.2.0
2017-07-20 10:51 kgv Target Version 7.2.0 => 7.4.0
2019-08-13 12:04 kgv Target Version 7.4.0 => 7.5.0
2020-08-28 16:31 kgv Target Version 7.5.0 => 7.6.0
2021-08-24 14:21 kgv Target Version 7.6.0 => 7.7.0