View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0023696Open CASCADEOCCT:DRAWpublic2013-01-11 11:582013-03-14 17:49
ReporterabkAssigned Toabk 
PrioritynormalSeverityminor 
Status assignedResolutionopen 
Product Version6.5.4 
Summary0023696: Restore work of draw function nexplode for degenerated edges
DescriptionRestore the work after changes of BRepGProp::LinearProperties method by CR23610.
TagsNo tags attached.
Test case numberNot needed

Relationships

related to 0023610 assignedmsv checkshape command does not detect mismatch of the tolerance values among the sub-shapes of the shape 

Activities

abk

2013-01-11 16:22

developer   ~0022945

The work was restored in case of exploding by edges.
Review it please.

abv

2013-01-17 10:37

manager   ~0022992

Please rebase this fix on current master keeping only relevant changes (now CR23696 has common commits with CR23610_2)

abk

2013-01-17 14:51

developer   ~0023001

The fix was pushed to branch CR23696_2.
Review it please.

abv

2013-01-29 10:59

manager   ~0023195

I suggest using method of BRep_Tool class to get point of the vertex and degenerated flag of the edge, instead of direct casts to TVertex and TEdge. As well, rebase on current master is needed (sorry for late review!).

abk

2013-02-13 16:51

developer   ~0023321

Access to vertex 3D point and edge degenerated flag was made through class BRep_Tool.

The fix was rebased on current master in branch CR23696_3.

abk

2013-02-13 16:57

developer   ~0023322

Please review the fix.

abv

2013-03-12 15:08

manager   ~0023668

No remarks, please test

mkv

2013-03-14 16:39

tester   ~0023724

Last edited: 2013-03-14 17:49

 Dear BugMaster,

Branch CR23696_3 (and products from GIT master) was compiled on Linux and Windows platforms and tested without rebase.
SHA-1: c12f6ce826ec46066ab78aa3acf98ac76489171f

Number of compiler warnings:

occt component :
Linux: 3 (3 on master)
Windows: 11 (11 on master)

products component :
Linux: 0 (0 on master)
Windows: 50 (50 on master)

Regressions:
http://occt-tests/CR23696-3-master-occt/Mandriva2010/summary.html
http://occt-tests/CR23696-3-master-occt/Windows-32-VC9/summary.html
blend complex(006) C4 C7
blend simple(001) Y9
boolean bcut_complex(012) O8
bugs modalg_2(007) bug23174
feat featrf(005) A8

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 243119520 / 243310832
Total CPU difference: 18046.570000000167 / 15452.240000000038

Testing on Windows:
Total MEMORY difference: 345971936 / 345982332
Total CPU difference: 17307.078125 / 21461.625

There are not serious differences in images found by testdiff.
http://occt-tests/CR23696-3-master-occt/Windows-32-VC9/diff-Windows-32-VC9.html
http://occt-tests/CR23696-3-master-occt/Mandriva2010/diff-Mandriva2010.html
IMAGE feat featrf A4: A4.png differs
IMAGE feat featrf A5: A5.png differs
IMAGE feat featrf A6: A6.png differs
IMAGE feat featrf B4: B4.png differs
IMAGE blend complex C3: C3.png differs
IMAGE blend complex C8: C8.png differs
IMAGE blend complex C9: C9.png differs
IMAGE blend complex D9: D9.png differs
IMAGE blend simple K3: K3.png differs
IMAGE blend simple T7: T7.png differs
IMAGE blend buildevol F8: F8.png differs
IMAGE blend buildevol J8: J8.png differs
IMAGE draft angle F1: F1.png differs

Issue History

Date Modified Username Field Change
2013-01-11 11:58 abk New Issue
2013-01-11 11:58 abk Assigned To => mkv
2013-01-11 12:01 abk Assigned To mkv => abk
2013-01-11 16:22 abk Note Added: 0022945
2013-01-11 16:23 abk Assigned To abk => abv
2013-01-11 16:23 abk Status new => resolved
2013-01-11 16:39 abv Relationship added related to 0023610
2013-01-17 10:37 abv Note Added: 0022992
2013-01-17 10:37 abv Assigned To abv => abk
2013-01-17 10:37 abv Status resolved => assigned
2013-01-17 14:51 abk Note Added: 0023001
2013-01-17 14:51 abk Assigned To abk => abv
2013-01-17 14:51 abk Status assigned => resolved
2013-01-29 10:59 abv Note Added: 0023195
2013-01-29 10:59 abv Assigned To abv => abk
2013-01-29 10:59 abv Status resolved => assigned
2013-02-13 16:51 abk Note Added: 0023321
2013-02-13 16:57 abk Note Added: 0023322
2013-02-13 16:57 abk Assigned To abk => abv
2013-02-13 16:57 abk Status assigned => resolved
2013-03-12 15:08 abv Note Added: 0023668
2013-03-12 15:08 abv Status resolved => reviewed
2013-03-12 15:08 abv Assigned To abv => bugmaster
2013-03-13 17:25 bugmaster Assigned To bugmaster => mkv
2013-03-14 16:39 mkv Note Added: 0023724
2013-03-14 16:39 mkv Test case number => Not needed
2013-03-14 16:39 mkv Assigned To mkv => abk
2013-03-14 16:39 mkv Status reviewed => assigned
2013-03-14 17:49 mkv Note Edited: 0023724