View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0023672Open CASCADEOCCT:Foundation Classespublic2012-12-25 23:282013-09-17 12:44
ReporterabvAssigned Toabv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformWindowsOSVC++ 2008 
Product Version6.5.4 
Target Version6.6.0Fixed in Version6.6.0 
Summary0023672: Eliminate obsolete functions in OSD_WNT_1.cxx
DescriptionThe file OSD_WNT_1.cxx implements function MsgBox() which is used in OSD_signal_WNT.cxx for interactive report on exception if environment variable OSD_DEBUG_MODE is set. This function can be easily replaced by _CrtDebugBreak() available in Debug mode from MSVC CRT.
Additional information
and documentation updates		The information on possibility to enable run-time debug handlers should be added somewhere in the OCCT documentation:

On Windows: if environment variable CSF_DEBUG_MODE is defined, in case of exception OCCT will raise interactive message box allowing to start debugger at the place where exception occurred.
TagsNo tags attached.
Test case numberNot needed

Relationships

parent of 0024184 closedbugmaster WOK is required to have the own analog of DirWalk method 

Activities

abv

2012-12-27 10:00

manager   ~0022856

Fix is submitted to CR23672, please review

kgv

2012-12-27 11:40

developer   ~0022861

Last edited: 2012-12-27 11:40

 Just a tip - probably it will be better to use Standard_ASSERT_REPORT_ wrapper defined in Standard_Assert.hxx instead?

abv

2012-12-27 12:54

manager   ~0022864

The problem with Standard_Assert macro is that it does not work well (at least here in the exception handler) if you run in Debug mode but not under debugger. Note that the code in OSD_signal_WNT contains specific function _osd_debug() which loads debugger even if you run executable not from Visual Studio. My bad, I have not checked carefully how Standard_Assert behaves when used outside of exception handler; this could be subject of separate issue.

abv

2013-03-02 21:07

manager   ~0023566

I have reverted to using plain ::MessageBox(), in order to provide the same behavior in Debug and Release mode. Please review (branch CR23672, rebased on future master)

kgv

2013-03-04 11:47

developer   ~0023572

Patch was reviewed without remarks.

mkv

2013-03-07 14:27

tester   ~0023623

Dear BugMaster,

Branch CR23672 (and products from GIT master) was compiled on Linux and Windows platforms.
SHA-1: 014348fd4c3e452b174114e95f766f58cafef1f7

Number of compiler warnings:

occt component :
Linux: 3 (3 on master)
Windows: 11(12 on master)

products component :
Linux: 10 (10 on master)
Windows: 50 (50 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
Not needed

Testing on Linux:
Total MEMORY difference: 234303444 / 234502168
Total CPU difference: 14252.329999999953 / 17512.92000000039

Testing on Windows:
Total MEMORY difference: 344193976 / 343866096
Total CPU difference: 17105.25 / 17157.28125

There are not serious differences in images found by testdiff.

Related Changesets

occt: master b2d3f231

2012-12-25 19:32:01

abv


Committer: abv Details Diff		 0023672: Eliminate obsolete functions in OSD_WNT_1.cxx

MsgBox() and several other obsolete Windows-specific functions eliminated in OSD_WNT*		 Affected Issues
0023672
mod - src/OSD/FILES Diff File
mod - src/OSD/OSD_signal_WNT.cxx Diff File
mod - src/OSD/OSD_WNT.cxx Diff File
rm - src/OSD/OSD_WNT_1.cxx Diff File
mod - src/OSD/OSD_WNT_1.hxx Diff File
mod - src/WNT/WNT_Window.cxx Diff File

Issue History

Date Modified Username Field Change
2012-12-25 23:28 abv New Issue
2012-12-25 23:28 abv Assigned To => abv
2012-12-27 10:00 abv Note Added: 0022856
2012-12-27 10:00 abv Assigned To abv => kgv
2012-12-27 10:00 abv Status new => resolved
2012-12-27 11:40 kgv Note Added: 0022861
2012-12-27 11:40 kgv Note Edited: 0022861
2012-12-27 12:54 abv Note Added: 0022864
2012-12-27 15:09 abv Assigned To kgv => abv
2012-12-27 15:09 abv Status resolved => assigned
2013-03-02 21:07 abv Note Added: 0023566
2013-03-02 21:07 abv Assigned To abv => kgv
2013-03-02 21:07 abv Status assigned => resolved
2013-03-02 21:15 abv Additional Information Updated
2013-03-04 11:47 kgv Note Added: 0023572
2013-03-04 11:47 kgv Assigned To kgv => bugmaster
2013-03-04 11:47 kgv Status resolved => reviewed
2013-03-04 18:41 mkv Assigned To bugmaster => mkv
2013-03-07 14:27 mkv Note Added: 0023623
2013-03-07 14:27 mkv Test case number => Not needed
2013-03-07 14:27 mkv Assigned To mkv => bugmaster
2013-03-07 14:27 mkv Status reviewed => tested
2013-03-11 17:38 abv Changeset attached => occt master b2d3f231
2013-03-11 17:38 abv Assigned To bugmaster => abv
2013-03-11 17:38 abv Status tested => verified
2013-03-11 17:38 abv Resolution open => fixed
2013-04-23 13:35 aiv Status verified => closed
2013-04-29 15:23 aiv Fixed in Version => 6.6.0
2013-09-17 12:44 ibs Relationship added parent of 0024184