View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0023620 | Community | OCCT:Modeling Data | public | 2012-12-05 15:22 | 2016-04-20 15:50 |
| Reporter | Roman Lygin | Assigned To | bugmaster | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | A | OS | L | ||
| Product Version | 6.5.4 | ||||
| Target Version | 7.0.0 | Fixed in Version | 7.0.0 | ||
| Summary | 0023620: Follow up of #22939 - make Bezier curve/surface evaluation thread-safe | ||||
| Description | Apparently Bezier surface/curve/2d curve were overlooked in 0022939, although they have the same approach (caching of calculated value). | ||||
| Steps To Reproduce | Not required | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Branch CR23620 has been created by azv. SHA-1: 77635db1090e6e77861e9f233043ee393dbba127 Detailed log of new commits: Author: azv Date: Mon Nov 2 09:33:04 2015 +0300 0023620: Follow up of 0022939 - make Bezier curve/surface evaluation thread-safe 1. Remove cache from Geom_BezierCurve, Geom2d_BezierCurve and Geom_BezierSurface 2. Add cache for Bezier curves into GeomAdaptor_Curve, Geom2dAdaptor_Curve and GeomAdaptor_Surface 3. Update comments in corresponding cache classes 4. Avoid frequent down-casting to B-splines in adaptors |
|
|
Dear Mikhail, Please, review branch CR23620. Cache for Bezier curves and surfaces was moved into corresponding adaptors as it was done for B-splines before. So, direct using of Bezier geometry is thread-safe now. |
|
|
Branch CR23620 has been updated forcibly by azv. SHA-1: 5cb13979c7ccc8393898149725bc5b3793c07ca7 |
|
|
I have reviewed the fix. Please pass it to test after CR26252 will have been tested. |
|
|
Branch CR23620 has been updated forcibly by azv. SHA-1: 394ff859d320cfb265d421db81ac13cd4e132152 |
|
|
Branch CR23620 has been updated forcibly by azv. SHA-1: 22cdbe871a902f17d5cdf456e3497b353cb275c3 |
|
|
Branch CR23620 has been rebased on CR26252_4. Please, test it in cooperation with CR26838_1 after the issue 0026252 will be moved to TESTED state. |
|
|
Tested together with branch CR26838_1 |
|
|
Branch CR23620 has been deleted by kgv. SHA-1: 22cdbe871a902f17d5cdf456e3497b353cb275c3 |
|
occt: master c8b5b3d8 2015-11-02 06:33:04
Committer: bugmaster Details Diff |
0023620: Follow up of 0022939 - make Bezier curve/surface evaluation thread-safe 1. Remove cache from Geom_BezierCurve, Geom2d_BezierCurve and Geom_BezierSurface 2. Add cache for Bezier curves into GeomAdaptor_Curve, Geom2dAdaptor_Curve and GeomAdaptor_Surface 3. Update comments in corresponding cache classes 4. Avoid frequent down-casting to B-splines in adaptors |
Affected Issues 0023620 |
|
| mod - src/BSplCLib/BSplCLib_Cache.hxx | Diff File | ||
| mod - src/BSplSLib/BSplSLib_Cache.hxx | Diff File | ||
| mod - src/Geom/Geom_BezierCurve.cxx | Diff File | ||
| mod - src/Geom/Geom_BezierCurve.hxx | Diff File | ||
| mod - src/Geom/Geom_BezierSurface.cxx | Diff File | ||
| mod - src/Geom/Geom_BezierSurface.hxx | Diff File | ||
| mod - src/Geom2d/Geom2d_BezierCurve.cxx | Diff File | ||
| mod - src/Geom2d/Geom2d_BezierCurve.hxx | Diff File | ||
| mod - src/Geom2dAdaptor/Geom2dAdaptor_Curve.cxx | Diff File | ||
| mod - src/GeomAdaptor/GeomAdaptor_Curve.cxx | Diff File | ||
| mod - src/GeomAdaptor/GeomAdaptor_Surface.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-12-05 15:22 | Roman Lygin | New Issue | |
| 2012-12-05 15:22 | Roman Lygin | Assigned To | => jgv |
| 2015-04-18 17:51 |
|
Target Version | => 7.1.0 |
| 2015-04-18 17:52 |
|
Relationship added | related to 0024682 |
| 2015-04-18 17:52 |
|
Assigned To | jgv => azv |
| 2015-04-18 17:52 |
|
Status | new => assigned |
| 2015-05-20 09:45 |
|
Assigned To | azv => azn |
| 2015-10-05 09:46 |
|
Assigned To | azn => azv |
| 2015-10-28 14:54 |
|
Target Version | 7.1.0 => 7.0.0 |
| 2015-11-02 09:38 | git | Note Added: 0047692 | |
| 2015-11-02 09:41 |
|
Note Added: 0047693 | |
| 2015-11-02 09:41 |
|
Assigned To | azv => msv |
| 2015-11-02 09:41 |
|
Status | assigned => resolved |
| 2015-11-02 09:41 |
|
Steps to Reproduce Updated | |
| 2015-11-02 10:39 | git | Note Added: 0047695 | |
| 2015-11-02 11:15 |
|
Note Added: 0047696 | |
| 2015-11-02 11:15 |
|
Assigned To | msv => azv |
| 2015-11-03 13:40 | kgv | Relationship added | related to 0026252 |
| 2015-11-06 08:46 | git | Note Added: 0047859 | |
| 2015-11-18 10:02 | git | Note Added: 0048325 | |
| 2015-11-18 10:17 |
|
Note Added: 0048328 | |
| 2015-11-18 10:17 |
|
Assigned To | azv => bugmaster |
| 2015-11-18 10:17 |
|
Status | resolved => reviewed |
| 2015-11-20 15:26 |
|
Assigned To | bugmaster => apv |
| 2015-11-23 13:36 |
|
Test case number | => Not needed |
| 2015-11-26 14:10 |
|
Note Added: 0048606 | |
| 2015-11-26 14:10 |
|
Assigned To | apv => bugmaster |
| 2015-11-26 14:10 |
|
Status | reviewed => tested |
| 2015-11-27 12:21 | bugmaster | Changeset attached | => occt master c8b5b3d8 |
| 2015-11-27 12:21 | bugmaster | Status | tested => verified |
| 2015-11-27 12:21 | bugmaster | Resolution | open => fixed |
| 2016-04-17 14:14 | git | Note Added: 0053079 | |
| 2016-04-20 15:42 |
|
Fixed in Version | => 7.0.0 |
| 2016-04-20 15:50 |
|
Status | verified => closed |
