MantisBT
Mantis Bug Tracker Workflow

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0023581Community[OCCT] OCCT:Meshpublic2012-11-25 20:312019-03-12 19:10
ReporterRoman Lygin 
Assigned Toabv 
PrioritynormalSeverityminor 
StatusfeedbackResolutionopen 
PlatformAOSLOS VersionL
Product Version[OCCT] 6.5.4 
Target VersionFixed in Version 
Summary0023581: [Regression] Performance of BRepMesh 6.5.4 can be up to Nx worse than 6.3.1
Description(Like 0023580, inspired by this forum thread - http://www.opencascade.org/org/forum/thread_23944/?add_id=23956&forum=3 [^])

Performance of BRepMesh measured on a few medium complexity models can be up to 3x worse vs 6.3.1
Steps To Reproducesee enclosed readme-performance.txt
TagsNo tags attached.
Test case number
Attached Filestxt file icon readme-performance.txt (1,291 bytes) 2012-11-25 20:31
png file icon f1_hollow_631.png (461,410 bytes) 2012-11-29 11:23
png file icon f1_hollow_654.png (474,296 bytes) 2012-11-29 11:23
png file icon f1_shading_631.png (203,912 bytes) 2012-11-29 11:23
png file icon f1_shading_654.png (219,844 bytes) 2012-11-29 11:24
txt file icon readme-performance2.txt (2,020 bytes) 2012-11-29 23:11
zip file icon shaver.zip (785,709 bytes) 2012-11-29 23:11
? file icon f1.brep (3,719,786 bytes) 2019-03-12 18:43
? file icon cylinder_head.brep (4,330,831 bytes) 2019-03-12 18:43

- Relationships
related to 0023105closedoan Exception during Meshing / Missing triangles 

-  Notes
(0022438)
kgv (developer)
2012-11-29 11:45

Dear Roman,

performance regressions couldn't be analyzed in such form.

First at all bug description should provide complete information about used models (should be attached to bug, path in OCCT repository, publicity accessible URL, confidential shapes could be provided to bugmaster via e-mail) and test scenarios.
I found only one model "F1.brep" (http://www.opencascade.org/showroom/shapegallery/gal5/ [^] "The F1") which seems to be exactly corresponds to shape in report.

Second, this is incorrect to calculate time of vdisplay command to compare meshing algorithm. vdisplay calculates deflection parameters by it's own, may use different mesh plugins and involves 3D visualization tasks as well.
The more acceptable test case will be:

pload MODELING
restore F1.brep s
tclean s
chrono l reset
chrono l start
incmesh s 15
chrono l stop
chrono l show
trinfo s

pload VISUALIZATION
vinit
vsetdispmode 1
vdisplay s
vaxo
vfit
vzfit
trinfo s

Results for OCCT631:
> Elapsed time: 0.826 Second(s)
> CPU user time: 0.624004 seconds
> This shape contains 13982 triangles.
> 15723 nodes.
> Maximal deflection 14.332640235601703

Results for OCCT654:
> Elapsed time: 1.52602131781 Seconds
> CPU user time: 1.3260085 seconds
> This shape contains 25230 triangles.
> 20457 nodes.
> Maximal deflection 14.364915117921329

Concerning to F1.brep it is obviously noticeable on attached snapshots that OCCT631 significantly deviate from required deflection whilst OCCT654 produce more acceptable result (but require more triangles and time).
(0022464)
Roman Lygin (developer)
2012-11-29 23:11

Kirill, thanks for a fast turn-around.
OK to change the methodology (although the 'vdisplay' is closer to the overall end-user experience).
See the updated readme enclosed. The shaver.brep is enclosed, although you can rebuild from the web-site, following the URLs.
If you would like to follow up feel free to drop me a personal email. Discussion via Notes here can be not always efficient. We can put a summary afterwards here.
thanks.
Roman
(0082880)
git (administrator)
2019-03-12 18:55

Branch CR23581 has been created by oan.

SHA-1: c62618cd602f954b4167ef6e09a16a00ed102cac


Detailed log of new commits:

Author: oan
Date: Mon Mar 4 09:55:25 2019 +0300

    0023581: [Regression] Performance of BRepMesh 6.5.4 can be up to Nx worse than 6.3.1
    
    Added test case.
(0082881)
oan (developer)
2019-03-12 18:56
edited on: 2019-03-12 19:00

Current master gives the following results in seconds comparing to 6.5.4 and 6.3.1:

6.3.1
f1: 0.3125
cylinder_head: 0.46875
shaver: 0.53125

6.5.4
f1: 1.1875
cylinder_head: 1.453125
shaver: 1.546875

7.4.0
f1: 0.53125
cylinder_head: 0.734375
shaver: 0.75

General point of performance degradation was change of triangulation algorithm done in version next to 6.3.1.

It is proposed to close the issue now.


- Issue History
Date Modified Username Field Change
2012-11-25 20:31 Roman Lygin New Issue
2012-11-25 20:31 Roman Lygin Assigned To => oan
2012-11-25 20:31 Roman Lygin File Added: readme-performance.txt
2012-11-29 11:23 kgv File Added: f1_hollow_631.png
2012-11-29 11:23 kgv File Added: f1_hollow_654.png
2012-11-29 11:23 kgv File Added: f1_shading_631.png
2012-11-29 11:24 kgv File Added: f1_shading_654.png
2012-11-29 11:45 kgv Note Added: 0022438
2012-11-29 11:45 kgv Assigned To oan => Roman Lygin
2012-11-29 11:45 kgv Status new => feedback
2012-11-29 23:11 Roman Lygin Note Added: 0022464
2012-11-29 23:11 Roman Lygin Status feedback => assigned
2012-11-29 23:11 Roman Lygin File Added: readme-performance2.txt
2012-11-29 23:11 Roman Lygin File Added: shaver.zip
2012-11-29 23:12 Roman Lygin Assigned To Roman Lygin => kgv
2012-11-29 23:12 Roman Lygin Status assigned => feedback
2012-12-02 17:54 kgv Assigned To kgv => oan
2012-12-02 17:54 kgv Status feedback => assigned
2013-03-07 15:44 oan Relationship added related to 0023105
2019-03-12 18:43 oan File Added: f1.brep
2019-03-12 18:43 oan File Added: cylinder_head.brep
2019-03-12 18:55 git Note Added: 0082880
2019-03-12 18:56 oan Note Added: 0082881
2019-03-12 18:58 oan Note Edited: 0082881 View Revisions
2019-03-12 19:00 oan Note Edited: 0082881 View Revisions
2019-03-12 19:10 oan Assigned To oan => abv
2019-03-12 19:10 oan Status assigned => feedback


Copyright © 2000 - 2019 MantisBT Team
Powered by Mantis Bugtracker