View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0023483Open CASCADEOCCT:Foundation Classespublic2012-10-23 07:032013-04-29 15:21
ReporterabvAssigned Toabv 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Target Version6.6.0Fixed in Version6.6.0 
Summary0023483: Use appropriate type for handling integer time
DescriptionCurrently OCCT does not provide a type equivalent to time_t on CDL level. This leads to using Standard_Integer or Standard_Size in situations where time_t would need to be used in CDL. Hence, all conversions from time_t need to be either explicit casts, or trigger compiler warnings (see e.g. Material_MaterialsDictionary).

To eliminate this problem, a new type (Standard_Time) can be added in Standard package (either in Standard_TypeDef.hxx, or in separate header as primitive CDL type -- to be decided) and used in all places where time_t is needed.
TagsNo tags attached.
Test case numberNot needed

Activities

omy

2013-01-22 17:51

developer   ~0023061

Dear INV,
Fix is integrated into branch CR23483.
Please, review.

kgv

2013-01-23 10:51

developer   ~0023077

Patch is incomplete - Standard.cdl has no definition of Standard_Time.

omy

2013-01-23 12:19

developer   ~0023084

Dear KGV,
I've fixed mistakes you noticed above.
Please, review.

kgv

2013-01-24 11:30

developer   ~0023115

Patch is ready for testing in CR23483_1 branch.
Please check compiler warnings as well.

mkv

2013-01-25 14:31

tester   ~0023147

Last edited: 2013-01-25 15:21

 Dear BugMaster,
Branch CR23483_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested.

Number of compiler warnings:

occt component :
Linux: 3 (3 on master)
Windows: 80 (85 on master)

products component :
Linux: 9 (9 on master)
Windows: 54 (54 on master)

Regressions:
No regressions

Improvements:
No improvements

Testing cases:
No testing cases

Testing on Linux:
Total MEMORY difference: 222795564 / 223181100
Total CPU difference: 8885.62000000042 / 8335.420000000542

Testing on Windows:
Total MEMORY difference: 298273164 / 298125568
Total CPU difference: 11223.71875 / 11645.421875

There are not serious differences in images found by testdiff.

kgv

2013-01-25 14:43

developer   ~0023151

Dear mkv,

the number of warnings should be 80 for OCCT component according to tests log.

Related Changesets

occt: master 6c3e4c29

2013-01-24 07:27:45

abv


Committer: abv Details Diff		 0023483: Use appropriate type for handling integer time

Introduced new cdl-friendly Standard_Time alias to time_t type.		 Affected Issues
0023483
mod - src/Dynamic/Dynamic_FuzzyDefinitionsDictionary.cdl Diff File
mod - src/Dynamic/Dynamic_MethodDefinitionsDictionary.cdl Diff File
mod - src/Materials/Materials_MaterialsDictionary.cdl Diff File
mod - src/Standard/FILES Diff File
mod - src/Standard/Standard.cdl Diff File
add - src/Standard/Standard_Time.cxx Diff File
add - src/Standard/Standard_Time.hxx Diff File
mod - src/Standard/Standard_TypeDef.hxx Diff File
mod - src/Units/Units_Lexicon.cdl Diff File
mod - src/Units/Units_UnitsDictionary.cdl Diff File
mod - src/Units/Units_UnitsDictionary.cxx Diff File
mod - src/Units/Units_UnitsLexicon.cdl Diff File

Issue History

Date Modified Username Field Change
2012-10-23 07:03 abv New Issue
2012-10-23 07:03 abv Assigned To => abv
2012-10-23 09:34 abv Target Version => 6.6.0
2012-10-26 17:54 abv Assigned To abv => omy
2012-10-26 17:54 abv Status new => assigned
2013-01-22 17:51 omy Note Added: 0023061
2013-01-22 17:51 omy Assigned To omy => inv
2013-01-22 17:51 omy Status assigned => resolved
2013-01-23 10:51 kgv Note Added: 0023077
2013-01-23 10:51 kgv Assigned To inv => omy
2013-01-23 10:51 kgv Status resolved => assigned
2013-01-23 12:19 omy Note Added: 0023084
2013-01-23 12:19 omy Assigned To omy => kgv
2013-01-23 12:19 omy Status assigned => resolved
2013-01-24 11:30 kgv Note Added: 0023115
2013-01-24 11:30 kgv Assigned To kgv => bugmaster
2013-01-24 11:30 kgv Status resolved => reviewed
2013-01-24 16:29 mkv Assigned To bugmaster => mkv
2013-01-25 14:31 mkv Note Added: 0023147
2013-01-25 14:32 mkv Test case number => Not needed
2013-01-25 14:32 mkv Assigned To mkv => bugmaster
2013-01-25 14:32 mkv Status reviewed => tested
2013-01-25 14:43 kgv Note Added: 0023151
2013-01-25 15:21 mkv Note Edited: 0023147
2013-01-28 18:06 abv Changeset attached => occt master 6c3e4c29
2013-01-28 18:06 abv Assigned To bugmaster => abv
2013-01-28 18:06 abv Status tested => verified
2013-01-28 18:06 abv Resolution open => fixed
2013-04-23 13:36 aiv Status verified => closed
2013-04-29 15:21 aiv Fixed in Version => 6.6.0