View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0023354 | Community | OCCT:DRAW | public | 2012-07-26 14:01 | 2012-11-16 13:17 |
| Reporter | Pawel | Assigned To | ika | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | A | OS | L | ||
| Product Version | 6.5.3 | ||||
| Target Version | 6.5.4 | Fixed in Version | 6.5.4 | ||
| Summary | 0023354: The use of 'if (A) {...} else if (A) {...}' pattern was detected. | ||||
| Description | In ViewerTest_ViewerCommands, lines 324 and 346. The case else if ( !strcasecmp(buf_ret, "D") ) { is handled twice. Was it maybe "R" that was meant for reset and "D" for something else? | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
second else was deleted, now "D" is hotkey for reset view and removing selected object is impossible by hotkeys help message was rewrited according to these changes, also hotkeys "R","L" and "B" added to help Git branch CR23266 is ready to be reviewed. Dear Anton, please review. |
|
|
Hi, Irina. Branch CR23354 reviewed (I'm sure you meant it instead of 23266). All remarks (minor) are already in the branch: 1) comments in hot key parsing revised (there were left, right, bottom commented as "top"). 2) help menu completed with other available hot keys. "U" - unset display mode, "Z" - switch Z clipping On/Off. |
|
|
I would like to remind you workflow of issue "status" in bug advancement (see picture above): Please don't forget to change issue's status: * when bug fixed - developer should change its status to "resolved" and the bug should be assigned to reviewer. So, could you please change status to resolved, and then to reviewed (I'm already done it) and ask bug master to test the fix? |
|
|
Hi, Anton. Sorry for these mistakes, I'll do that you say next time. |
|
|
please test. |
|
|
Dear BugMaster, Branch CR23354 (and master from occt-products) was compiled on Linux and Windows platforms and tested. Regressions: Not detected Improvements: Not detected Testing cases: Not needed |
|
occt: master 41811896 2012-10-19 14:19:18 Details Diff |
0023354: The use of 'if (A) {...} else if (A) {...}' pattern was detected. second else was deleted, now "D" is hotkey for reset view and removing selected object is impossible by hotkeys help message was rewrited according to these changes, also hotkeys "R","L" and "B" added to help Minor remarks: viewer commands help fulfilled with U; Z; ","; "." . Comments revised. |
Affected Issues 0023354 |
|
| mod - src/ViewerTest/ViewerTest_ViewerCommands.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-07-26 14:01 | Pawel | New Issue | |
| 2012-07-26 14:01 | Pawel | Assigned To | => bugmaster |
| 2012-08-17 16:42 | bugmaster | Assigned To | bugmaster => san |
| 2012-08-17 16:42 | bugmaster | Status | new => assigned |
| 2012-10-09 19:04 | oan | Assigned To | san => ika |
| 2012-10-12 18:44 | ika | Note Added: 0021761 | |
| 2012-10-12 18:45 | ika | Assigned To | ika => apl |
| 2012-10-15 10:49 |
|
Note Added: 0021765 | |
| 2012-10-15 10:51 |
|
Assigned To | apl => ika |
| 2012-10-15 10:56 |
|
Note Added: 0021766 | |
| 2012-10-15 11:46 | ika | Note Added: 0021767 | |
| 2012-10-15 11:49 | ika | Status | assigned => resolved |
| 2012-10-15 12:01 | ika | Note Added: 0021768 | |
| 2012-10-15 12:01 | ika | Assigned To | ika => bugmaster |
| 2012-10-15 12:01 | ika | Status | resolved => reviewed |
| 2012-10-15 19:58 |
|
Assigned To | bugmaster => mkv |
| 2012-10-16 11:26 |
|
Note Added: 0021783 | |
| 2012-10-16 11:26 |
|
Test case number | => Not needed |
| 2012-10-16 11:26 |
|
Assigned To | mkv => bugmaster |
| 2012-10-16 11:26 |
|
Status | reviewed => tested |
| 2012-10-23 20:41 | ika | Changeset attached | => occt master 41811896 |
| 2012-10-23 20:43 | ika | Assigned To | bugmaster => ika |
| 2012-10-23 20:43 | ika | Status | tested => verified |
| 2012-10-23 20:43 | ika | Resolution | open => fixed |
| 2012-11-16 13:14 | bugmaster | Fixed in Version | => 6.5.4 |
| 2012-11-16 13:17 | bugmaster | Status | verified => closed |
