View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0023351 | Community | OCCT:DRAW | public | 2012-07-26 13:26 | 2012-11-16 13:17 |
| Reporter | Pawel | Assigned To | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | A | OS | L | ||
| Product Version | 6.5.3 | ||||
| Target Version | 6.5.4 | Fixed in Version | 6.5.4 | ||
| Summary | 0023351: The use of 'if (A) {...} else if (A) {...}' pattern was detected. | ||||
| Description | In test TestTopOpe_BOOPCommands.cxx lines 90 and 110 lines 137 and 157 Was this intended? | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Fix is integrated to branch CR23351 (see commit message for details). Please review |
|
|
I have no comments, please test |
|
|
In the last commit, I suppose that "if (typ != TopAbs_SHAPE)" could be replaced by "else" |
|
|
I suppose there's no need to replace "if (typ != TopAbs_SHAPE)" by "else" because it will be necessary to change function logic a little and may cause some additional problems. |
|
|
Dear BugMaster, Branch CR23351 (and master from occt-products) was compiled on Linux and Windows platforms and tested. Regressions: Not detected Improvements: Not detected Testing cases: Not needed |
|
occt: master 7da2a6ab 2012-10-19 14:09:57
|
0023351: The use of 'if (A) {...} else if (A) {...}' pattern was detected. Got rid of duplicated code. Got rid of redundant conditions' checks in Standard_Integer TOPOC(Draw_Interpretor& interpretor,Standard_Integer na,const char** a) function. |
Affected Issues 0023351 |
|
| mod - src/TestTopOpe/TestTopOpe_BOOPCommands.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-07-26 13:26 | Pawel | New Issue | |
| 2012-07-26 13:26 | Pawel | Assigned To | => bugmaster |
| 2012-08-17 16:42 | bugmaster | Assigned To | bugmaster => emv |
| 2012-08-17 16:42 | bugmaster | Status | new => assigned |
| 2012-10-09 10:17 | oan | Assigned To | emv => omy |
| 2012-10-11 14:58 |
|
Note Added: 0021724 | |
| 2012-10-11 15:00 |
|
Assigned To | omy => oan |
| 2012-10-11 15:15 |
|
Status | assigned => resolved |
| 2012-10-12 11:40 | oan | Note Added: 0021744 | |
| 2012-10-12 11:40 | oan | Status | resolved => reviewed |
| 2012-10-12 12:58 |
|
Note Added: 0021749 | |
| 2012-10-12 17:47 |
|
Assigned To | oan => mkv |
| 2012-10-16 09:28 |
|
Note Added: 0021777 | |
| 2012-10-16 10:21 |
|
Note Added: 0021779 | |
| 2012-10-16 10:21 |
|
Note Edited: 0021779 | |
| 2012-10-16 10:22 |
|
Test case number | => Not needed |
| 2012-10-16 10:22 |
|
Assigned To | mkv => bugmaster |
| 2012-10-16 10:22 |
|
Status | reviewed => tested |
| 2012-10-23 20:41 |
|
Changeset attached | => occt master 7da2a6ab |
| 2012-10-23 20:45 |
|
Assigned To | bugmaster => omy |
| 2012-10-23 20:45 |
|
Status | tested => verified |
| 2012-10-23 20:45 |
|
Resolution | open => fixed |
| 2012-11-16 13:14 | bugmaster | Fixed in Version | => 6.5.4 |
| 2012-11-16 13:17 | bugmaster | Status | verified => closed |
