View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0023335CommunityOCCT:Data Exchangepublic2012-07-20 16:142012-11-16 13:17
ReporterPawel Assigned ToPawel  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformAOSL 
Product Version6.5.3 
Target Version6.5.4Fixed in Version6.5.4 
Summary0023335: Array overrun is possible. The value of 'i' index could reach 200 in Interface_MSG.cxx
DescriptionIn the method Interface_MSG::Read (Standard_IStream& S) there is a buffer of size '200'. The 'for-loop' in line 145 iterates over the buffer from 1 to 200 (inclusive) - this would be the 201st element of the buffer.

I suggest to iterate from 1 to 199.
TagsNo tags attached.
Test case numberNot needed

Activities

Pawel

2012-07-20 16:18

developer   ~0021089

Corresponding git branch pushed. Please review.

abv

2012-07-23 13:54

manager   ~0021109

No remarks, please test

apn

2012-07-24 16:20

administrator   ~0021139

Dear BugMaster,
The workbenches
KAS:dev:apn-23335-occt (GIT branch CR23335)
KAS:dev:apn-23335-products (GIT master)
were compiled on Linux platform and tested.

Regression:
Not detected

Improvements:
Not detected

Testing case:
Not needed

See results in /QADisk/occttests/results/KAS/dev/apn-23335-products_24072012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120706-opt_06072012/lin
See test cases in /QADisk/occttests/tests/ED

Related Changesets

occt: master db3d2a99

2012-07-20 12:16:50

Pawel

Details Diff		 0023335: Array overrun is possible. The value of 'i' index could reach 200 in Interface_MSG.cxx

Iterating from 1 to 199 over the 'buf' in order to avoid an overrun.		 Affected Issues
0023335
mod - src/Interface/Interface_MSG.cxx Diff File

Issue History

Date Modified Username Field Change
2012-07-20 16:14 Pawel New Issue
2012-07-20 16:14 Pawel Assigned To => Pawel
2012-07-20 16:18 Pawel Note Added: 0021089
2012-07-20 16:18 Pawel Assigned To Pawel => bugmaster
2012-07-20 16:18 Pawel Status new => resolved
2012-07-23 13:54 abv Note Added: 0021109
2012-07-23 13:54 abv Status resolved => reviewed
2012-07-24 16:20 apn Note Added: 0021139
2012-07-24 16:21 apn Test case number => Not needed
2012-07-24 16:21 apn Status reviewed => tested
2012-07-30 16:31 Pawel Changeset attached => occt master db3d2a99
2012-07-30 16:32 Pawel Assigned To bugmaster => Pawel
2012-07-30 16:32 Pawel Status tested => verified
2012-07-30 16:32 Pawel Resolution open => fixed
2012-11-16 13:14 bugmaster Fixed in Version => 6.5.4
2012-11-16 13:17 bugmaster Status verified => closed