View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0023320 | Community | OCCT:Visualization | public | 2012-07-18 13:32 | 2012-11-16 13:17 |
| Reporter | Pawel | Assigned To | Pawel | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | A | OS | L | ||
| Product Version | 6.5.3 | ||||
| Target Version | 6.5.4 | Fixed in Version | 6.5.4 | ||
| Summary | 0023320: The body of 'OpenCollector' function is fully equivalent to the body of 'CloseCollector' function | ||||
| Description | AIS_InteractiveContext::CloseCollector() in AIS_InteractiveContext.lxx and AIS_InteractiveContext::OpenCollector() in AIS_InteractiveContext.cxx set the value of 'myIsCollClosed' to Standard_True I guess when opening the collector this flag should be set to Standard_False. | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Corresponding git branch pushed. Please review. |
|
|
No remarks, please test |
|
|
Note that methods CloseCollector() and OpenCollector() are not used neither in OCCT code nor in applications I could check. Method IsCollectorClosed() is used in single place: at line 760 in AIS_InteractiveContext_2.cxx (method PurgeDisplay(), which in turn is used only in single place in QADraw.cxx). Do we need this stuff at all (and in AIS2d_InteractiveContect, too)? |
|
|
Dear BugMaster, The workbenches KAS:dev:mkv-23320-occt (GIT branch CR23320) KAS:dev:mkv-23320-products (GIT master) were compiled on Linux platform and tested. Regression: Not detected Improvements: Not detected Testing case: Not needed See results in /QADisk/occttests/results/KAS/dev/mkv-23320-products_20072012/lin See reference results in /QADisk/occttests/results/KAS/dev/products-20120706-opt_06072012/lin See test cases in /QADisk/occttests/tests/ED |
|
occt: master b31fce37 2012-07-18 10:43:54 Details Diff |
0023320: The body of 'OpenCollector' function is fully equivalent to the body of 'CloseCollector' function When opening the collector setting the corresponding flag to Standard_False. |
Affected Issues 0023320 |
|
| mod - src/AIS/AIS_InteractiveContext.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-07-18 13:32 | Pawel | New Issue | |
| 2012-07-18 13:32 | Pawel | Assigned To | => Pawel |
| 2012-07-18 14:56 | Pawel | Note Added: 0021047 | |
| 2012-07-18 14:56 | Pawel | Assigned To | Pawel => bugmaster |
| 2012-07-18 14:56 | Pawel | Status | new => resolved |
| 2012-07-19 19:56 |
|
Note Added: 0021080 | |
| 2012-07-19 19:56 |
|
Status | resolved => reviewed |
| 2012-07-19 20:13 |
|
Note Added: 0021081 | |
| 2012-07-20 11:42 |
|
Assigned To | bugmaster => mkv |
| 2012-07-23 18:08 | apn | Note Added: 0021131 | |
| 2012-07-23 18:08 | apn | Test case number | => Not needed |
| 2012-07-23 18:08 | apn | Assigned To | mkv => bugmaster |
| 2012-07-23 18:08 | apn | Status | reviewed => tested |
| 2012-07-30 16:31 | Pawel | Changeset attached | => occt master b31fce37 |
| 2012-07-30 16:33 | Pawel | Assigned To | bugmaster => Pawel |
| 2012-07-30 16:33 | Pawel | Status | tested => verified |
| 2012-07-30 16:33 | Pawel | Resolution | open => fixed |
| 2012-08-15 10:30 |
|
Target Version | 6.5.3 => 6.5.4 |
| 2012-11-16 13:14 | bugmaster | Fixed in Version | => 6.5.4 |
| 2012-11-16 13:17 | bugmaster | Status | verified => closed |
