View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0023264 | Community | OCCT:Visualization | public | 2012-07-12 12:12 | 2012-11-16 13:17 |
| Reporter | Pawel | Assigned To | Pawel | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | Windows | OS | VC++ 2005 | ||
| Product Version | 6.5.3 | ||||
| Target Version | 6.5.4 | Fixed in Version | 6.5.4 | ||
| Summary | 0023264: cppcheck warning: Logical conjunction always evaluates to false | ||||
| Description | The problem is in Visual3d_Light.cxx, lines 143, 147, 189, 193, 381, 402. I guess the attenuation factors should lie within the range <0; 1> so the operator '||' should be used instead of '&&'. | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
Corresponding git branch pushed. Please review. |
|
|
No remarks, please test |
|
|
Dear BugMaster, The workbenches KAS:dev:mkv-23264-occt (GIT branch CR23264) KAS:dev:mkv-23264-products (GIT master) were compiled on Linux platform and tested. Regression: Not detected Improvements: Not detected Testing case: Not needed See results in /QADisk/occttests/results/KAS/dev/mkv-23264-products_13072012/lin See reference results in /QADisk/occttests/results/KAS/dev/products-20120622-opt_22062012/lin See test cases in /QADisk/occttests/tests/ED N.B. In order to launch testing case you can make use the following instructions http://doc/doku.php?id=occt:certification |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-07-12 12:12 | Pawel | New Issue | |
| 2012-07-12 12:12 | Pawel | Assigned To | => Pawel |
| 2012-07-12 12:18 | Pawel | Note Added: 0020924 | |
| 2012-07-12 12:18 | Pawel | Status | new => resolved |
| 2012-07-12 13:45 | Pawel | Assigned To | Pawel => bugmaster |
| 2012-07-13 12:53 |
|
Note Added: 0020947 | |
| 2012-07-13 12:53 |
|
Status | resolved => reviewed |
| 2012-07-13 15:24 |
|
Assigned To | bugmaster => mkv |
| 2012-07-16 13:11 |
|
Note Added: 0020985 | |
| 2012-07-16 13:12 |
|
Test case number | => Not needed |
| 2012-07-16 13:12 |
|
Assigned To | mkv => bugmaster |
| 2012-07-16 13:12 |
|
Status | reviewed => tested |
| 2012-07-23 12:20 | Pawel | Changeset attached | => occt master 76021966 |
| 2012-07-23 12:21 | Pawel | Assigned To | bugmaster => Pawel |
| 2012-07-23 12:21 | Pawel | Status | tested => verified |
| 2012-07-23 12:21 | Pawel | Resolution | open => fixed |
| 2012-11-16 13:15 | bugmaster | Fixed in Version | => 6.5.4 |
| 2012-11-16 13:17 | bugmaster | Status | verified => closed |
