View Issue Details

IDProjectCategoryView StatusLast Update
0023206Open CASCADEOCCT:Modeling Algorithmspublic2019-09-19 06:12
ReporterszvAssigned Tomsv 
PrioritylowSeverityintegration request 
Status closedResolutionwon't fix 
PlatformAOSL 
Product Version6.3.0 
Summary0023206: Fixes by Jane (Jiangtao) Hu
DescriptionThese contributions were submitted by Jane (Jiangtao) Hu to the "Community projects" section on ORG site. This section will be eliminated, and we register these contributions here, so not to loose them.

1) Tolerance control in Extrema
During solving a bug, I notice that in point Extrema code, tolerance check isn't carried over to details, thus boundary points often can't be found in the U V space. I have following patches to correct it, as bugs coming, I may have more patches to fix similar problems.
http://homepages.cae.wisc.edu/~janeh/OCC/patch6.3.html

2) fix for RepClass_FaceClassifier.cxx
I have submitted this bug fix for 6.2 and was accepted in it, just found that it's not exported to 6.3. Hence re-submit it for 6.3.
http://homepages.cae.wisc.edu/~janeh/OCC/patch.html

3) Error fix for valgrind checking on SortTools_QuickSort.gxx
Run opencascade against valgrind, it gives error on overlapping memory for SortTools_QuickSort.gxx : 32.
I added a check at line 32:
32 if(Middle != (Right - 1)) ----Added check
33 Exchange(TheArray(Middle), TheArray(Right - 1));
The valgrind errors went away.

4) point contaiment function
In opencascade minor release 6.2.1, I've reported and fixed the error of not performing on point check problem. This caused all check for point containment be "OUTSIDE". It's been accepted in that release.
However, I am surprised to find that release 6.3 doesn't have this fix.
I am attaching the fix here:
--- BRepClass_FaceClassifier.cxx_6.3 2009-04-16 12:47:20.000000000 -0500
+++ BRepClass_FaceClassifier.cxx 2009-04-15 14:51:06.000000000 -0500
@@ -55,6 +55,7 @@
Extrema_ExtPS myExtrem;
//-- myExtrem.Initialize(HS, U1, U2, V1, V2, Tol, Tol);
myExtrem.Initialize(Surf, U1, U2, V1, V2, Tol, Tol);
+ myExtrem.Perform(P);
//----------------------------------------------------------
//-- On cherche le point le plus proche , PUIS
//-- On le classifie.
I'd appreciate some one internal of opencascade reply on this regarding if it's an appropriate change or you have other thoughts on it.
Thank you!
Jane
TagsNo tags attached.
Test case number

Activities

abv

2019-09-19 06:11

manager   ~0087284

Closing as outdated (no test cases, no ways to check)

Issue History

Date Modified Username Field Change
2012-06-15 14:56 szv New Issue
2012-06-15 14:56 szv Assigned To => jgv
2012-06-15 14:57 szv Summary Fixes by Jane Hu and Jiangtao Hu => Fixes by Jane (Jiangtao) Hu
2017-07-19 19:01 mkv Assigned To jgv => msv
2017-07-19 19:01 mkv Status new => assigned
2019-09-19 06:11 abv Note Added: 0087284
2019-09-19 06:12 abv Status assigned => closed
2019-09-19 06:12 abv Resolution open => won't fix