0023147: Suspicious if (5)

Notes
(0021830) omy (developer) 2012-10-18 12:22	Dear JGV, Fix is integrated to branch CR23147 (see commit message for details). Please review.

(0021831) Pawel (developer) 2012-10-18 12:44	Dear omy, in the proposed solution in line 536 there is an 'else' without the corresponding 'if'. Please, have a look at it. Thank you. Pawel

(0021832) omy (developer) 2012-10-18 14:21	Dear Pawel, I've fixed the mistake. Thank you for finding it.

(0021877) jgv (developer) 2012-10-22 11:39	No remarks

(0021914) mkv (tester) 2012-10-24 10:38	Dear BugMaster, Branch CR23147 (and products from GIT master) was compiled on Linux and Windows platforms. There is compilation error on Linux platform: http://jenkins-test-01.nnov.opencascade.com/user/mnt/my-views/view/CR23147/job/mnt-CR23147-master_build_occt_linux/1/parsed_console/? [^] ../../../src/GeomFill/GeomFill_NSections.cxx: In member function 'void GeomFill_NSections::ComputeSurface()': ../../../src/GeomFill/GeomFill_NSections.cxx:557: error: 's2Point' was not declared in this scope make[2]: *** [GeomFill_NSections.lo] Error 1

(0021937) omy (developer) 2012-10-25 12:14	Dear MKV, I've fixed this error. Please, test

(0022005) apn (administrator) 2012-10-30 11:19	Dear BugMaster, Branch CR23147 (and products from GIT master) was compiled on Linux and Windows platforms and tested. Regression: Not detected Improvements: Not detected Testing case: Not needed

Related Changesets
occt: master 9046e4fc Timestamp: 2012-11-02 11:18:21 Author: omy [ Details ] [ Diff ]	0023147: Suspicious if (5) Removed non-executed parts of code because Standard_Boolean s1Point = Standard_False; Standard_Boolean s2Point = Standard_False; Standard_Boolean vClosed = Standard_False; and never changed thus some parts of code are non-reachable. Fixed mistake with 'else' without corresponding 'if'. Commented unreachable code part.
	mod - src/GeomFill/GeomFill_NSections.cxx	[ Diff ] [ File ]