0023145: Suspicious else (2)

ID	Project	Category	View Status	Date Submitted	Last Update

0023145	Community	OCCT:Modeling Algorithms	public	2012-05-06 19:50	2012-11-16 13:18

Reporter	QbProg	Assigned To	ika
Priority	normal	Severity	minor
Status	closed	Resolution	fixed
Platform	Windows	OS	VC++ 2010
Product Version	6.5.3
Target Version	6.5.4	Fixed in Version	6.5.4

Summary	0023145: Suspicious else (2)
Description	src\LocalAnalysis\LocalAnalysis_SurfaceContinuity.cxx , LocalAnalysis_SurfaceContinuity::SurfC1 There are two if/else that have the same behavoir. if (norm1v >= norm2v ) myLambda1V= norm2v / norm1v; else myLambda1V = norm2v / norm1v; (... and another below)
Tags	No tags attached.

Test case number	Not needed

ika 2012-10-16 18:16 developer ~0021806	Else statement was incorrect, is has been changed. Git branch CR23145 is ready to be reviewed. Dear Oleg, Please review.

oan 2012-10-16 19:59 developer ~0021810	Dear JGV, Please review.

~~jgv~~ 2012-10-19 16:03 developer ~0021856	No remarks

~~mkv~~ 2012-10-29 18:10 tester ~0021996	Dear BugMaster, Branch CR23145 (and products from GIT master) was compiled on Linux and Windows platforms and tested. Regressions: Not detected Improvements: Not detected Testing cases: Not needed

Date Modified	Username	Field	Change
2012-05-06 19:50	QbProg	New Issue
2012-05-06 19:50	QbProg	Assigned To	=> jgv
2012-05-07 09:18	~~abv~~	Relationship added	child of 0023132
2012-05-07 09:25	~~abv~~	Assigned To	jgv => dbv
2012-05-07 09:25	~~abv~~	Status	new => assigned
2012-05-07 09:26	~~abv~~	Target Version	=> 6.5.4
2012-10-09 18:40	oan	Assigned To	dbv => ika
2012-10-16 18:16	ika	Note Added: 0021806
2012-10-16 18:17	ika	Status	assigned => resolved
2012-10-16 18:17	ika	Assigned To	ika => oan
2012-10-16 19:59	oan	Assigned To	oan => jgv
2012-10-16 19:59	oan	Note Added: 0021810
2012-10-19 16:03	~~jgv~~	Note Added: 0021856
2012-10-19 16:03	~~jgv~~	Status	resolved => reviewed
2012-10-23 15:57	~~mkv~~	Assigned To	jgv => mkv
2012-10-29 18:10	~~mkv~~	Note Added: 0021996
2012-10-29 18:11	~~mkv~~	Test case number	=> Not needed
2012-10-29 18:11	~~mkv~~	Assigned To	mkv => bugmaster
2012-10-29 18:11	~~mkv~~	Status	reviewed => tested
2012-11-06 19:02	ika	Changeset attached	=> occt master 9a79c952
2012-11-06 19:03	ika	Assigned To	bugmaster => ika
2012-11-06 19:03	ika	Status	tested => verified
2012-11-06 19:03	ika	Resolution	open => fixed
2012-11-16 13:13	bugmaster	Fixed in Version	=> 6.5.4
2012-11-16 13:18	bugmaster	Status	verified => closed

occt: master 9a79c952 2012-10-16 14:10:31 ika Details Diff	0023145: Suspicious else (2) else statement was incorrect, is has been changed.		Affected Issues 0023145
	mod - src/LocalAnalysis/LocalAnalysis_SurfaceContinuity.cxx		Diff File