0023113: Incorrect use of parameter EnlargeCoeff in class GeomPlate_MakeApprox

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0023113

Community

[OCCT] OCCT:Modeling Algorithms

public

2012-04-16 17:54

2017-07-19 16:53

Reporter

Alexander Schneller

Assigned To

msv

Priority

normal

Severity

just a question

Status

assigned

Resolution

open

Platform

OS Version

Product Version

[OCCT] 6.5.2

Target Version

Fixed in Version

Summary

0023113: Incorrect use of parameter EnlargeCoeff in class GeomPlate_MakeApprox

Description

Forum: http://www.opencascade.org/org/forum/thread_23128/?forum=3 [^]

The parameter "EnlargeCoeff" in both constructors of the class GeomPlate_MakeApprox, don't enlarge the surface in all cases.

If U or V == 0 the value remains the same
If U0 or V0 > 0 the surface is even smaller

I think the old code:

U0 = EnlargeCoeff * U0;
U1 = EnlargeCoeff * U1;
V0 = EnlargeCoeff * V0;
V1 = EnlargeCoeff * V1;

should be changed to:

UInterval = U1 - U0;
VInterval = V1 - V0;

UEnlarge = (EnlargeCoeff*UInterval - UInterval) * 0.5;
VEnlarge = (EnlargeCoeff*VInterval - VInterval) * 0.5;

if(UEnlarge < 0 ) UEnlarge = -UEnlarge;
if(VEnlarge < 0 ) VEnlarge = -VEnlarge;

U0 -= UEnlarge;
U1 += UEnlarge;

V0 -= VEnlarge;
V1 += VEnlarge;

Tags

No tags attached.

Test case number

Not needed

Attached Files

Relationships

Notes
(0020404) Alexander Schneller (reporter) 2012-04-17 11:38 edited on: 2012-04-17 11:39	The two lines are wrong if(UEnlarge < 0 ) UEnlarge = -UEnlarge; if(VEnlarge < 0 ) VEnlarge = -VEnlarge; they must be omitted.

Issue History
Date Modified	Username	Field	Change
2012-04-16 17:54	Alexander Schneller	New Issue
2012-04-16 17:54	Alexander Schneller	Assigned To	=> jgv
2012-04-17 11:38	Alexander Schneller	Note Added: 0020404
2012-04-17 11:39	Alexander Schneller	Note Edited: 0020404	View Revisions
2017-07-19 16:53	mkv	Test case number	=> Not needed
2017-07-19 16:53	mkv	Assigned To	jgv => msv
2017-07-19 16:53	mkv	Status	new => assigned