View Issue Details

IDProjectCategoryView StatusLast Update
0023113CommunityOCCT:Modeling Algorithmspublic2017-07-19 16:53
ReporterAlexander Schneller Assigned Tomsv 
PrioritynormalSeverityjust a question 
Status assignedResolutionopen 
PlatformAOSL 
Product Version6.5.2 
Summary0023113: Incorrect use of parameter EnlargeCoeff in class GeomPlate_MakeApprox
DescriptionForum: http://www.opencascade.org/org/forum/thread_23128/?forum=3

The parameter "EnlargeCoeff" in both constructors of the class GeomPlate_MakeApprox, don't enlarge the surface in all cases.

If U or V == 0 the value remains the same
If U0 or V0 > 0 the surface is even smaller

I think the old code:

U0 = EnlargeCoeff * U0;
U1 = EnlargeCoeff * U1;
V0 = EnlargeCoeff * V0;
V1 = EnlargeCoeff * V1;

should be changed to:

UInterval = U1 - U0;
VInterval = V1 - V0;

UEnlarge = (EnlargeCoeff*UInterval - UInterval) * 0.5;
VEnlarge = (EnlargeCoeff*VInterval - VInterval) * 0.5;

if(UEnlarge < 0 ) UEnlarge = -UEnlarge;
if(VEnlarge < 0 ) VEnlarge = -VEnlarge;

U0 -= UEnlarge;
U1 += UEnlarge;

V0 -= VEnlarge;
V1 += VEnlarge;
TagsNo tags attached.
Test case numberNot needed

Activities

Alexander Schneller

2012-04-17 11:38

reporter   ~0020404

Last edited: 2012-04-17 11:39

The two lines are wrong

if(UEnlarge < 0 ) UEnlarge = -UEnlarge;
if(VEnlarge < 0 ) VEnlarge = -VEnlarge;

they must be omitted.

Issue History

Date Modified Username Field Change
2012-04-16 17:54 Alexander Schneller New Issue
2012-04-16 17:54 Alexander Schneller Assigned To => jgv
2012-04-17 11:38 Alexander Schneller Note Added: 0020404
2012-04-17 11:39 Alexander Schneller Note Edited: 0020404
2017-07-19 16:53 mkv Test case number => Not needed
2017-07-19 16:53 mkv Assigned To jgv => msv
2017-07-19 16:53 mkv Status new => assigned