View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0023098 | Community | OCCT:Configuration | public | 2012-04-11 15:43 | 2012-11-16 13:18 |
| Reporter | Pawel | Assigned To | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | Windows | OS | VC++ 2008 | ||
| Product Version | 6.5.3 | ||||
| Target Version | 6.5.4 | Fixed in Version | 6.5.4 | ||
| Summary | 0023098: Cppcheck warnings/errors in QA files | ||||
| Description | There are multiple QAxxx files in the distribution that can be pulled from the server. I assume they are some quality assurance routines bur wasn't sure about that. Cppcheck 1.53 diagnoses multiple problems within those file. As I don't know how to compile the files I attach a screenshot with the cppcheck report. | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
cppcheck_QA_problems.png (54,382 bytes) |
|
|
The first two errors relate to accesses violation test and divide by zero test, respectively. So, it is normal that Cppcheck reports them. All other listed error has been fixed. Git branch CR23098 is ready to be reviewed. Dear Andrey, Please review. |
|
|
In QABugs_3.cxx, line 229 still contains delete without []. Please revise the code around: it has no sense (I guess unreacheable code warning should be reported). I suggest this function should accept complete path instead of trying to construct it with use of environment variable; this will eliminate the need to allocate the memory and its consequences. In QADNaming_IteratorsCommands.cxx, please use either TCollection_AsciiString or automatic variable. In QANewModTopOpe.cxx, why not reverting to use of math_Mat which is there but commented out? In QANewDBRepNaming_FeatureCommands.cxx: is the command under question used in tests? it seems it should never work before... The same is worth to be checked for all other commands. |
|
|
Remarks have been fixed. Branch has been rebased and pushed to the git CR23098_1 Dear Andrey, Please review. |
|
|
No remarks, please test |
|
|
Dear BugMaster, Branch CR23098_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested. Regressions: chl 902 D1 nam 001 A2 Improvements: Not detected Testing cases: Not needed See results in /QADisk/occttests/results/KAS/dev/CR23098-master-products_04102012/lin See reference results in /QADisk/occttests/results/KAS/dev/IR-2012-09-27-master-products_27092012/lin See test cases in /QADisk/occttests/tests/ED |
|
|
Dear mkv, Function BUC60609 from src/QABugs/QABugs_3.cxx now accept full path to the file instead of constructing it from environment variable. Thus test case chl 902 D1 should be modified. Regression nam 001 A2 has been fixed. Dear Andrey, Please review. |
|
|
No remarks (sorry for oversight!), please test |
|
|
Dear BugMaster, Branch CR23098_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested. Regressions: nam 001 A2 Improvements: Not detected Testing cases: Not needed See results in /QADisk/occttests/results/KAS/dev/CR23098-master-2-products_05102012/lin See reference results in /QADisk/occttests/results/KAS/dev/IR-2012-09-27-master-products_27092012/lin See test cases in /QADisk/occttests/tests/ED Test case chl 902 D1 will be modified after raising this fix. |
|
2012-10-08 14:17 tester |
D1 (569 bytes) |
|
|
Regression fixed. Please review. |
|
|
No remarks, please test |
|
|
Dear BugMaster, Branch CR23098_1 (and products from GIT master) was compiled on Linux and Windows platforms and tested. Regressions: Not detected Improvements: Not detected Testing cases: Not needed See results in /QADisk/occttests/results/KAS/dev/CR23098-master-2-products_05102012/lin See reference results in /QADisk/occttests/results/KAS/dev/IR-2012-09-27-master-products_27092012/lin See test cases in /QADisk/occttests/tests/ED Test case chl 902 D1 will be modified after raising this fix. |
|
occt: master f1e162f2 2012-10-12 10:23:00
|
0023098: Cppcheck warnings/errors in QA files Fix for cppcheck warnings Warning fixes |
Affected Issues 0023098 |
|
| mod - src/QABugs/QABugs_13.cxx | Diff File | ||
| mod - src/QABugs/QABugs_3.cxx | Diff File | ||
| mod - src/QABugs/QABugs_7.cxx | Diff File | ||
| mod - src/QADNaming/QADNaming_IteratorsCommands.cxx | Diff File | ||
| mod - src/QADraw/QADraw.cxx | Diff File | ||
| mod - src/QANewDBRepNaming/QANewDBRepNaming.cxx | Diff File | ||
| mod - src/QANewModTopOpe/QANewModTopOpe.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-04-11 15:43 | Pawel | New Issue | |
| 2012-04-11 15:43 | Pawel | Assigned To | => bugmaster |
| 2012-04-11 15:43 | Pawel | File Added: cppcheck_QA_problems.png | |
| 2012-04-11 19:58 |
|
Assigned To | bugmaster => dbv |
| 2012-04-11 19:58 |
|
Status | new => assigned |
| 2012-06-22 13:23 |
|
Note Added: 0020762 | |
| 2012-06-22 13:23 |
|
Assigned To | dbv => abv |
| 2012-06-22 13:23 |
|
Status | assigned => resolved |
| 2012-06-22 18:29 |
|
Note Added: 0020772 | |
| 2012-06-22 18:29 |
|
Assigned To | abv => dbv |
| 2012-06-22 18:29 |
|
Status | resolved => assigned |
| 2012-10-03 18:58 |
|
Note Added: 0021647 | |
| 2012-10-03 18:58 |
|
Assigned To | dbv => abv |
| 2012-10-03 18:58 |
|
Status | assigned => resolved |
| 2012-10-03 19:07 |
|
Note Added: 0021648 | |
| 2012-10-03 19:07 |
|
Assigned To | abv => bugmaster |
| 2012-10-03 19:07 |
|
Status | resolved => reviewed |
| 2012-10-04 11:59 | Pawel | Relationship added | has duplicate 0023266 |
| 2012-10-04 12:36 |
|
Assigned To | bugmaster => mkv |
| 2012-10-05 12:11 |
|
Note Added: 0021666 | |
| 2012-10-05 12:13 |
|
Test case number | => Not needed |
| 2012-10-05 12:13 |
|
Assigned To | mkv => dbv |
| 2012-10-05 12:13 |
|
Status | reviewed => assigned |
| 2012-10-05 13:26 |
|
Note Added: 0021668 | |
| 2012-10-05 13:26 |
|
Assigned To | dbv => abv |
| 2012-10-05 13:26 |
|
Status | assigned => resolved |
| 2012-10-05 14:29 |
|
Note Added: 0021671 | |
| 2012-10-05 14:29 |
|
Assigned To | abv => bugmaster |
| 2012-10-05 14:29 |
|
Status | resolved => reviewed |
| 2012-10-05 18:03 |
|
Assigned To | bugmaster => mkv |
| 2012-10-08 14:13 |
|
Note Added: 0021677 | |
| 2012-10-08 14:17 |
|
File Added: D1 | |
| 2012-10-08 14:20 |
|
Assigned To | mkv => dbv |
| 2012-10-08 14:20 |
|
Status | reviewed => assigned |
| 2012-10-08 14:55 |
|
Note Edited: 0021677 | |
| 2012-10-09 11:46 |
|
Note Added: 0021692 | |
| 2012-10-09 11:46 |
|
Status | assigned => resolved |
| 2012-10-09 11:46 |
|
Assigned To | dbv => abv |
| 2012-10-09 20:53 |
|
Note Added: 0021703 | |
| 2012-10-09 20:53 |
|
Status | resolved => reviewed |
| 2012-10-10 18:49 |
|
Assigned To | abv => mkv |
| 2012-10-12 12:31 |
|
Note Added: 0021746 | |
| 2012-10-12 12:32 |
|
Assigned To | mkv => bugmaster |
| 2012-10-12 12:32 |
|
Status | reviewed => tested |
| 2012-10-16 15:21 |
|
Changeset attached | => occt master f1e162f2 |
| 2012-10-16 15:21 |
|
Assigned To | bugmaster => dbv |
| 2012-10-16 15:21 |
|
Status | tested => verified |
| 2012-10-16 15:21 |
|
Resolution | open => fixed |
| 2012-10-24 17:08 |
|
Target Version | => 6.5.4 |
| 2012-11-16 13:14 | bugmaster | Fixed in Version | => 6.5.4 |
| 2012-11-16 13:18 | bugmaster | Status | verified => closed |
| 2014-01-11 11:58 |
|
Category | OCCT:Development Environment => OCCT:Configuration |
