View Issue Details

IDProjectCategoryView StatusLast Update
0022969CommunityOCCT:Modeling Algorithmspublic2012-04-03 13:30
ReporterRoberto Ciarloni Assigned Tobugmaster  
PriorityurgentSeverityintegration request 
Status closedResolutionfixed 
PlatformWindowsOSVC++ 2010 
Product Version6.5.1 
Target Version6.5.3Fixed in Version6.5.3 
Summary0022969: Wrong confusion in BRepLib_MakeEdge
DescriptionI am afraid I have found a bug in
BRepLib_MakeEdge::Init(const Handle(Geom_Curve)& CC,
           const TopoDS_Vertex& VV1,
           const TopoDS_Vertex& VV2,
           const Standard_Real pp1,
           const Standard_Real pp2)
in file src\BRepLib\BRepLib_MakeEdge.cxx at line 766:
Standard_Real epsilon = Precision::Confusion();

This "epsilon" is used to check if two parameters on a curve are coincident.
But Precision::Confusion() is a 3d tolerance, not 1d.
It seems to me Precision::PConfusion() should be used, which is made for parameters.
Additional information
and documentation updates
fixed in attachment
TagsNo tags attached.
Test case numberTest case is not required

Attached Files

  • BRepLib_MakeEdge.cxx (30,793 bytes)
  • To_OCC-1_Contribution.docx (24,795 bytes)

Activities

Roberto Ciarloni

2012-02-01 20:31

reporter  

BRepLib_MakeEdge.cxx (30,793 bytes)

szy

2012-02-02 11:30

manager  

To_OCC-1_Contribution.docx (24,795 bytes)

szy

2012-02-02 11:30

manager   ~0019344

Added additional file with description - To_OCC-1_Contribution.docx.

dbv

2012-02-09 12:05

developer   ~0019486

Fix has been applied and reviewed without remarks.

Branch http://svn/svn/occt/branches/OCC22969 is ready for testing.

Please test.

apn

2012-02-10 15:08

administrator   ~0019510

Dear BugMaster,
   Workbench KAS:dev:mkv-22969-occt was created from SVN branch http://svn/svn/occt/branches/OCC22969
   (and mkv-22969-products from trunk) and compiled on Linux and Windows platforms.
   
   There are not regressions in mkv-22969-products regarding to KAS:dev:products-20120203-opt
   
   See results in /QADisk/occttests/results/KAS/dev/ mkv-22969-products_09022012/lin
   See reference results in /QADisk/occttests/results/KAS/dev/products-20120203-opt_03022012/lin
   See test cases in /QADisk/occttests/tests/ED

bugmaster

2012-02-10 17:14

administrator   ~0019516

Integrated into trunk of occt repository

Date: 2012-02-10 16:57:17 +0400 (Fri, 10 Feb 2012)
New Revision: 10421

Modified:
   trunk/src/BRepLib/BRepLib_MakeEdge.cxx

Related Changesets

occt: master da9d480f

2012-02-10 12:57:17

dbv


Committer: bugmaster Details Diff
0022969: Wrong confusion in BRepLib_MakeEdge Affected Issues
0022969
mod - src/BRepLib/BRepLib_MakeEdge.cxx Diff File

Issue History

Date Modified Username Field Change
2012-02-01 20:31 Roberto Ciarloni New Issue
2012-02-01 20:31 Roberto Ciarloni Assigned To => jgv
2012-02-01 20:31 Roberto Ciarloni File Added: BRepLib_MakeEdge.cxx
2012-02-02 07:42 abv Assigned To jgv => dbv
2012-02-02 07:42 abv Status new => assigned
2012-02-02 10:38 bugmaster Project Open CASCADE => Community
2012-02-02 11:30 szy File Added: To_OCC-1_Contribution.docx
2012-02-02 11:30 szy Note Added: 0019344
2012-02-09 12:03 dbv Status assigned => resolved
2012-02-09 12:05 dbv Note Added: 0019486
2012-02-09 12:05 dbv Status resolved => reviewed
2012-02-10 15:08 apn Note Added: 0019510
2012-02-10 15:11 apn Test case number => Test case is not required
2012-02-10 15:11 apn Status reviewed => tested
2012-02-10 17:13 bugmaster Target Version => 6.5.3
2012-02-10 17:14 bugmaster Note Added: 0019516
2012-02-10 17:14 bugmaster Status tested => verified
2012-02-10 17:14 bugmaster Resolution open => fixed
2012-03-29 17:26 bugmaster Changeset attached => occt master da9d480f
2012-04-03 13:30 abv Assigned To dbv => Roberto Ciarloni