View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0022961 | Community | OCCT:Data Exchange | public | 2012-01-31 15:11 | 2012-04-16 12:24 |
Reporter | Pawel | Assigned To | bugmaster | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Platform | A | OS | L | ||
Product Version | 6.5.2 | ||||
Target Version | 6.5.3 | Fixed in Version | 6.5.3 | ||
Summary | 0022961: Dangerous usage of 'buf' (strncpy doesn't always 0-terminate it) (cppcheck report) | ||||
Description | in VrmlData_Scene.cxx (line 1015) / VrmlData_Group.cxx (line 276) | ||||
Tags | No tags attached. | ||||
Test case number | Test case is not required | ||||
|
Added 0-termination for "buf" variable. Branch http://svn/svn/occt/branches/OCC22961 is ready to be reviewed. Dear Andrey, Please review. |
|
TCollection_AsciiString used instead of char arrays Branch http://svn/svn/occt/branches/OCC22961 is ready to be reviewed. Dear Andrey, Please review. |
|
Review remark: in VrmlData_Group.cxx, if '.' is found in the string, the string should be truncated after it is replaced by '_' (at least it seems how it were before the fix). Please check and correct |
|
Remark fixed. Branch http://svn/svn/occt/branches/OCC22961 is ready to be reviewed. Dear Andrey, Please review. |
|
No remarks; please test |
|
Dear BugMaster, SVN branch http://svn/svn/occt/branches/OCC22961 has been moved to GIT CR22961 one. Workbench KAS:dev:mkv-22961-occt was created from git branch CR22961 (and mkv-22961-products from svn trunk) and compiled on Linux platform. There are not regressions in mkv-22961-products regarding to KAS:dev:products-20120306-opt See results in /QADisk/occttests/results/KAS/dev/mkv-22961-products_11032012/lin See reference results in /QADisk/occttests/results/KAS/dev/products-20120306-opt_07032012/lin See test cases in /QADisk/occttests/tests/ED N.B. In order to launch testing case you can make use the following instructions http://doc/doku.php?id=occt:certification |
|
Integrated into master |
|
Verified. Please close. |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-01-31 15:11 | Pawel | New Issue | |
2012-01-31 15:11 | Pawel | Assigned To | => gka |
2012-02-14 13:04 |
|
Assigned To | gka => dbv |
2012-02-14 13:04 |
|
Status | new => assigned |
2012-03-02 10:53 |
|
Note Added: 0019845 | |
2012-03-02 10:53 |
|
Assigned To | dbv => abv |
2012-03-02 10:53 |
|
Status | assigned => resolved |
2012-03-02 15:02 |
|
Note Added: 0019851 | |
2012-03-06 10:54 |
|
Note Added: 0019872 | |
2012-03-06 10:54 |
|
Assigned To | abv => dbv |
2012-03-06 10:54 |
|
Status | resolved => assigned |
2012-03-06 11:20 |
|
Note Added: 0019875 | |
2012-03-06 11:20 |
|
Assigned To | dbv => abv |
2012-03-06 11:20 |
|
Status | assigned => resolved |
2012-03-06 12:11 |
|
Note Added: 0019879 | |
2012-03-06 12:11 |
|
Assigned To | abv => dbv |
2012-03-06 12:11 |
|
Status | resolved => reviewed |
2012-03-06 12:14 |
|
Assigned To | dbv => mkv |
2012-03-12 13:01 |
|
Note Added: 0019934 | |
2012-03-12 13:02 |
|
Test case number | => Test case is not required |
2012-03-12 13:02 |
|
Assigned To | mkv => bugmaster |
2012-03-12 13:02 |
|
Status | reviewed => tested |
2012-03-15 18:57 | bugmaster | Target Version | => 6.5.3 |
2012-03-15 19:15 | bugmaster | Note Added: 0020006 | |
2012-03-15 19:15 | bugmaster | Status | tested => verified |
2012-03-15 19:15 | bugmaster | Resolution | open => fixed |
2012-03-15 19:15 | bugmaster | Assigned To | bugmaster => dbv |
2012-03-29 17:26 | bugmaster | Changeset attached | => occt master b6710675 |
2012-04-03 13:33 |
|
Assigned To | dbv => Pawel |
2012-04-12 17:24 | Pawel | Note Added: 0020374 | |
2012-04-16 12:24 | Pawel | Assigned To | Pawel => bugmaster |