View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0022867Open CASCADEOCCT:Meshpublic2011-12-20 15:312012-12-29 09:36
Reporterepv Assigned Tobugmaster  
PrioritynormalSeveritymajor 
Status closedResolutionfixed 
PlatformAOSL 
Product Version6.5.2 
Summary0022867: Avoid performing mesh of a singled face model in parallel mode when flag IsParallel is set to true.
DescriptionNow meshing of a singled face model is performed in parallel mode if IsParallel flag is set to true. It slows down the execution and should be always done in sequential mode.
TagsNo tags attached.
Test case number

Activities

epv

2012-01-27 12:51

reporter   ~0019283

Dear, Alexander, please provide a detailed explanation why this issue occurs and a test where it is reproduced.

kgv

2012-03-27 17:24

developer   ~0020175

Dear azn, apv, pdn and Bugmaster,
please process bugs according to our rules!

This bug was integrated without correct tracking
within another patch 0022866 that even doesn't linked with this one!

My small comments:

MeshTest.cxx, line 204-207
> Standard_Boolean isInParallel = Standard_False;
> if (nbarg == 4) {
> isInParallel = atoi(argv[3]) == 1;
> }
Recommendation: this is preferred to test greater-equal rather than equality
for simpler command extension in future.
This assignment could be checked within one line like this:
Standard_Boolean isInParallel = (nbarg >= 4) && (atoi(argv[3]) == 1);

MeshTest.cxx, line 211
> Standard::SetReentrant(isInParallel);
This is dangerous to silently disable reentrant controls!


BRepMesh_IncrementalMesh.cxx, line 90
> const Standard_Boolean theInParallel)
Dear azn, here and in other places - please configure your editor to use space symbols instead of tabulation! Tabulation is forbidden in C++ sources of by OCCT coding rules.

StlAPI_Writer.cdl, line 71
> InParallel : Boolean from Standard = Standard_False);
> ---Purpose: Converts a given shape to STL format and writes it to file with a given filename.
Description is missing for new flag.

StlAPI_Writer.cxx, line 57
> void StlAPI_Writer::Write(const TopoDS_Shape& theShape, const Standard_CString theFileName, const Standard_Boolean theInParallel)
This line is too long. Please split it per argument.

abv

2012-04-23 16:40

manager   ~0020430

Note that the history of commits in the repository contains a commit incorrectly attributed to this issue; it is actually commit for 0022866

Related Changesets

occt: master 416d4426

2012-03-23 11:31:00

azn


Committer: bugmaster Details Diff		 0022867: Avoid performing mesh of a singled face model in parallel mode when flag IsParallel is set to true. Affected Issues
0022867
mod - src/BRepMesh/BRepMesh_IncrementalMesh.cdl Diff File
mod - src/BRepMesh/BRepMesh_IncrementalMesh.cxx Diff File
mod - src/MeshTest/MeshTest.cxx Diff File
mod - src/QAAMINO/QAAMINO.cxx Diff File
mod - src/StlAPI/StlAPI_Writer.cdl Diff File
mod - src/StlAPI/StlAPI_Writer.cxx Diff File
mod - src/StlTransfer/StlTransfer.cdl Diff File
mod - src/StlTransfer/StlTransfer.cxx Diff File
mod - src/XSDRAWSTLVRML/XSDRAWSTLVRML.cxx Diff File

Issue History

Date Modified Username Field Change
2011-12-20 15:31 epv New Issue
2011-12-20 15:31 epv Assigned To => msv
2011-12-20 15:39 epv Assigned To msv => epv
2011-12-22 13:05 epv Summary Avoid performing mesh in parallel mode when flag IsParallel is set to true. => Avoid performing mesh of a singled face model in parallel mode when flag IsParallel is set to true.
2012-01-27 12:50 epv Assigned To epv => azn
2012-01-27 12:51 epv Note Added: 0019283
2012-01-30 11:09 szy Status new => assigned
2012-02-09 09:56 abv Target Version 6.5.3 => 6.5.4
2012-03-27 17:24 kgv Note Added: 0020175
2012-03-29 17:26 bugmaster Changeset attached => occt master 416d4426
2012-04-23 16:38 abv Changeset removed occt master 416d4426 =>
2012-04-23 16:40 abv Note Added: 0020430
2012-10-23 19:37 abv Target Version 6.5.4 => Unscheduled
2012-11-09 09:49 abv Category OCCT:Modeling Algorithms => OCCT:Mesh
2012-12-29 09:36 abv Target Version Unscheduled =>