View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0022800||Open CASCADE||OCCT:Samples||public||2011-11-09 10:12||2012-03-29 17:26|
|Target Version||6.5.3||Fixed in Version||6.5.3|
|Summary||0022800: OSD::SetSignal(Standard_True) is not called in the standard samples|
|Description||The absence of call OSD::SetSignal(Standard_True) in the standard samples leads to problems in Data Exchange functionality (failures during reading of STEP and IGES files).|
I suggest to insert this call into the constructor of OCC_BaseApp.
|Tags||No tags attached.|
|Test case number||Test case is not required|
The fix is committed to http://svn/svn/occt/branches/0022331.
The fix also contain additional improvements in BRep_Tool.cxx, in connection with 22331.
Andrey, could you please revise the fix?
Code review remarks:
1. Please take care of setting appropriate status on the issue (e.g. set Resolved if you made a fix and want it to be reviewed)
2. Please use branch name the same as issue id when possible (note that branch can be renamed easily)
3. Please revert or revise change in BRep_Tool.cxx: moving static objects to the inside functions does not make them local, but gives the chance to get into concurrent initialization in the case if the function gets called for the first time from several threads simultaneously (it happens in reality!).
4. I wonder how long it took to introduce this obvious change. Well, late is better than never
Suggestion (3) is implemented, the branch in SVN is updated.
Please test the fix.
Workbench KAS:dev:mkv-22800-occt was created from SVN branch http://svn/svn/occt/branches/0022331
(and mkv-22800-products from trunk) and compiled on Linux platform.
There are not regressions in mkv-22800-products regarding to KAS:dev:products-652-opt:
See results in /dn45/occttests/results/KAS/dev/mkv-22800-products_15112011/lin
See reference results in /dn45/occttests/results/KAS/dev/products-652-opt_23092011/lin
See test cases in /dn45/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
Fix has been integrated into occt repository
Date: 2011-11-18 13:21:42 +0400 (Fri, 18 Nov 2011)
New Revision: 9430
occt: master 2b442de5
Committer: bugmaster Details Diff
|0022800: OSD::SetSignal(Standard_True) is not called in the standard samples||
|mod - samples/mfc/standard/Common/OCC_BaseApp.cpp||Diff File|
|mod - src/BRep/BRep_Tool.cxx||Diff File|
|mod - src/SelectMgr/SelectMgr_SelectableObject.cxx||Diff File|
||Assigned To||=> bugmaster|
||Note Added: 0018498|
||Assigned To||bugmaster => abv|
||Status||new => assigned|
||Resolution||open => fixed|
||Note Added: 0018547|
||Assigned To||abv => szv|
||Note Added: 0018548|
||Assigned To||szv => bugmaster|
||Status||assigned => reviewed|
||Note Added: 0018568|
||Test case number||=> Test case is not required|
||Status||reviewed => tested|
|2011-11-18 13:22||bugmaster||Note Added: 0018581|
|2011-11-18 13:22||bugmaster||Status||tested => verified|
|2011-11-23 16:28||bugmaster||Target Version||=> 6.5.3|
|2012-03-29 17:26||bugmaster||Changeset attached||=> occt master 2b442de5|
||Category||OCCT Release:MFC => OCCT Release:Samples|
||Category||OCCT Release:Samples => OCCT:Samples|