View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0022767Open CASCADEOCCT:DRAWpublic2011-10-19 10:402012-03-29 17:26
ReporterabvAssigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version6.5.2 
Target Version6.5.3Fixed in Version6.5.3 
Summary0022767: Extension of DRAW command fixshape
DescriptionCurrently DRAW command fixshape does not provide any report on whether and what fixes have been made. The command should be extended by capabilities to output such information on request. This new capability should be used then in non-regression tests.
TagsNo tags attached.
Test case number

Attached Files

  • example1-notfixed.brep (164,297 bytes)
  • trampafus-notfixed.7z (633,918 bytes)
  • TransmissionTestModel5-notfixed.7z (649,454 bytes)

Activities

dbv

2011-11-21 17:55

developer   ~0018597

Last edited: 2011-11-21 17:56

 Changes in ShapeFix_Face.cxx, ShapeFix_Shell.cxx and ShapeFix_Wire.cxx:
Removed duplicate messages. Most messages now attached to the shape, which was fixed.
Changes in SWDRAW_ShapeFix.cxx:
Added necessary breaks to the switch case statement. fixshape(line 389) now provides information about the number of fixes if called with option '+?' and store all modified shapes in compound if called with '*?'

SVN branch http://svn/svn/occt/branches/OCC22767 is ready to be reviewed

kgv

2011-11-23 16:49

developer   ~0018613

Last edited: 2011-11-23 16:56

 2dbv,

src/SHMessage/SHAPE.us,
it seems that changes are not in sync with French translation (SHAPE.fr)

src/ShapeFix/ShapeFix_Face.cxx, 1273
> SendWarning ( Message_Msg ("FixAdvFace.FixOrientation.MSG5") );//Wire on face was reversed
1) it seems some messages become unusable in code (FixAdvFace.FixOrientation.MSG10), maybe them should be completely removed from message files?
2) code style comment, could you please apply one coding style for spaces with parentheses within at least in one line of code?

src/SWDRAW/SWDRAW_ShapeFix.cxx, 457
> //Counting the number of each type of fixes. If the switch '*?' store all modified shapes in compound.
code style comment, I think that space between // and comments looks better and preferred in OCCT sources

dbv

2011-11-25 13:28

developer   ~0018621

added changes in src/SHMessage/SHAPE.fr
removed FixAdvFace.FixOrientation.MSG10 message as no longer used in the code.
minor changes in source files: corrections associated with the coding style

branch http://svn/svn/occt/branches/OCC22767 is ready to be reviewed

abv

2011-12-01 09:19

manager   ~0018680

Some comments from review:
- resource files SHMessage/SHAPE.* seem to have problem with text encoding: whole file is marked as change
- Messages in FixFace that apply to wires (e.g. FixAdvFace.FixOrientation.MSG11) should perhaps be attached to relevant wires rather than by default (obviously to whole face)
- Message FixWire.FixDegenerated.MSG5 was commented out previously with remark "to avoid extra messages"; it shall probably be left commented

dbv

2011-12-02 16:33

developer   ~0018721

Messages in ShapeFix_Face now attached to the relevant wires.
Message FixWire.FixDegenerated.MSG0 commented out.

Dear Andrey,
Please review the fix.

abv

2011-12-02 16:44

manager   ~0018722

No remarks, the fix is ready for testing

mkv

2011-12-12 19:41

tester   ~0018827

Dear BugMaster,
Workbench KAS:dev:mkv-22767-occt was created from SVN branch http://svn/svn/occt/branches/OCC22767
(and mkv-22767-products from trunk) and compiled on Linux platform.

There are following regressions in mkv-22767-products regarding to KAS:dev:products-652-opt:

xigs 103 U3

See results in /QADisk/occttests/results/KAS/dev/mkv-22767-products_12122011/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-652-opt_23092011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification

dbv

2011-12-13 12:57

developer   ~0018828

Last edited: 2011-12-13 13:00

 Due to changes in /src/ShapeFix/ShapeFix_Face.cxx (line 1682) "tpstat" command now displays a warning messages for this test. Therefore the test case results must be modified in accordance with the current output.

Dear Andrey,
Please review.

abv

2011-12-13 14:08

manager   ~0018829

Please modify test case "xigs 103 U3" as per above comment, and integrate

mkv

2011-12-13 15:47

tester   ~0018830

Dear BugMaster,
Test case xigs/103/U3 will be modified afther integration this fix.

mkv

2011-12-13 15:51

tester   ~0018831

Last edited: 2011-12-13 15:52

 Dear dbv,
I need the examples for testing new capability of fixshape-command.

dbv

2011-12-14 13:38

developer  

example1-notfixed.brep (164,297 bytes)

dbv

2011-12-14 13:58

developer  

trampafus-notfixed.7z (633,918 bytes)

dbv

2011-12-14 13:58

developer  

TransmissionTestModel5-notfixed.7z (649,454 bytes)

dbv

2011-12-14 14:08

developer   ~0018845

Last edited: 2011-12-14 14:08

 Dear mkv,
I attached some files for testing.

"fixshape" usage:
Draw> fixshape res a +?
or
Draw> fixshape res a *?

For example1-notfixed.brep output should look like:

Draw[2]> rest D:/Shapes/example1-notfixed.brep a
a
Draw[3]> fixshape res a +?
 Fix Count
 ------------------------------------------------------------
 Improperly connected shell split into parts 1
 Wire on face was reversed 3
 ------------------------------------------------------------
Draw[4]> fixshape res a *?
 Fix Count
 ------------------------------------------------------------
 Improperly connected shell split into parts 1
 Wire on face was reversed 3
 ------------------------------------------------------------
 Modified shapes saved in compound: res_m
Draw[5]>

bugmaster

2011-12-16 16:14

administrator   ~0018889

Integration into trunk of occt repository

Date: 2011-12-16 15:18:18 +0400 (Fri, 16 Dec 2011)
New Revision: 9763

Modified:
   trunk/src/SHMessage/SHAPE.fr
   trunk/src/SHMessage/SHAPE.us
   trunk/src/SWDRAW/SWDRAW_ShapeFix.cxx
   trunk/src/ShapeFix/ShapeFix_Face.cxx
   trunk/src/ShapeFix/ShapeFix_Shell.cxx
   trunk/src/ShapeFix/ShapeFix_Wire.cxx

Related Changesets

occt: master 999d2599

2011-12-16 11:18:18

dbv


Committer: bugmaster Details Diff		 0022767: Extension of DRAW command fixshape Affected Issues
0022767
mod - src/ShapeFix/ShapeFix_Face.cxx Diff File
mod - src/ShapeFix/ShapeFix_Shell.cxx Diff File
mod - src/ShapeFix/ShapeFix_Wire.cxx Diff File
mod - src/SHMessage/SHAPE.fr Diff File
mod - src/SHMessage/SHAPE.us Diff File
mod - src/SWDRAW/SWDRAW_ShapeFix.cxx Diff File

Issue History

Date Modified Username Field Change
2011-10-19 10:40 abv New Issue
2011-10-19 10:40 abv Assigned To => mkv
2011-10-19 13:49 abv Assigned To mkv => ama
2011-10-19 13:49 abv Status new => assigned
2011-10-19 13:49 abv Assigned To ama => dbv
2011-11-21 17:55 dbv Note Added: 0018597
2011-11-21 17:56 dbv Note Edited: 0018597
2011-11-21 17:58 dbv Status assigned => resolved
2011-11-21 17:59 dbv Assigned To dbv => abv
2011-11-23 16:49 kgv Note Added: 0018613
2011-11-23 16:55 kgv Note Edited: 0018613
2011-11-23 16:56 kgv Note Edited: 0018613
2011-11-25 13:28 dbv Note Added: 0018621
2011-12-01 09:19 abv Note Added: 0018680
2011-12-01 09:19 abv Assigned To abv => dbv
2011-12-01 09:19 abv Status resolved => assigned
2011-12-02 16:33 dbv Note Added: 0018721
2011-12-02 16:33 dbv Assigned To dbv => abv
2011-12-02 16:33 dbv Status assigned => resolved
2011-12-02 16:44 abv Note Added: 0018722
2011-12-02 16:44 abv Assigned To abv => dbv
2011-12-02 16:44 abv Status resolved => reviewed
2011-12-12 19:41 mkv Note Added: 0018827
2011-12-12 19:41 mkv Status reviewed => assigned
2011-12-13 12:57 dbv Note Added: 0018828
2011-12-13 12:57 dbv Assigned To dbv => abv
2011-12-13 12:57 dbv Status assigned => resolved
2011-12-13 13:00 dbv Note Edited: 0018828
2011-12-13 14:07 abv Status resolved => reviewed
2011-12-13 14:08 abv Note Added: 0018829
2011-12-13 15:47 mkv Note Added: 0018830
2011-12-13 15:51 mkv Note Added: 0018831
2011-12-13 15:52 mkv Note Edited: 0018831
2011-12-13 16:07 mkv Status reviewed => tested
2011-12-14 13:38 dbv File Added: example1-notfixed.brep
2011-12-14 13:58 dbv File Added: trampafus-notfixed.7z
2011-12-14 13:58 dbv File Added: TransmissionTestModel5-notfixed.7z
2011-12-14 14:08 dbv Note Added: 0018845
2011-12-14 14:08 dbv Note Edited: 0018845
2011-12-16 16:14 bugmaster Note Added: 0018889
2011-12-16 16:14 bugmaster Status tested => verified
2011-12-16 16:14 bugmaster Resolution open => fixed
2012-03-29 17:26 bugmaster Changeset attached => occt master 999d2599