View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0022693 | Community | OCCT:Application Framework | public | 2011-08-03 15:42 | 2012-03-29 17:26 |
| Reporter | szy | Assigned To | bugmaster | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Platform | A | OS | L | ||
| Product Version | 6.5.1 | ||||
| Target Version | 6.5.3 | Fixed in Version | 6.5.3 | ||
| Summary | 0022693: Elimination Compiler warnings | ||||
| Description | Post from the Forum - http://www.opencascade.org/org/forum/thread_21230/. "Compiler warnings suggest that there may be problems with those 3 files (OCT 6.5.1): diff --git a/src/TNaming/TNaming_Localizer.cxx b/src/TNaming/TNaming_Localizer.cxx index 640628b..6864dd6 100644 --- a/src/TNaming/TNaming_Localizer.cxx +++ b/src/TNaming/TNaming_Localizer.cxx @@ -244,7 +244,7 @@ const TopTools_IndexedDataMapOfShapeListOfShape& TNaming_Localizer::Ancestors if (TS == TopAbs_EDGE) TA = TopAbs_FACE; if (TS == TopAbs_VERTEX) TA = TopAbs_EDGE; if (TS == TopAbs_FACE) TA = TopAbs_SOLID;// 25.09.2009 - szy - if (TS == TopAbs_EDGE || TS == TopAbs_VERTEX || TS == TopAbs_FACE && TA >= In.ShapeType()) { + if (TS == TopAbs_EDGE || TS == TopAbs_VERTEX || (TS == TopAbs_FACE && TA >= In.ShapeType())) { TopExp::MapShapesAndAncestors(In, TS, TA, myAncestors.First()); } else { Maybe this line is expected instead: if ((TS == TopAbs_EDGE || TS == TopAbs_VERTEX || TS == TopAbs_FACE) && TA >= In.ShapeType()) { " | ||||
| Tags | No tags attached. | ||||
| Test case number | Test case is not required | ||||
|
|
Community doesn't provide environment specification for the issue reproducing. |
|
|
Branch 0022693 is created. The order of operations is specified explicitly. Fixed. |
|
|
For review. |
|
|
The fix reviewed without remarks; please test |
|
|
Dear BugMaster, Workbench KAS:dev:mkv-22693-occt was created from SVN branch http://svn/svn/occt/branches/0022693 (and mkv-22693-products from trunk) and compiled on Linux platform. There are not regressions in mkv-22693-products regarding to KAS:dev:products-652-opt. See results in /QADisk/occttests/results/KAS/dev/mkv-22693-products_02122011/lin See reference results in /QAdisk/occttests/results/KAS/dev/products-652-opt_23092011/lin See test cases in /QAdisk/occttests/tests/ED N.B. In order to launch testing case you can make use the following instructions http://doc/doku.php?id=occt:certification |
|
|
Integration into trunk of occt repository Date: 2011-12-16 17:18:52 +0400 (Fri, 16 Dec 2011) New Revision: 9778 Modified: trunk/src/TNaming/TNaming_Localizer.cxx |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-08-03 15:42 | szy | New Issue | |
| 2011-08-03 15:42 | szy | Assigned To | => szy |
| 2011-08-03 17:20 | szy | Note Added: 0017896 | |
| 2011-08-03 17:20 | szy | Status | new => assigned |
| 2011-08-03 17:23 | szy | Note Added: 0017897 | |
| 2011-08-03 17:23 | szy | Status | assigned => resolved |
| 2011-09-21 11:42 | bugmaster | Target Version | 6.5.2 => 6.5.3 |
| 2011-12-01 12:24 | szy | Note Added: 0018686 | |
| 2011-12-01 12:24 | szy | Assigned To | szy => abv |
| 2011-12-01 12:24 | szy | Status | resolved => assigned |
| 2011-12-01 12:38 | abv | Status | assigned => resolved |
| 2011-12-01 12:39 | abv | Note Added: 0018689 | |
| 2011-12-01 12:39 | abv | Status | resolved => reviewed |
| 2011-12-01 12:40 | abv | Assigned To | abv => szy |
| 2011-12-07 14:42 |
|
Note Added: 0018768 | |
| 2011-12-07 14:42 |
|
Test case number | => Test case is not required |
| 2011-12-07 14:42 |
|
Status | reviewed => tested |
| 2011-12-07 18:12 | szy | Note Edited: 0018768 | |
| 2011-12-16 17:23 | bugmaster | Note Added: 0018895 | |
| 2011-12-16 17:23 | bugmaster | Status | tested => verified |
| 2011-12-16 17:23 | bugmaster | Resolution | open => fixed |
| 2012-03-29 17:26 | bugmaster | Changeset attached | => occt master 446b69ba |
