View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0022613Open CASCADEOCCT:WOKpublic2011-06-17 19:572012-01-27 17:22
Reporterkgv Assigned Tokgv  
PrioritynormalSeverityfeature 
Status closedResolutionfixed 
OSAll 
Target Version6.5.3Fixed in Version6.5.3 
Summary0022613: Retrieve environment variable in EDL
DescriptionCurrently environment variables doesn't availalbe within EDL scripts.
This force writing EDLs with hardcoded absolute paths making written scripts
not portable / less flexible.

This is suggested to implement this feature in some way. Possible solutions:
- parse input strings and replace substrings when special synax found (like
Unish ${MY_ENV_VAR} or NT %MY_ENV_VAR%);
- automatically fill EDL local variables list with evironment variables
(probably with special prefix like ENV_);
- add new keyword in syntax to retrieve environment variable (for example SET
VAR '=' ENV STR SEPARATOR { edl_set_var($2, edl_get_env($5)); edlstring_free
($2); edlstring_free($5);})
TagsNo tags attached.
Test case number

Activities

kgv

2012-01-23 13:26

developer   ~0019232

EDL parser now determine ${EnvVarName} syntax to automatically retrieve environment variable.
Notice that only simplest syntax is supported (not "text${EnvVar}/${anotherVar}", "$EnvVarName" or so on). However this is should be enough to cover small cases where it is really desired. Usage example:
  @set ENV_MYVAR = "${EnvVarName}"

Fix integrated to the Bug branch OCC22613 (products).

abv

2012-01-23 13:48

manager   ~0019235

My remarks:

1. Too many spaces in white spaces, which make revision difficult. Please try to keep white-space and formatting changes in non-modified code minimal

2. In EDL_Interpretor.cxx, the if statement before use of OSD_Environment seems to lack comparison in the last argument:

> if (aValLen > 3 && theValue[0] == '$' && theValue[1] == '{' && theValue[aValLen - 1])

it perhaps should be

> if (aValLen > 3 && theValue[0] == '$' && theValue[1] == '{' && theValue[aValLen - 1] == '}')

kgv

2012-01-23 14:05

developer   ~0019237

Fixed second remark.

abv

2012-01-23 14:13

manager   ~0019238

No remarks, please test

aan

2012-01-27 11:44

developer   ~0019278

Dear BugMaster,
Workbench KAS:dev:aan-OCC22613-occt was created from SVN trunk
(and aan-OCC22613-products from http://svn/svn/occt-products/branches/OCC22613) and compiled on Linux platform.

There are not regressions in aan-OCC22613-products regarding to KAS:dev:products-20120120-opt

See results in /QADisk/occttests/results/KAS/dev/ aan-OCC22613-products_26012012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120120-opt_20012012/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification

bugmaster

2012-01-27 17:22

administrator   ~0019289

Integration into trunk of occt-products repository

Date: 2012-01-27 17:08:46 +0400 (Fri, 27 Jan 2012)
New Revision: 18505

Modified:
   trunk/src/EDL/EDL_Interpretor.cxx

Issue History

Date Modified Username Field Change
2011-09-13 14:01 bugmaster Assigned To bugmaster => kgv
2011-09-13 14:01 bugmaster Status new => assigned
2012-01-23 13:26 kgv Note Added: 0019232
2012-01-23 13:26 kgv Assigned To kgv => abv
2012-01-23 13:26 kgv Status assigned => resolved
2012-01-23 13:48 abv Note Added: 0019235
2012-01-23 13:48 abv Assigned To abv => kgv
2012-01-23 13:48 abv Status resolved => assigned
2012-01-23 14:05 kgv Note Added: 0019237
2012-01-23 14:05 kgv Assigned To kgv => abv
2012-01-23 14:05 kgv Status assigned => resolved
2012-01-23 14:13 abv Note Added: 0019238
2012-01-23 14:13 abv Assigned To abv => kgv
2012-01-23 14:13 abv Status resolved => reviewed
2012-01-27 11:44 aan Note Added: 0019278
2012-01-27 11:44 aan Status reviewed => tested
2012-01-27 11:44 aan Fixed in Version EMPTY =>
2012-01-27 11:44 aan Description Updated
2012-01-27 15:55 bugmaster Target Version => 6.5.3
2012-01-27 17:22 bugmaster Note Added: 0019289
2012-01-27 17:22 bugmaster Status tested => verified
2012-01-27 17:22 bugmaster Resolution open => fixed