|Anonymous | Login||2018-12-19 13:16 MSK|
|My View | View Issues | Change Log | Roadmap|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0022545||Community||[OCCT] OCCT:Foundation Classes||public||2011-05-27 20:47||2013-04-29 15:21|
|Assigned To||Roman Lygin|
|Product Version||[OCCT] 6.5.1|
|Target Version||[OCCT] 6.6.0||Fixed in Version||[OCCT] 6.6.0|
|Summary||0022545: Improved exception handling|
|Description||RLN contribution. |
- Exception objects (Standard_Failure ancestors) are now
defined/implemented using macros (see Standard_DefineException>
in a way similar to defining handles. This enables creating user-defined
exceptions without CDL.
Note that as preprocessor does not allow to insert preprocessor
instructions (starting with #) into macro definitions, it is impossible to
define macros #<object_type>_Raise_if(). Therefore their generation is
kept within CDL extractor as previously. The user does not really need to do
this - he may rely on No_Exceptions macro. CPPExt_Template.edl must be copied to
$WOKHOME/lib for CDL extractor to take effect.
- Standard_Failure has Throw() non-virtual and ancestros does not have it
anymore (implementation was the same).
- OSD::SetSignal() now always sets signal handlers, exception handlers and
structured exception (SE) translators. This >
to deal correctly in case if user's code is compiled with /EHs or /EHa.
UseSETranslation() are removed,
as redundant. See detailed documentation in OSD_signal_WNT.cxx on
- very detailed documentation for OSD::Setsignal() in Doygen format is now
in this file.
- removed static variables that set signals only once to enable calling
::SetSignal() for other threads or even
within the same thread if the user switched handlers before
- mutexes are used to control multi-threading.
- Minimize signal handling by OSD_Signal.cxx to SIGSEGV and SIGFPE.
On Unix it currently processes
all (or almost all) signals (e.g. SIGHUP) by exiting. There is no
value add to that. It's better to be
done by user apps.
OCC should only handle those which it can survive after, if at
all it must do anything. OCC classes may
or maynot be provided for convenience but should not be set in
the OCC itself.
- OSD_signal.cxx - if possible, get rid of sigaction() and replace
with signal() and and other more
advanced staff. We just need to map signals to C++ exceptions, so
let's not make code more complex than neede>
can simplify the OSD API and remove. If possible, minimize
implementation discrepancies between OSes.
- On SGI - remove use of env variable TRAP_FPE and replace with
function handle_sigfpes() (as this is more
reliable) - see SGI doc
- minimize exposing OSD API by removing SegvHandler(), WntHandler()
and others and keep SetSignal() only.
Alternative approach is instead expose functions which map to OCC
exceptions and document them, so that
the user can reuse them in his own handlers.
- rename OSD::SetSignal() with SetHandlers() as it not only sets
signal handlers but exceptions also.
- removed message box and call to a debugger. This is an ugly way
and only pollutes the code. Moreover call
to Debugger does really work on modern Windows (debugger is still
ironically called due some failure within
OSD_signal_WNT.cxx). In reality debugger can be attached to the
process. Moreover, CSF_DEBUG_MODE was
seemingly never tested - the message box could not display for
FPE signals (because _fpreset() and
_clearfp() were not called before it). In the ultimate case this
code can be moved to some DRAW function
as an example of how to implement own signal handling.
- add additional boolean argument Reenforce into OSD::SetSignal()
that would not redefine already set user's
defined handlers. In this case, OSD_Pipeline should call
aReenforce=false) and would not reset user's handlers if they
were redefined by user in the main thread
|Tags||No tags attached.|
|Test case number||Not needed|
Patch was reviewed. Corrected version was committed to SVN branch
Branch is ready for regression tests.
Workbench KAS:dev:apn-22545-occt was created from SVN branch http://svn/svn/occt/branches/OCC22545 [^]
(and apn-22545-products from trunk) and compiled on Linux platform.
There are not regressions in apn-22545-products regarding to KAS:dev:products-20120120-opt
See results in /QADisk/occttests/results/KAS/dev/ apn-22545-products_25012012/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-20120120-opt_20012012/lin
See test cases in /QADisk/occttests/tests/ED
|The results of testing on Linux are irrelevant since the change is Windows-specific.|
Patch was rebased and pushed to CR22545 branch in git.
Please perform testing on Windows platform.
Branch CR22545 (and products from GIT master) was compiled on Linux and Windows platforms and tested.
occt: master 0ac0c8b4
Timestamp: 2012-11-15 09:17:30
Author: Roman Lygin
|0022545: Improved exception handling|
|mod - src/OSD/OSD.cdl|
|mod - src/OSD/OSD_signal_WNT.cxx|
|2011-08-02 11:23||bugmaster||Category||OCCT:FDC => OCCT:Foundation Classes|
|2011-10-21 16:38||bugmaster||Assigned To||bugmaster => abv|
|2011-10-21 16:38||bugmaster||Status||acknowledged => assigned|
|2011-10-21 16:38||bugmaster||Resolution||suspended => open|
|2011-10-21 16:38||bugmaster||Fixed in Version||EMPTY =>|
|2011-10-21 16:38||bugmaster||Description Updated||View Revisions|
|2011-11-15 12:54||abv||Status||assigned => resolved|
|2011-11-15 12:54||abv||Product Version||=> 6.5.1|
|2011-11-15 12:54||abv||Target Version||=> 6.5.3|
|2011-11-25 14:50||szy||Description Updated||View Revisions|
|2012-01-24 16:20||bugmaster||Assigned To||abv => kgv|
|2012-01-24 16:20||bugmaster||Status||resolved => reviewed|
|2012-01-26 09:41||apn||Note Added: 0019268|
|2012-01-26 09:41||apn||Test case number||=> Test case is not required|
|2012-01-26 09:41||apn||Status||reviewed => tested|
|2012-01-26 10:03||abv||Note Added: 0019269|
|2012-01-26 10:03||abv||Assigned To||kgv => abv|
|2012-01-26 10:03||abv||Status||tested => assigned|
|2012-02-09 09:03||abv||Target Version||6.5.3 => 6.5.4|
|2012-10-23 19:27||abv||Target Version||6.5.4 => 6.6.0|
|2012-10-24 14:09||kgv||Note Added: 0021922|
|2012-10-24 14:09||kgv||Status||assigned => resolved|
|2012-10-24 14:13||kgv||Assigned To||abv => bugmaster|
|2012-10-24 14:13||kgv||Status||resolved => reviewed|
|2012-11-01 11:30||apn||Note Added: 0022045|
|2012-11-01 11:30||apn||Test case number||Test case is not required => Not needed|
|2012-11-01 11:30||apn||Status||reviewed => tested|
|2012-11-16 13:03||Roman Lygin||Changeset attached||=> occt master 0ac0c8b4|
|2012-11-16 13:03||Roman Lygin||Assigned To||bugmaster => Roman Lygin|
|2012-11-16 13:03||Roman Lygin||Status||tested => verified|
|2012-11-16 13:03||Roman Lygin||Resolution||open => fixed|
|2012-12-10 17:16||Roman Lygin||Changeset attached||=> occt master 0ac0c8b4|
|2013-04-23 13:36||user533||Status||verified => closed|
|2013-04-29 15:21||user533||Fixed in Version||=> 6.6.0|
|Copyright © 2000 - 2018 MantisBT Team|