View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0033261CommunityOCCT:Data Exchangepublic2022-12-08 18:282024-02-23 14:09
Reporterdpasukhi Assigned Tovglukhik  
PrioritylowSeverityminor 
Status verifiedResolutionfixed 
Target Version7.7.3 
Summary0033261: Data Exchange, Step Import - Empty shape after reading process
DescriptionCan't read shape from attached file.
Some other application can read. NX Step analyzer can't read it and do not throw any errors.
Steps To Reproducepload ALL
ReadStep D Printer_Model_8909.stp
XShow D
TagsNo tags attached.
Test case number

Attached Files

  • Printer_Model_8909.zip (822,153 bytes)

Relationships

has duplicate 0033262 closedbugmaster Data Exchange, Step Import - Empty shape after reading process 

Activities

dpasukhi

2022-12-08 18:29

administrator   ~0112547

dpasukhi

2022-12-08 18:30

administrator   ~0112549

Printer_Model_8909.zip (822,153 bytes)

git

2023-02-07 17:27

administrator   ~0113092

Branch CR33261 has been created by DenisOrlov.

SHA-1: 8dd3fbe660e59f861dc285c3c6d29a8358ffed37


Detailed log of new commits:

Author: dorlov
Date: Tue Feb 7 14:27:10 2023 +0000

    0033261: Data Exchange, Step Import - Empty shape after reading process
    
    Added a check for ShapeRepresentationRelationship in Transfer of MappedItem method,
    in order to support link of components according to ISO 10303-203-2003,
    now it's for test purposes only.

dpasukhi

2023-02-14 18:21

administrator   ~0113137

Dear @DenisOrlov

There a lot problems with names, please do not forget to use new code style.

Recommented to hide iterator variable to the loop body. Move { to new line.
+      for (subs1.Start(); subs1.More(); subs1.Next()) {

I think you can use STANDRAT_TYPE directly w/o variable
+      Handle(Standard_Type) tSRR = STANDARD_TYPE(StepRepr_ShapeRepresentationRelationship);

Returning value is not recommented, because you have some code to transform after(below)
+      else if (Cund.NbChildren() > 1)
+      {
+        shbinder = new TransferBRep_ShapeBinder(Cund);
+        TP->Bind(mapit, shbinder);
+        return shbinder;
+      }

I think there can be a few problems with ignoring own shape. We can read only supplemental geometry and forgor about own shape.
+    if (shbinder.IsNull())
+      binder = TransferEntity( maprep, TP, isBound, Standard_False, PS.Next() );

I think that we need to move this code to the TransferEntity. or special new function. But it looks very strange. (and repeated)
I think we need to analyze a stack of calls and handle this case before.
-  if (binder.IsNull())    binder = TransferEntity(maprep,TP,isBound, Standard_False, theProgress);
-  shbinder = Handle(TransferBRep_ShapeBinder)::DownCast(binder);
+  if (binder.IsNull())
+  {
+    // translate possible shapes related by SRRs, which corresponds to
+    // way of writing hybrid models in AP203 since 1998, and AP209
+    // Note that both AP203 and AP209 allow main representation to be non-empty
+    Standard_Integer readSRR = Interface_Static::IVal("read.step.shape.relationship");
+    Standard_Integer readConstructiveGeomRR = Interface_Static::IVal("read.step.constructivegeom.relationship");
+    Message_ProgressScope PS(theProgress, "Part", 2);

git

2023-03-16 17:01

administrator   ~0113286

Branch CR33261 has been updated forcibly by DenisOrlov.

SHA-1: 879d668f818c0de782dd546f68b6d4a8602d6400

git

2023-03-16 17:10

administrator   ~0113287

Branch CR33261 has been updated forcibly by DenisOrlov.

SHA-1: d70c9ed6367d755201e64906d999bfa1d30a26d6

git

2023-03-21 21:14

administrator   ~0113308

Branch CR33261 has been updated forcibly by DenisOrlov.

SHA-1: 786ace8b79f41c53a47543eb5da3625fad510331

git

2023-03-22 14:37

administrator   ~0113313

Branch CR33261 has been updated forcibly by DenisOrlov.

SHA-1: 01a2c4ebc7a01d10c267eb2afaddc2fed9ac6248

git

2023-08-01 11:02

administrator   ~0113817

Branch CR33261_1 has been created by ichesnokova.

SHA-1: 964c47951a6b469375830e2638223d8eb05caefe


Detailed log of new commits:

Author: dorlov
Date: Tue Feb 7 14:27:10 2023 +0000

    0033261: Data Exchange, Step Import - Empty shape after reading process
    
    Added a transfer for ShapeRepresentationRelationship in Transfer of MappedItem method,
    in order to support link of components according to ISO 10303-203-2003.

Author: dorlov
Date: Fri Feb 10 15:15:40 2023 +0000

    0033226: Data Exchange - Infinite loop in HLRBRep_InternalAlgo::Update() generating 2D view of right hand side from STEP file
    
    Infinite loop is removed from IntWalk_IWalking::ComputeOpenLine method test case was created

git

2023-08-02 11:41

administrator   ~0113846

Branch CR33261_1 has been updated forcibly by ichesnokova.

SHA-1: 86fd245280afada1b5d2a8e3822d7556ce3ef855

ichesnokova

2023-08-02 15:21

developer   ~0113858

Dear @dpasukhi,
please review branch CR33261_1.
Tests: http://jenkins-test-10.nnov.opencascade.com/view/CR33261-master-ichesnok/view/COMPARE/

dpasukhi

2023-08-02 15:26

administrator   ~0113859

Please rebase to master
remove 33226 commit.

git

2023-08-02 16:00

administrator   ~0113860

Branch CR33261_1 has been updated forcibly by ichesnokova.

SHA-1: 4d06347d245916dfaf9d5f4bbf2affe8b753d4c9

ichesnokova

2023-08-07 10:06

developer   ~0113888

Tests: http://jenkins-test-10.nnov.opencascade.com/view/CR33261_1-master-ichesnok/view/COMPARE/

ika

2023-08-25 17:35

developer   ~0114023

Dear ichesnokova,

STEPControl_ActorRead.hxx

1) Please use theName for the method parameters
2) I am not sure, that you need to send Handle(Transfer_Binder) as a parameter, the caller methods do nothing with it and the new method doesn't use its input
3) You do not need to send BRep_Builder as a parameter, it doesn't have any useful data inside, just create a new one in the new method
4) TopoDS_Shape& aResult, I think it will be better to return this shape instead of void because you don't use its input value in the new method body.
5) Standard_Boolean theUseTrsf should be const

STEPControl_ActorRead.cxx

6) Why do you use different styles of type-checking in similar cases?
if (anItem->DynamicType() == STANDARD_TYPE(StepRepr_ShapeRepresentationRelationship))
vs
else if (... anItem->IsKind(STANDARD_TYPE(StepRepr_ConstructiveGeometryRepresentationRelationship)))

7) Handle(StepRepr_ConstructiveGeometryRepresentationRelationship) aCSRR
Not a clear name, Is it a misprint and do you mean aCGRR?

8) if (!theBinder.IsNull()) {...}
are similar for both cases, they can be pulled out of their parent ifs.

9) Standard_Integer aNbrep = (theRep == aSRR->Rep1() ? 2 : 1);
please use camel notation -> aNbRep

git

2023-09-01 14:59

administrator   ~0114055

Branch CR33261_2 has been created by ichesnokova.

SHA-1: d933e4d538af74a9fdd4d0c83c349b235460d7f7


Detailed log of new commits:

Author: ichesnok
Date: Wed Aug 2 13:58:52 2023 +0100

    0033261: Data Exchange, Step Import - Empty shape after reading process
    
    Added a transfer for ShapeRepresentationRelationship in Transfer of MappedItem method,
    in order to support link of components according to ISO 10303-203-2003.

git

2023-09-04 10:03

administrator   ~0114066

Branch CR33261_2 has been updated forcibly by ichesnokova.

SHA-1: 373e289b29af525839d3c555e2e100465747ebf1

git

2023-09-07 14:45

administrator   ~0114089

Branch CR33261_2 has been updated forcibly by ichesnokova.

SHA-1: a8b1fc2e884df7e736d3b3a20931ccbd0702da04

ichesnokova

2023-09-07 18:35

developer   ~0114091

Dear ika,
review branch CR33261_2 please
Tests: http://jenkins-test-10.nnov.opencascade.com/view/CR33261_1-master-ichesnok/view/COMPARE/

ika

2023-09-08 14:33

developer   ~0114102

Dear ichesnokova,

STEPControl_ActorRead.hxx
+class BRep_Builder;
After removing it from the parameters you do not need to define the class here.

You don't need to retest after such a change, just update the branch.

git

2023-09-08 14:47

administrator   ~0114105

Branch CR33261_2 has been updated forcibly by ichesnokova.

SHA-1: aa1285a477830aadc3f7318db2fa1b44e873aa2f

ichesnokova

2023-09-08 14:48

developer   ~0114106

Remark was fixed

ika

2023-09-08 16:08

developer   ~0114107

No more remarks.

Dear bugmaster,

please integrate:
OCCT CR33261_2

dpasukhi

2023-09-09 09:45

administrator   ~0114115

Dear @ichesnokova
Please create a new fast issue with fixing one remarks -
unused variable "Standard_Integer aShapesNum = 0;"
You newer use value from it. Always updates.

dpasukhi

2023-09-09 09:47

administrator   ~0114116

But it looks like that bugmaster forgot to include this commit into weekly branch. So, in this case you need to just update existed one on the beginning of the next week.

dpasukhi

2023-09-09 09:50

administrator   ~0114117

@bugmaster
Why this ticket is not a part of new weekly branch?

vglukhik

2023-09-11 04:00

administrator   ~0114119

@dpasikhi because it has conflict with current other included commits.

git

2023-09-11 13:22

administrator   ~0114126

Branch CR33261_3 has been created by ichesnokova.

SHA-1: 29433b6e35bbf5acc3f4a4c3f82157e923c0aa53


Detailed log of new commits:

Author: ichesnok
Date: Wed Aug 2 13:58:52 2023 +0100

    0033261: Data Exchange, Step Import - Empty shape after reading process
    
    Added a transfer for ShapeRepresentationRelationship in Transfer of MappedItem method,
    in order to support link of components according to ISO 10303-203-2003.

ichesnokova

2023-09-11 18:35

developer   ~0114135

Dear bugmaster,
please integrate:
OCCT: CR33261_3

vglukhik

2023-09-21 16:49

administrator   ~0114231

http://occt-tests/CR0-WEEK-38-OCCT/Ubuntu2004-64/summary.html

need to fix step test failures

git

2024-01-22 11:58

administrator   ~0114947

Branch CR33261_3 has been updated forcibly by ichesnokova.

SHA-1: a49a7b7204ad81205a43cc48f59f1f6f856ad0fe

git

2024-01-25 17:50

administrator   ~0114977

Branch CR33261_3 has been updated forcibly by ichesnokova.

SHA-1: 3c6d46b31093261443e2362500c9f3878679957c

git

2024-01-26 11:28

administrator   ~0114985

Branch CR33261_3 has been updated forcibly by ichesnokova.

SHA-1: de44e6600df6282982661a170679e760e54a2bfa

ichesnokova

2024-01-31 11:40

developer   ~0115015

Dear ika,
please review branch CR33261_3.
Tests: http://jenkins-test-10.nnov.opencascade.com/view/CR33261_3-master-ichesnok/view/COMPARE/

git

2024-02-02 18:49

administrator   ~0115031

Branch CR33261_3 has been updated forcibly by ichesnokova.

SHA-1: 0863c9136eac049c39025e81561523f77d54f8f4

ichesnokova

2024-02-02 18:55

developer   ~0115032

I checked test cases which failed.
The changes in the commit shouldn't affect them.

ika

2024-02-02 18:57

developer   ~0115033

No remarks.
Dear bugmaster, please integrate
OCCT CRCR33261_3.

vglukhik

2024-02-14 15:16

administrator   ~0115081

Combination -
OCCT branch : IR-2024-02-02
master SHA - 80705eaf3181f779d6f59bbe0959e1acafb8fc94
d2ef868da4165400c82322bd7f11b652decce47a
Products branch : IR-2024-02-02 SHA - 1138f036bbb2108d18e2649701fcfa8a430bf4e6
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Ubuntu2004-64:
OCCT
Total CPU difference: 17746.459999999875 / 18049.510000000217 [-1.68%]
Products
Total CPU difference: 11492.199999999928 / 11720.99999999989 [-1.95%]
Windows-64-VC142:
OCCT
Total CPU difference: 20148.875 / 21735.421875 [-7.30%]
Products
Total CPU difference: 12625.53125 / 13033.78125 [-3.13%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention

git

2024-02-19 01:28

administrator   ~0115128

Branch CR33261 has been deleted by vglukhik.

SHA-1: 01a2c4ebc7a01d10c267eb2afaddc2fed9ac6248

git

2024-02-19 01:28

administrator   ~0115129

Branch CR33261_1 has been deleted by vglukhik.

SHA-1: 4d06347d245916dfaf9d5f4bbf2affe8b753d4c9

git

2024-02-19 01:28

administrator   ~0115130

Branch CR33261_2 has been deleted by vglukhik.

SHA-1: aa1285a477830aadc3f7318db2fa1b44e873aa2f

git

2024-02-19 01:28

administrator   ~0115131

Branch CR33261_3 has been deleted by vglukhik.

SHA-1: 0863c9136eac049c39025e81561523f77d54f8f4

Related Changesets

occt: master 20955d88

2023-08-02 12:58:52

ichesnok


Committer: vglukhik Details Diff		 0033261: Data Exchange, Step Import - Empty shape after reading process

Added a transfer for ShapeRepresentationRelationship in Transfer of MappedItem method,
in order to support link of components according to ISO 10303-203-2003.		 Affected Issues
0033261
mod - src/STEPControl/STEPControl_ActorRead.cxx Diff File
mod - src/STEPControl/STEPControl_ActorRead.hxx Diff File
add - tests/bugs/step/bug33261 Diff File

Issue History

Date Modified Username Field Change
2022-12-08 18:28 dpasukhi New Issue
2022-12-08 18:28 dpasukhi Assigned To => gka
2022-12-08 18:29 dpasukhi Note Added: 0112547
2022-12-08 18:30 dpasukhi Note Added: 0112549
2022-12-08 18:30 dpasukhi File Added: Printer_Model_8909.zip
2022-12-08 18:30 dpasukhi Priority normal => low
2022-12-08 18:31 dpasukhi Relationship added duplicate of 0033262
2023-01-17 01:09 vglukhik Relationship replaced has duplicate 0033262
2023-01-25 14:18 ika Assigned To gka => DenisOrlov
2023-02-07 17:27 git Note Added: 0113092
2023-02-14 18:21 dpasukhi Note Added: 0113137
2023-03-16 17:01 git Note Added: 0113286
2023-03-16 17:10 git Note Added: 0113287
2023-03-21 21:14 git Note Added: 0113308
2023-03-22 14:37 git Note Added: 0113313
2023-08-01 11:02 git Note Added: 0113817
2023-08-01 15:06 dpasukhi Target Version 7.8.0 => Unscheduled
2023-08-02 11:41 git Note Added: 0113846
2023-08-02 13:41 dpasukhi Assigned To DenisOrlov => ichesnokova
2023-08-02 15:21 ichesnokova Note Added: 0113858
2023-08-02 15:22 ichesnokova Assigned To ichesnokova => dpasukhi
2023-08-02 15:22 ichesnokova Status new => resolved
2023-08-02 15:26 dpasukhi Note Added: 0113859
2023-08-02 16:00 git Note Added: 0113860
2023-08-02 17:58 dpasukhi Target Version Unscheduled => 7.7.3
2023-08-07 10:06 ichesnokova Note Added: 0113888
2023-08-25 17:35 ika Note Added: 0114023
2023-08-25 17:36 ika Assigned To dpasukhi => ichesnokova
2023-08-25 17:36 ika Status resolved => assigned
2023-09-01 14:59 git Note Added: 0114055
2023-09-04 10:03 git Note Added: 0114066
2023-09-07 14:45 git Note Added: 0114089
2023-09-07 18:35 ichesnokova Assigned To ichesnokova => ika
2023-09-07 18:35 ichesnokova Status assigned => resolved
2023-09-07 18:35 ichesnokova Note Added: 0114091
2023-09-08 14:33 ika Assigned To ika => ichesnokova
2023-09-08 14:33 ika Status resolved => assigned
2023-09-08 14:33 ika Note Added: 0114102
2023-09-08 14:47 git Note Added: 0114105
2023-09-08 14:48 ichesnokova Assigned To ichesnokova => ika
2023-09-08 14:48 ichesnokova Status assigned => resolved
2023-09-08 14:48 ichesnokova Note Added: 0114106
2023-09-08 16:08 ika Assigned To ika => bugmaster
2023-09-08 16:08 ika Status resolved => reviewed
2023-09-08 16:08 ika Note Added: 0114107
2023-09-09 09:45 dpasukhi Note Added: 0114115
2023-09-09 09:47 dpasukhi Note Added: 0114116
2023-09-09 09:50 dpasukhi Note Added: 0114117
2023-09-11 04:00 vglukhik Note Added: 0114119
2023-09-11 13:22 git Note Added: 0114126
2023-09-11 18:35 ichesnokova Note Added: 0114135
2023-09-21 16:49 vglukhik Assigned To bugmaster => dpasukhi
2023-09-21 16:49 vglukhik Status reviewed => assigned
2023-09-21 16:49 vglukhik Note Added: 0114231
2024-01-22 11:58 git Note Added: 0114947
2024-01-25 17:50 git Note Added: 0114977
2024-01-25 18:29 dpasukhi Assigned To dpasukhi => ichesnokova
2024-01-26 11:28 git Note Added: 0114985
2024-01-31 11:40 ichesnokova Assigned To ichesnokova => ika
2024-01-31 11:40 ichesnokova Status assigned => resolved
2024-01-31 11:40 ichesnokova Note Added: 0115015
2024-02-02 18:49 git Note Added: 0115031
2024-02-02 18:55 ichesnokova Note Added: 0115032
2024-02-02 18:57 ika Assigned To ika => bugmaster
2024-02-02 18:57 ika Status resolved => reviewed
2024-02-02 18:57 ika Note Added: 0115033
2024-02-14 15:14 vglukhik Changeset attached => occt master 20955d88
2024-02-14 15:14 vglukhik Assigned To bugmaster => vglukhik
2024-02-14 15:14 vglukhik Status reviewed => verified
2024-02-14 15:14 vglukhik Resolution open => fixed
2024-02-14 15:16 vglukhik Note Added: 0115081
2024-02-19 01:28 git Note Added: 0115128
2024-02-19 01:28 git Note Added: 0115129
2024-02-19 01:28 git Note Added: 0115130
2024-02-19 01:28 git Note Added: 0115131