MantisBT - Open CASCADE
View Issue Details
0032479Open CASCADE[OCCT] OCCT:Application Frameworkpublic2021-07-14 11:212021-07-17 10:05
kgv 
bugmaster 
normalminor 
verifiedfixed 
[OCCT] 7.6.0* 
[OCCT] 7.6.0* 
Not required
0032479: Application Framework - unnecessary API break within TDocStd_Application::Open()
TDocStd_Application::Open() definition has been changed to introduce new theFilter parameter:
  PCDM_ReaderStatus Open (Standard_IStream& theIStream,
      Handle(TDocStd_Document)& theDoc,
      const Handle(PCDM_ReaderFilter)& theFilter = Handle(PCDM_ReaderFilter)(),
      const Message_ProgressRange& theRange = Message_ProgressRange());


This API break doesn't look justified as most users will not use theFilter argument anyway.
It could be simply resolved by defining an additional method with fewer number of parameters or by moving theFilter to the end of argument list.
No tags attached.
child of 0031918verified bugmaster Application Framework - New binary format for fast reading part of OCAF document 
Issue History
2021-07-14 11:21kgvNew Issue
2021-07-14 11:21kgvAssigned To => mpv
2021-07-14 11:21kgvRelationship addedchild of 0031918
2021-07-14 11:21kgvDescription Updatedbug_revision_view_page.php?rev_id=25492#r25492
2021-07-14 11:31gitNote Added: 0102517
2021-07-14 12:29kgvNote Added: 0102519
2021-07-14 12:29kgvStatusnew => resolved
2021-07-14 13:39mpvNote Added: 0102520
2021-07-14 13:39mpvAssigned Tompv => bugmaster
2021-07-14 13:39mpvStatusresolved => reviewed
2021-07-17 09:46bugmasterNote Added: 0102598
2021-07-17 09:46bugmasterStatusreviewed => tested
2021-07-17 09:49bugmasterTest case number => Not required
2021-07-17 09:58bugmasterChangeset attached => occt master acab849d
2021-07-17 09:58bugmasterStatustested => verified
2021-07-17 09:58bugmasterResolutionopen => fixed
2021-07-17 10:05gitNote Added: 0102608

Notes
(0102517)
git   
2021-07-14 11:31   
Branch CR32479 has been created by kgv.

SHA-1: dc84ac8e7feebce27df93ee14acf719bdbbb13e7


Detailed log of new commits:

Author: kgv
Date: Wed Jul 14 11:31:16 2021 +0300

    0032479: Application Framework - unnecessary API break within TDocStd_Application::Open()
    
    Added aliases to Open() without theFilter argument for compatibility with old API.
(0102519)
kgv   
2021-07-14 12:29   
Patch is ready for review
- OCCT: branch CR32479.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32479-master-KGV/view/ALL/ [^]
(0102520)
mpv   
2021-07-14 13:39   
Reviewed
OCCT: branch CR32479
(0102598)
bugmaster   
2021-07-17 09:46   
Combination -
OCCT branch : IR-2021-07-16
master SHA - acab849d30f2acb733586120dcd2b43f2ae59769
a87b7ddc8cb44606b91e3f37113847c3f5f50fdc
Products branch : IR-2021-07-16 SHA - 0b2936175e8e41158165aa983c4bd52035d88570
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17229.290000000303 / 17544.51000000034 [-1.80%]
Products
Total CPU difference: 11476.020000000117 / 11490.74000000011 [-0.13%]
Windows-64-VC14:
OCCT
Total CPU difference: 19019.8125 / 19318.21875 [-1.54%]
Products
Total CPU difference: 12732.515625 / 12831.40625 [-0.77%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0102608)
git   
2021-07-17 10:05   
Branch CR32479 has been deleted by mnt.

SHA-1: dc84ac8e7feebce27df93ee14acf719bdbbb13e7