MantisBT - Open CASCADE
View Issue Details
0032441Open CASCADE[OCCT] OCCT:DRAWpublic2021-06-15 17:052021-07-03 14:45
kgv 
bugmaster 
normalminor 
verifiedfixed 
[OCCT] 7.2.0 
[OCCT] 7.6.0* 
Not required
0032441: Draw Harness - command readstl doesn't print error message on failure
Passing an invalid file path to readstl command doesn't produce any error message.
pload MODELING XDE VISUALIZATION
readstl s {c:/work/downloads/AAA.stl}
# KO - no error message
trinfo s
No tags attached.
child of 0028840closed bugmaster Data Exchange - rewrite the STL Reader/Writer 
Issue History
2021-06-15 17:05kgvNew Issue
2021-06-15 17:05kgvAssigned To => mkrylova
2021-06-15 17:54kgvStatusnew => assigned
2021-06-23 18:28mkrylovaNote Added: 0102014
2021-06-28 17:17gitNote Added: 0102121
2021-06-28 18:33mkrylovaNote Added: 0102131
2021-06-29 11:01mkrylovaNote Added: 0102144
2021-06-29 11:01mkrylovaNote Added: 0102145
2021-06-29 11:02mkrylovaAssigned Tomkrylova => kgv
2021-06-29 11:02mkrylovaStatusassigned => resolved
2021-06-29 11:35kgvNote Added: 0102147
2021-06-29 11:35kgvAssigned Tokgv => mkrylova
2021-06-29 11:35kgvStatusresolved => assigned
2021-06-29 14:43gitNote Added: 0102158
2021-06-29 14:48gitNote Added: 0102159
2021-06-29 17:58mkrylovaNote Added: 0102166
2021-06-30 12:37mkrylovaNote Added: 0102181
2021-06-30 12:37mkrylovaAssigned Tomkrylova => kgv
2021-06-30 12:37mkrylovaStatusassigned => resolved
2021-06-30 12:57kgvAssigned Tokgv => bugmaster
2021-06-30 12:57kgvStatusresolved => reviewed
2021-06-30 13:28kgvRelationship addedchild of 0028840
2021-06-30 13:28kgvProduct Version7.5.0 => 7.2.0
2021-07-03 11:08bugmasterNote Added: 0102242
2021-07-03 11:08bugmasterStatusreviewed => tested
2021-07-03 11:10bugmasterTest case number => Not required
2021-07-03 11:14bugmasterChangeset attached => occt master 9749af25
2021-07-03 11:14bugmasterStatustested => verified
2021-07-03 11:14bugmasterResolutionopen => fixed
2021-07-03 14:45gitNote Added: 0102258
2021-07-03 14:45gitNote Added: 0102259

Notes
(0102014)
mkrylova   
2021-06-23 18:28   
Analysis, Solution Implementation
(0102121)
git   
2021-06-28 17:17   
Branch CR32441 has been created by mkrylova.

SHA-1: 63467b7d3d36c913410fd7ef63d8ae1606ff4cac


Detailed log of new commits:

Author: mkrylova
Date: Wed Jun 23 17:08:56 2021 +0300

    0032441: Draw Harness - command readstl doesn't print error message on failure
    
    - added producing error message when passing an invalid file path
(0102131)
mkrylova   
2021-06-28 18:33   
Solution Implementation, Testing
(0102144)
mkrylova   
2021-06-29 11:01   
http://jenkins-test-occt.nnov.opencascade.com/view/CR32441-master-MKRYLOVA/view/ALL/ [^]
(0102145)
mkrylova   
2021-06-29 11:01   
Patch is ready to review:
- OCCT: CR32441
(0102147)
kgv   
2021-06-29 11:35   
Please generate message within RWStl_Reader::Read() instead of Draw command.

+    Message::SendFail() << "Error: document with name " << aFilePath << 
" does not exist";

The message is confusing.
Something like this would be more describable:
> Message::SendFail (TCollection_AsciiString ("Error: file '") + theFile + "' is not found");
(0102158)
git   
2021-06-29 14:43   
Branch CR32441 has been updated by mkrylova.

SHA-1: d51a621d60845c8f07368f303b5ba7fd528741bf


Detailed log of new commits:

Author: mkrylova
Date: Tue Jun 29 14:43:36 2021 +0300

    # kgv remarks

(0102159)
git   
2021-06-29 14:48   
Branch CR32441_1 has been created by mkrylova.

SHA-1: aa9fcbd5059b13b2b691e6baf8305e33cb092240


Detailed log of new commits:

Author: mkrylova
Date: Wed Jun 23 17:08:56 2021 +0300

    0032441: Draw Harness - command readstl doesn't print error message on failure
    
    - added producing error message when passing an invalid file path
(0102166)
mkrylova   
2021-06-29 17:58   
Solution Implementation, Testing
(0102181)
mkrylova   
2021-06-30 12:37   
http://jenkins-test-occt.nnov.opencascade.com/view/CR32441_1-master-MKRYLOVA/view/ALL/ [^]
(0102242)
bugmaster   
2021-07-03 11:08   
Combination -
OCCT branch : IR-2021-07-02
master SHA - 1f3c5058f27ddcbc23af3b05820e4433bb1009db
a87b7ddc8cb44606b91e3f37113847c3f5f50fdc
Products branch : IR-2021-07-02 SHA - a0de44eb21bec792a53984d50cb770f6679dbbd8
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17426.490000000336 / 17457.450000000455 [-0.18%]
Products
Total CPU difference: 11521.170000000124 / 11511.540000000101 [+0.08%]
Windows-64-VC14:
OCCT
Total CPU difference: 19263.921875 / 19236.96875 [+0.14%]
Products
Total CPU difference: 12854.34375 / 12832.328125 [+0.17%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0102258)
git   
2021-07-03 14:45   
Branch CR32441 has been deleted by mnt.

SHA-1: d51a621d60845c8f07368f303b5ba7fd528741bf
(0102259)
git   
2021-07-03 14:45   
Branch CR32441_1 has been deleted by mnt.

SHA-1: aa9fcbd5059b13b2b691e6baf8305e33cb092240