MantisBT - Open CASCADE
View Issue Details
0032337Open CASCADE[OCCT] OCCT:Visualizationpublic2021-04-28 09:502021-06-04 10:58
kgv 
bugmaster 
normalintegration request 
verifiedfixed 
 
[OCCT] 7.6.0* 
Not required
0032337: Visualization - rename Overlaps() method in selection to more self-describable names
Selection defines numerous overloaded methods called Overlaps() for point, AABB, triangle, segment.
Although it is possible deducing the method purpose from the list of its arguments, this is not straight-forward and might be misleading in some cases.

It is proposed renaming these methods to have primitive type in the name.
Overlaps() might be preserved for compatibility redirecting to new ones.
Not required
No tags attached.
related to 0032182assigned mkrylova Visualization - add Select3D_SensitiveSphere 
related to 0032338verified bugmaster Visualization - provide straightforward interface for ray-picking 
parent of 0032419verified bugmaster Coding Rules - revert Overlaps() methods to SelectBasics_SelectingVolumeManager as deprecated aliases 
Issue History
2021-04-28 09:50kgvNew Issue
2021-04-28 09:50kgvAssigned To => mkrylova
2021-04-28 09:50kgvRelationship addedrelated to 0032182
2021-05-12 17:49gitNote Added: 0100918
2021-05-12 17:50mkrylovaAssigned Tomkrylova => kgv
2021-05-12 17:50mkrylovaStatusnew => resolved
2021-05-12 17:50mkrylovaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25179#r25179
2021-05-12 18:20mkrylovaNote Added: 0100920
2021-05-12 18:30kgvNote Added: 0100922
2021-05-12 18:31kgvAssigned Tokgv => mkrylova
2021-05-12 18:31kgvStatusresolved => assigned
2021-05-12 18:48kgvRelationship addedrelated to 0032338
2021-05-13 12:44gitNote Added: 0100942
2021-05-13 12:47gitNote Added: 0100943
2021-05-13 12:47mkrylovaAssigned Tomkrylova => kgv
2021-05-13 12:47mkrylovaStatusassigned => resolved
2021-05-13 20:03mkrylovaNote Added: 0100953
2021-05-20 12:04kgvNote Added: 0101200
2021-05-20 12:04kgvAssigned Tokgv => mkrylova
2021-05-20 12:04kgvStatusresolved => assigned
2021-05-20 14:50gitNote Added: 0101209
2021-05-20 14:52gitNote Added: 0101210
2021-05-21 11:30mkrylovaNote Added: 0101227
2021-05-24 11:45gitNote Added: 0101316
2021-05-24 11:46gitNote Added: 0101317
2021-05-24 12:06mkrylovaNote Edited: 0101227bug_revision_view_page.php?bugnote_id=101227#r25268
2021-05-24 12:44gitNote Added: 0101324
2021-05-24 12:45gitNote Added: 0101325
2021-05-24 18:44mkrylovaNote Added: 0101337
2021-05-25 18:33mkrylovaNote Added: 0101361
2021-05-25 18:34mkrylovaAssigned Tomkrylova => kgv
2021-05-25 18:34mkrylovaStatusassigned => resolved
2021-05-25 23:23kgvNote Added: 0101374
2021-05-25 23:23kgvAssigned Tokgv => bugmaster
2021-05-25 23:23kgvStatusresolved => reviewed
2021-05-29 12:02bugmasterNote Added: 0101469
2021-05-29 12:02bugmasterStatusreviewed => tested
2021-05-29 12:04bugmasterTest case number => Not required
2021-05-29 12:12bugmasterChangeset attached => occt master 03c9cc86
2021-05-29 12:12bugmasterStatustested => verified
2021-05-29 12:12bugmasterResolutionopen => fixed
2021-05-29 13:12gitNote Added: 0101493
2021-05-29 13:12gitNote Added: 0101494
2021-05-29 13:12gitNote Added: 0101495
2021-05-29 13:12gitNote Added: 0101496
2021-05-29 13:12gitNote Added: 0101497
2021-06-04 10:58kgvRelationship addedparent of 0032419

Notes
(0100918)
git   
2021-05-12 17:49   
Branch CR32337 has been created by mkrylova.

SHA-1: 3dfc6de5cda3a60c079812fb435a2f7c322b044e


Detailed log of new commits:

Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300

    0032337: Visualization - rename Overlaps() method in selection to more self-describable names
    
    - renamed Overlaps and hasOverlap overloaded methods to self-describable names
(0100920)
mkrylova   
2021-05-12 18:20   
Solution Implementation, Testing
(0100922)
kgv   
2021-05-12 18:30   
Please also handle
> Overlaps() might be preserved for compatibility redirecting to new ones.
Overlaps() methods should be preserved at high-level API (e.g. SelectMgr_SelectingVolumeManager class) as non-virtual deprecated methods redirected to new methods.

Please also check compilation of samples, OCC Products and start Jenkins job.
(0100942)
git   
2021-05-13 12:44   
Branch CR32337 has been updated by mkrylova.

SHA-1: 1ce11103fe71c08c1be588d4c2c8a5bb9ebe6b8e


Detailed log of new commits:

Author: mkrylova
Date: Thu May 13 12:46:29 2021 +0300

    # kgv remarks:
    - restored Overlaps() methods as non-virtual and deprecated

(0100943)
git   
2021-05-13 12:47   
Branch CR32337_1 has been created by mkrylova.

SHA-1: 38a2e8afbe4065a0d9a1e4dd03681660307ce70a


Detailed log of new commits:

Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300

    0032337: Visualization - rename Overlaps() method in selection to more self-describable names
    
    - renamed Overlaps and hasOverlap overloaded methods to self-describable names
(0100953)
mkrylova   
2021-05-13 20:03   
Solution implementation
(0101200)
kgv   
2021-05-20 12:04   
Please rebase patch on top of 0032365.
(0101209)
git   
2021-05-20 14:50   
Branch CR32337_1 has been updated forcibly by mkrylova.

SHA-1: b5d5c0fe93add95d3e453264fcf390547edbf321
(0101210)
git   
2021-05-20 14:52   
Branch CR32337_2 has been created by mkrylova.

SHA-1: 307eac1b4d024c24d7828192848c7bf6d1e6ba73


Detailed log of new commits:

Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300

    0032337: Visualization - rename Overlaps() method in selection to more self-describable names
    
    - renamed Overlaps and hasOverlap overloaded methods to self-describable names
(0101227)
mkrylova   
2021-05-21 11:30   
(edited on: 2021-05-24 12:06)
Solution implementation

(0101316)
git   
2021-05-24 11:45   
Branch CR32337_2 has been updated forcibly by mkrylova.

SHA-1: bcf63f44a35e233b27440530d8b0d8cc2fb6b9f7
(0101317)
git   
2021-05-24 11:46   
Branch CR32337_3 has been created by mkrylova.

SHA-1: e28b4bf90a34089ca1b89fa202172898ad123060


Detailed log of new commits:

Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300

    0032337: Visualization - rename Overlaps() method in selection to more self-describable names
    
    - renamed Overlaps and hasOverlap overloaded methods to self-describable names
(0101324)
git   
2021-05-24 12:44   
Branch CR32337_3 has been updated by mkrylova.

SHA-1: 7089b47a7eae0bf5ded0193c330237aa420ee770


Detailed log of new commits:

Author: mkrylova
Date: Mon May 24 12:36:41 2021 +0300

    # kgv remarks
    - moved deprecated methods to the end of file

(0101325)
git   
2021-05-24 12:45   
Branch CR32337_4 has been created by mkrylova.

SHA-1: 0d13c23e07ed459a72cd6b710aa5cd9d9fb89d54


Detailed log of new commits:

Author: mkrylova
Date: Wed May 12 16:39:17 2021 +0300

    0032337: Visualization - rename Overlaps() method in selection to more self-describable names
    
    - renamed Overlaps and hasOverlap overloaded methods to self-describable names
(0101337)
mkrylova   
2021-05-24 18:44   
Solution implementation, Testing
(0101361)
mkrylova   
2021-05-25 18:33   
http://jenkins-test-occt/view/CR32337_4-CR32337_2-MKRYLOVA/view/ALL/ [^]
(0101374)
kgv   
2021-05-25 23:23   
Please raise the patch
- OCCT: branch CR32337_4;
- OCC Products: branch CR32337_2.
(0101469)
bugmaster   
2021-05-29 12:02   
Combination -
OCCT branch : IR-2021-05-28
master SHA - 2315a044240803013da63dd2f5209c739ab03727
a87b7ddc8cb44606b91e3f37113847c3f5f50fdc
Products branch : IR-2021-05-28 SHA - 2131ac830b9e3c707d427f2aac9c50dcfa5c74db
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17574.5700000004 / 17867.41000000037 [-1.64%]
Products
Total CPU difference: 11533.700000000124 / 11535.680000000108 [-0.02%]
Windows-64-VC14:
OCCT
Total CPU difference: 19393.5625 / 19367.75 [+0.13%]
Products
Total CPU difference: 12891.8125 / 12920.9375 [-0.23%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0101493)
git   
2021-05-29 13:12   
Branch CR32337 has been deleted by mnt.

SHA-1: 1ce11103fe71c08c1be588d4c2c8a5bb9ebe6b8e
(0101494)
git   
2021-05-29 13:12   
Branch CR32337_1 has been deleted by mnt.

SHA-1: b5d5c0fe93add95d3e453264fcf390547edbf321
(0101495)
git   
2021-05-29 13:12   
Branch CR32337_2 has been deleted by mnt.

SHA-1: bcf63f44a35e233b27440530d8b0d8cc2fb6b9f7
(0101496)
git   
2021-05-29 13:12   
Branch CR32337_3 has been deleted by mnt.

SHA-1: 7089b47a7eae0bf5ded0193c330237aa420ee770
(0101497)
git   
2021-05-29 13:12   
Branch CR32337_4 has been deleted by mnt.

SHA-1: 0d13c23e07ed459a72cd6b710aa5cd9d9fb89d54