MantisBT - Open CASCADE
View Issue Details
0032334Open CASCADE[OCCT] OCCT:Visualizationpublic2021-04-27 12:302021-05-01 13:32
kgv 
bugmaster 
normalminor 
verifiedfixed 
[OCCT] 7.5.0 
[OCCT] 7.6.0* 
Not required
0032334: Visualization - SelectMgr_RectangularFrustum::Overlaps() does not set triangle normal in some cases
SelectMgr_RectangularFrustum::Overlaps() sets triangle normal to SelectBasics_PickResult only in case of internal intersection.

However, there is no reason for such selective output - computed triangle normal should be set to picking result in other cases as well.
N/A
No tags attached.
child of 0031548closed bugmaster Visualization, SelectBasics_PickResult - include surface normal into picking details 
Issue History
2021-04-27 12:30kgvNew Issue
2021-04-27 12:30kgvAssigned To => kgv
2021-04-27 12:31gitNote Added: 0100612
2021-04-27 13:57kgvNote Added: 0100614
2021-04-27 13:57kgvAssigned Tokgv => osa
2021-04-27 13:57kgvStatusnew => resolved
2021-04-27 13:58kgvRelationship addedchild of 0031548
2021-04-27 14:46osaNote Added: 0100616
2021-04-27 14:46osaAssigned Toosa => bugmaster
2021-04-27 14:46osaStatusresolved => reviewed
2021-05-01 12:27bugmasterNote Added: 0100717
2021-05-01 12:27bugmasterStatusreviewed => tested
2021-05-01 12:35bugmasterTest case number => Not required
2021-05-01 12:44bugmasterChangeset attached => occt master cece953c
2021-05-01 12:44bugmasterStatustested => verified
2021-05-01 12:44bugmasterResolutionopen => fixed
2021-05-01 13:32gitNote Added: 0100739

Notes
(0100612)
git   
2021-04-27 12:31   
Branch CR32334 has been created by kgv.

SHA-1: ea3707f997b253073b27335aafaa01fc308d6683


Detailed log of new commits:

Author: kgv
Date: Tue Apr 27 12:31:23 2021 +0300

    0032334: Visualization - SelectMgr_RectangularFrustum::Overlaps() does not set triangle normal in some cases
    
    Added missing SelectBasics_PickResult::SetSurfaceNormal().
(0100614)
kgv   
2021-04-27 13:57   
Patch is ready for review
- OCCT branch: CR32334.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32334-master-KGV/ [^]
(0100616)
osa   
2021-04-27 14:46   
The patch was reviewed
(0100717)
bugmaster   
2021-05-01 12:27   
Combination -
OCCT branch : master
Products branch : master
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17839.600000000362 / 17844.450000000477 [-0.03%]
Products
Total CPU difference: 11562.480000000109 / 11558.800000000136 [+0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 19303.28125 / 19431.828125 [-0.66%]
Products
Total CPU difference: 12894.515625 / 12871.203125 [+0.18%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0100739)
git   
2021-05-01 13:32   
Branch CR32334 has been deleted by inv.

SHA-1: ea3707f997b253073b27335aafaa01fc308d6683