MantisBT - Community
View Issue Details
0032328Community[OCCT] OCCT:Codingpublic2021-04-26 09:302021-09-11 14:06
mayer 
smoskvin 
normaltrivial 
verifiedfixed 
[OCCT] 7.6.0* 
[OCCT] 7.6.0* 
Not required
0032328: Missing include of TopoDS_Edge.hxx in ShapeUpgrade_UnifySameDomain.hxx
When using ShapeUpgrade_UnifySameDomain.hxx in client code without having included TopoDS_Edge.hxx results into a build failure because in commit https://git.dev.opencascade.org/gitweb/?p=occt.git;a=commitdiff;h=0c2517292fef234d6399aeb4e587e94045b2f305;hp=b8ef513c8f7c78c9a46d62126ff549121cf07caf [^] a new struct below has been added:
[code]
struct SubSequenceOfEdges
{
  TopTools_SequenceOfShape SeqsEdges;
  TopoDS_Edge UnionEdges;
};
[/code]

This happens with the recently released version 7.5.2 (which is not yet offered in the list of product versions)
No tags attached.
patch 0001-0032328-Missing-include-of-TopoDS_Edge.hxx-in-ShapeU.patch (2,429) 2021-09-06 02:34
https://tracker.dev.opencascade.org/
Issue History
2021-04-26 09:30mayerNew Issue
2021-04-26 09:30mayerAssigned To => msv
2021-09-06 02:34StefanBruensFile Added: 0001-0032328-Missing-include-of-TopoDS_Edge.hxx-in-ShapeU.patch
2021-09-06 10:26kgvSeverityminor => trivial
2021-09-06 10:26kgvCategoryOCCT:Modeling Algorithms => OCCT:Coding
2021-09-06 10:26kgvProduct Version => 7.6.0*
2021-09-06 10:26kgvTarget Version => 7.6.0*
2021-09-06 10:27kgvRelationship addedchild of 0032140
2021-09-06 10:36gitNote Added: 0103847
2021-09-06 10:40gitNote Added: 0103848
2021-09-06 13:59kgvNote Added: 0103863
2021-09-06 13:59kgvStatusnew => resolved
2021-09-06 17:08msvNote Added: 0103872
2021-09-06 17:08msvAssigned Tomsv => kgv
2021-09-06 17:08msvStatusresolved => assigned
2021-09-06 17:22kgvNote Added: 0103873
2021-09-06 18:11kgvAssigned Tokgv => msv
2021-09-06 18:11kgvStatusassigned => feedback
2021-09-06 21:14msvNote Added: 0103879
2021-09-07 15:04msvNote Added: 0103893
2021-09-07 15:04msvAssigned Tomsv => bugmaster
2021-09-07 15:04msvStatusfeedback => reviewed
2021-09-08 12:58gitNote Added: 0103921
2021-09-11 13:24smoskvinNote Added: 0104003
2021-09-11 13:24smoskvinStatusreviewed => tested
2021-09-11 13:32smoskvinTest case number => Not required
2021-09-11 13:43smoskvinChangeset attached => occt master 5e763282
2021-09-11 13:43smoskvinAssigned Tobugmaster => smoskvin
2021-09-11 13:43smoskvinStatustested => verified
2021-09-11 13:43smoskvinResolutionopen => fixed
2021-09-11 14:06gitNote Added: 0104038
2021-09-11 14:06gitNote Added: 0104039

Notes
(0103847)
git   
2021-09-06 10:36   
Branch CR32328 has been created by kgv.

SHA-1: 80fbdffa999b7adb383740c4b09086f4d2f45809


Detailed log of new commits:

Author: kgv
Date: Mon Sep 6 10:36:38 2021 +0300

    0032328: Missing include of TopoDS_Edge.hxx in ShapeUpgrade_UnifySameDomain.hxx
(0103848)
git   
2021-09-06 10:40   
Branch CR32328 has been updated forcibly by kgv.

SHA-1: 707ac543f92c6c6f29cf4a7781b67086bcdd521d
(0103863)
kgv   
2021-09-06 13:59   
Patch is ready for review
- OCCT: branch CR32328.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32328-master-KGV/view/OCCT%20compile/ [^]
(0103872)
msv   
2021-09-06 17:08   
Why the static function GenerateSubSeq is made a class method? There are many static functions in this cxx file, and why this one is an exception?
(0103873)
kgv   
2021-09-06 17:22   
Because it takes "SubSequenceOfEdges" as argument, and making SubSequenceOfEdges a globally defined structure as before is prohibited by coding style.
(0103879)
msv   
2021-09-06 21:14   
Why not to define SubSequenceOfEdges in unnamed namespace, as we do with static functions?
(0103893)
msv   
2021-09-07 15:04   
For integration:
occt - CR32328
products - none
(0103921)
git   
2021-09-08 12:58   
Branch CR32328_test has been created by kgv.

SHA-1: 5f363a6650ecaad734491e6f5755ed94cfccbf17


Detailed log of new commits:

Author: kgv
Date: Wed Sep 8 12:58:20 2021 +0300

    # test stack trace
(0104003)
smoskvin   
2021-09-11 13:24   
Combination -
OCCT branch : IR-2021-09-10
master SHA - 9ae883970dd77a39d856b49e6883ed5d0e60d20f
49e51745631c52b6c452c65adae4d6dfa21a1b1e
Products branch : IR-2021-09-10 SHA - 2d2bc879e2da9d770a1938ab3410f5885c8555e7
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17358.54000000042 / 17496.500000000422 [-0.79%]
Products
Total CPU difference: 11397.800000000112 / 11567.680000000111 [-1.47%]
Windows-64-VC14:
OCCT
Total CPU difference: 19328.109375 / 19307.609375 [+0.11%]
Products
Total CPU difference: 12733.328125 / 12920.953125 [-1.45%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0104038)
git   
2021-09-11 14:06   
Branch CR32328 has been deleted by mnt.

SHA-1: 707ac543f92c6c6f29cf4a7781b67086bcdd521d
(0104039)
git   
2021-09-11 14:06   
Branch CR32328_test has been deleted by mnt.

SHA-1: 5f363a6650ecaad734491e6f5755ed94cfccbf17