MantisBT - Community
View Issue Details
0032313Community[OCCT] OCCT:Modeling Algorithmspublic2021-04-21 13:042021-04-25 19:52
jensgw 
bugmaster 
normalmajor 
verifiedfixed 
[OCCT] 5.2.2 
[OCCT] 7.6.0* 
Not required
0032313: Modeling Algorithms - Missing definition of constructor in GeomFill_NSections
The folowing constructor is declared in the header but never defined in the cpp:

Standard_EXPORT GeomFill_NSections(const TColGeom_SequenceOfCurve& NC, const TColStd_SequenceOfReal& NP, const Standard_Real UF, const Standard_Real UL);

No tags attached.
Issue History
2021-04-21 13:04jensgwNew Issue
2021-04-21 13:04jensgwAssigned To => msv
2021-04-21 14:10kgvSummaryMissing definition of constructor in GeomFill_NSections => Modeling Algorithms - Missing definition of constructor in GeomFill_NSections
2021-04-21 14:12kgvTarget Version => 7.6.0*
2021-04-21 14:13kgvProduct Version7.4.0 => 5.2.2
2021-04-21 14:17gitNote Added: 0100489
2021-04-21 15:31kgvNote Added: 0100493
2021-04-21 15:31kgvStatusnew => resolved
2021-04-21 15:51msvNote Added: 0100494
2021-04-21 15:51msvAssigned Tomsv => bugmaster
2021-04-21 15:51msvStatusresolved => reviewed
2021-04-25 10:58bugmasterNote Added: 0100546
2021-04-25 10:58bugmasterStatusreviewed => tested
2021-04-25 11:07bugmasterTest case number => Not required
2021-04-25 11:55bugmasterChangeset attached => occt master f6651f22
2021-04-25 11:55bugmasterStatustested => verified
2021-04-25 11:55bugmasterResolutionopen => fixed
2021-04-25 12:24gitNote Added: 0100557
2021-04-25 19:03jensgwNote Added: 0100579
2021-04-25 19:52kgvNote Added: 0100581

Notes
(0100489)
git   
2021-04-21 14:17   
Branch CR32313 has been created by kgv.

SHA-1: b95e4e3d60142695d7790913864301fc878464ba


Detailed log of new commits:

Author: kgv
Date: Wed Apr 21 14:17:30 2021 +0300

    0032313: Modeling Algorithms - Missing definition of constructor in GeomFill_NSections
(0100493)
kgv   
2021-04-21 15:31   
Mikhail,

could you please take a look onto the patch?
- OCCT: branch CR32313.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32313-master-KGV/view/OCCT%20compile/ [^]
(0100494)
msv   
2021-04-21 15:51   
Please raise CR32313 into occt.
(0100546)
bugmaster   
2021-04-25 10:58   
Combination -
OCCT branch : IR-2021-04-23
master SHA - fd2efe5428b3b2b9d300b0612c0a53ee2486ba64
a87b7ddc8cb44606b91e3f37113847c3f5f50fdc
Products branch : IR-2021-04-23 SHA - 740db2b9c0429fd95b1e8cf3790001245aaec02b
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17901.710000000523 / 17988.35000000045 [-0.48%]
Products
Total CPU difference: 11558.800000000136 / 11564.760000000093 [-0.05%]
Windows-64-VC14:
OCCT
Total CPU difference: 5522.40625 / 5520.953125 [+0.03%]
Products
Total CPU difference: 12871.203125 / 12932.890625 [-0.48%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0100557)
git   
2021-04-25 12:24   
Branch CR32313 has been deleted by inv.

SHA-1: b95e4e3d60142695d7790913864301fc878464ba
(0100579)
jensgw   
2021-04-25 19:03   
Hi there, wow that fix is progressing quickly!
A note on "Test case number => Not required ".
If you do not already have it, it is highly beneficial to have a test for every one of the constructor methods - not only for this class but in general.
 a) Testing existence of the method ;-)
 b) Testing the assumed cases with valid input
 c) Testing the error cases with "bullshit" input
(0100581)
kgv   
2021-04-25 19:52   
jensgw,
> If you do not already have it,
> it is highly beneficial to have a test for every one
> of the constructor methods
thanks for suggestions.

Fill free to consider them in patches.