MantisBT - Open CASCADE
View Issue Details
0032121Open CASCADE[OCCT] OCCT:DRAWpublic2021-02-06 18:492021-07-17 10:05
kgv 
kgv 
normalfeature 
verifiedfixed 
 
[OCCT] 7.6.0* 
Not required
0032121: Draw Harness, ViewerTest - implement -reset option for vlight command
It is proposed extended vlight command with -reset argument which will replace light source with specified index with newly created one.
If replaced light source was already displayed - the new once should be displayed instead.
pload MODELING VISUALIZATION
vclear
vinit View1 -width 1280 -height 720
vlight -clear
vbackground -color GRAY
vrenderparams -shadingModel PBR
box b 10 10 10 30 30 30
vdisplay b -dispMode 1
vaspects b -material Brass
vfit

vlight light1   -type positional -pos 25 25 50 -intensity 10000000000 -range 20 -color BLUE -display

vlight light1   -reset
vlight amblight -type ambient -color WHITE -display
vlight spot     -type spotlight -pos 50 25 25 -dir -1 0 0 -intensity 1000000000 -color RED -display

vlight dirlight -type directional -dir 0 1 0 -color GREEN -display
vlight

No tags attached.
related to 0031704verified bugmaster Visualization - add an interactive object AIS_LightSource representing a light source 
Issue History
2021-02-06 18:49kgvNew Issue
2021-02-06 18:49kgvAssigned To => mkrylova
2021-02-06 18:49kgvStatusnew => assigned
2021-02-06 18:50kgvRelationship addedrelated to 0031704
2021-02-09 18:23gitNote Added: 0098797
2021-02-09 18:28mkrylovaAssigned Tomkrylova => kgv
2021-02-09 18:28mkrylovaStatusassigned => resolved
2021-02-09 18:28mkrylovaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24498#r24498
2021-07-09 17:57gitNote Added: 0102409
2021-07-09 23:21kgvSummaryDraw Harness, ViewerTest - implement -set option for vlight command => Draw Harness, ViewerTest - implement -reset option for vlight command
2021-07-09 23:21kgvDescription Updatedbug_revision_view_page.php?rev_id=25472#r25472
2021-07-09 23:21kgvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25473#r25473
2021-07-10 00:19gitNote Added: 0102428
2021-07-10 10:36gitNote Added: 0102429
2021-07-10 12:11kgvNote Added: 0102430
2021-07-10 12:11kgvAssigned Tokgv => bugmaster
2021-07-10 12:11kgvStatusresolved => reviewed
2021-07-12 20:50gitNote Added: 0102479
2021-07-17 09:45bugmasterNote Added: 0102594
2021-07-17 09:45bugmasterStatusreviewed => tested
2021-07-17 09:47bugmasterTest case number => Not required
2021-07-17 09:58kgvChangeset attached => occt master 06d40093
2021-07-17 09:58kgvAssigned Tobugmaster => kgv
2021-07-17 09:58kgvStatustested => verified
2021-07-17 09:58kgvResolutionopen => fixed
2021-07-17 10:04gitNote Added: 0102605
2021-07-17 10:04gitNote Added: 0102606
2021-07-17 10:05gitNote Added: 0102607

Notes
(0098797)
git   
2021-02-09 18:23   
Branch CR32121 has been created by mkrylova.

SHA-1: bb747def4fffd3333f081274a399d35258a9757c


Detailed log of new commits:

Author: mkrylova
Date: Tue Feb 9 18:01:53 2021 +0300

    0032121: Draw Harness, ViewerTest - implement -set option for vlight command
    
    - Extended vlight command with -set/-replace argument
(0102409)
git   
2021-07-09 17:57   
Branch CR32121_1 has been created by kgv.

SHA-1: f77c792eed1f50c8c1544be79bce600bd3cc52ac


Detailed log of new commits:

Author: mkrylova
Date: Tue Feb 9 18:01:53 2021 +0300

    0032121: Draw Harness, ViewerTest - implement -set option for vlight command
    
    vlight command has been revised to make it more friendly.
    Added arguments -enable/-disable for managing enabled state.
    vlight command now accepts light index or name as first argument.
    Added -set/-replace argument.
    
    V3d_Viewer::SetDefaultLights() now sets names "headlight" and "ambient" to created lights.
    Draw::Atof(), applied corrections to avoid explicit new/delete calls.
(0102428)
git   
2021-07-10 00:19   
Branch CR32121_2 has been created by kgv.

SHA-1: 1f9cb5ee7c6049ee676c5a9648046eb2f7cc9071


Detailed log of new commits:

Author: kgv
Date: Fri Jul 9 23:22:29 2021 +0300

    0032121: Draw Harness, ViewerTest - implement -reset option for vlight command
    
    vlight command has been revised to provide more friendly syntax.
    Command now accepts light index or name as first argument.
    Added arguments -enable/-disable for managing enabled state.
    Added argument -reset to reset light parameters to default values.
    
    V3d_Viewer::SetDefaultLights() now sets names "headlight" and "ambient" to created lights.
    Graphic3d_TypeOfLightSource enumeration values have been renamed to avoid shortcuts.
    Draw::Atof(), applied corrections to avoid explicit new/delete calls.
(0102429)
git   
2021-07-10 10:36   
Branch CR32121_2 has been updated forcibly by kgv.

SHA-1: c134d00dec5de3b7b12121898ed5f1ae149f8a0a
(0102430)
kgv   
2021-07-10 12:11   
Please raise the patch
- OCCT: branch CR32121_2.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32121_2-master-KGV/ [^]
(0102479)
git   
2021-07-12 20:50   
Branch CR32121_2 has been updated forcibly by kgv.

SHA-1: 06d40093b715adf9cb1e36d25e5fde6bef2f7b41
(0102594)
bugmaster   
2021-07-17 09:45   
Combination -
OCCT branch : IR-2021-07-16
master SHA - acab849d30f2acb733586120dcd2b43f2ae59769
a87b7ddc8cb44606b91e3f37113847c3f5f50fdc
Products branch : IR-2021-07-16 SHA - 0b2936175e8e41158165aa983c4bd52035d88570
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17229.290000000303 / 17544.51000000034 [-1.80%]
Products
Total CPU difference: 11476.020000000117 / 11490.74000000011 [-0.13%]
Windows-64-VC14:
OCCT
Total CPU difference: 19019.8125 / 19318.21875 [-1.54%]
Products
Total CPU difference: 12732.515625 / 12831.40625 [-0.77%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0102605)
git   
2021-07-17 10:04   
Branch CR32121 has been deleted by mnt.

SHA-1: bb747def4fffd3333f081274a399d35258a9757c
(0102606)
git   
2021-07-17 10:04   
Branch CR32121_1 has been deleted by mnt.

SHA-1: f77c792eed1f50c8c1544be79bce600bd3cc52ac
(0102607)
git   
2021-07-17 10:05   
Branch CR32121_2 has been deleted by mnt.

SHA-1: 06d40093b715adf9cb1e36d25e5fde6bef2f7b41