MantisBT - Open CASCADE
View Issue Details
0032045Open CASCADE[OCCT] OCCT:Visualizationpublic2021-01-10 01:412021-01-12 14:58
kgv 
bugmaster 
normalintegration request 
reviewedopen 
 
[OCCT] 7.6.0* 
0032045: Visualization, TKOpenGl - move light source functions from OpenGl_ShaderManager.cxx to Shaders
It is desired moving out light source GLSL functions from OpenGl_ShaderManager.cxx to Shaders.
No tags attached.
Issue History
2021-01-10 01:41kgvNew Issue
2021-01-10 01:41kgvAssigned To => kgv
2021-01-10 01:42gitNote Added: 0098028
2021-01-10 02:34gitNote Added: 0098034
2021-01-10 11:11kgvNote Added: 0098038
2021-01-10 11:11kgvAssigned Tokgv => osa
2021-01-10 11:11kgvStatusnew => resolved
2021-01-12 14:58osaNote Added: 0098091
2021-01-12 14:58osaAssigned Toosa => bugmaster
2021-01-12 14:58osaStatusresolved => reviewed

Notes
(0098028)
git   
2021-01-10 01:42   
Branch CR32045 has been created by kgv.

SHA-1: 352a58bfedfb92858951823dc3474bb28ddbf8ca


Detailed log of new commits:

Author: kgv
Date: Sun Jan 10 01:43:03 2021 +0300

    0032045: Visualization, TKOpenGl - move light source functions from OpenGl_ShaderManager.cxx to Shaders

Author: kgv
Date: Sun Jan 3 03:05:32 2021 +0300

    0032036: Visualization, TKOpenGl - broken Cubemap background on GeForce 320M
    
    Enable GL_DEPTH_CLAMP while rendering skybox to workaround unexpected clamping issue on some GPUs.
(0098034)
git   
2021-01-10 02:34   
Branch CR32045 has been updated forcibly by kgv.

SHA-1: cbf9d595d62baa547fc811e6c8b6b0859fae2594
(0098038)
kgv   
2021-01-10 11:11   
Patch is ready for review
- OCCT branch: CR32045.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR32045-master-KGV/ [^]
(0098091)
osa   
2021-01-12 14:58   
The patch was reviewed without remarks