MantisBT - Community
View Issue Details
0031939Community[OCCT] OCCT:Codingpublic2020-11-15 18:112020-12-05 13:01
abv 
kgv 
normalminor 
verifiedreopened 
[OCCT] 7.5.0 
[OCCT] 7.6.0* 
Not required
0031939: Coding - correction of spelling errors in comments
The patch containing corrections of spelling errors in comments has been proposed on SALOME user's form: https://www.salome-platform.org/forum/forum_9/875695368 [^]

According to comment, the corrections are made with codespell tool
N/A
No tags attached.
has duplicate 0031938closed bugmaster Coding - correction of spelling errors in comments 
has duplicate 0031929closed bugmaster Coding - correction of spelling errors in comments 
has duplicate 0031928closed bugmaster Coding - correction of spelling errors in comments 
Issue History
2020-11-15 18:11abvNew Issue
2020-11-15 18:11abvAssigned To => kgv
2020-11-15 18:13gitNote Added: 0096780
2020-11-16 08:58gitNote Added: 0096782
2020-11-16 09:01abvNote Added: 0096783
2020-11-16 09:01abvStatusnew => resolved
2020-11-16 09:01abvSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=24009#r24009
2020-11-16 10:39kgvAssigned Tokgv => bugmaster
2020-11-16 10:39kgvStatusresolved => reviewed
2020-11-18 11:19kgvRelationship addedhas duplicate 0031938
2020-11-18 11:19kgvRelationship addedhas duplicate 0031929
2020-11-18 11:19kgvRelationship addedhas duplicate 0031928
2020-11-21 12:39bugmasterChangeset attached => occt master 21c7c457
2020-11-21 12:39bugmasterStatusreviewed => verified
2020-11-21 12:39bugmasterResolutionopen => fixed
2020-11-21 12:42bugmasterNote Added: 0096932
2020-11-21 12:46bugmasterTest case number => Not required
2020-11-21 13:27gitNote Added: 0096952
2020-11-23 12:33eapNote Added: 0097009
2020-11-23 12:33eapStatusverified => feedback
2020-11-23 12:33eapResolutionfixed => reopened
2020-11-23 12:34eapStatusfeedback => assigned
2020-11-23 12:46kgvAssigned Tobugmaster => abv
2020-11-23 12:46kgvProduct Version => 7.5.0
2020-11-30 12:55gitNote Added: 0097159
2020-11-30 13:02eapNote Added: 0097160
2020-11-30 13:02eapAssigned Toabv => kgv
2020-11-30 13:03eapNote Edited: 0097160bug_revision_view_page.php?bugnote_id=97160#r24094
2020-11-30 13:55gitNote Added: 0097162
2020-11-30 14:03gitNote Added: 0097164
2020-11-30 14:06kgvNote Added: 0097165
2020-11-30 14:06kgvAssigned Tokgv => bugmaster
2020-11-30 14:06kgvStatusassigned => resolved
2020-11-30 14:06kgvStatusresolved => reviewed
2020-12-05 11:56bugmasterNote Added: 0097343
2020-12-05 11:56bugmasterStatusreviewed => tested
2020-12-05 12:15kgvChangeset attached => occt master a110c4a3
2020-12-05 12:15kgvAssigned Tobugmaster => kgv
2020-12-05 12:15kgvStatustested => verified
2020-12-05 13:01gitNote Added: 0097365

Notes
(0096780)
git   
2020-11-15 18:13   
Branch CR31939 has been created by abv.

SHA-1: 4387239c7281f1371709ab60d503bcc6bf756cff


Detailed log of new commits:

Author: luz paz
Date: Fri Nov 13 10:46:02 2020 -0500

    Fix various typos
    
    Fixed via `codespell v2.0.dev`
(0096782)
git   
2020-11-16 08:58   
Branch CR31939 has been updated forcibly by abv.

SHA-1: 9d7e20e5c60a4af2aad00c7fe628ce50f889f743
(0096783)
abv   
2020-11-16 09:01   
Patch is pushed to branch CR31939, please review. Most of changes are in comments, yet there are some in text strings, and couple of places where spaces in the end of lines are cleared.
(0096932)
bugmaster   
2020-11-21 12:42   
Combination -
OCCT branch : IR-2020-11-20
master SHA - c5892d852bb462075f9db03f31085e35d7b59f35
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-11-20 SHA - a5d1f89f5fa83c955e6a604f57a5b590eb433b43
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18024.090000000127 / 17964.340000000077 [+0.33%]
Products
Total CPU difference: 12166.12000000011 / 12169.520000000111 [-0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 19696.90625 / 19723.125 [-0.13%]
Products
Total CPU difference: 13644.875 / 13567.078125 [+0.57%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0096952)
git   
2020-11-21 13:27   
Branch CR31939 has been deleted by inv.

SHA-1: 9d7e20e5c60a4af2aad00c7fe628ce50f889f743
(0097009)
eap   
2020-11-23 12:33   
Another patch arrived https://www.salome-platform.org/forum/forum_9/875695368/620840338 [^]

Could you apply it as well?
(0097159)
git   
2020-11-30 12:55   
Branch CR31939 has been created by eap.

SHA-1: 41a907f472f2b9454a1946cb02ee058d5a2ebb2a


Detailed log of new commits:

Author: eap
Date: Mon Nov 30 12:55:48 2020 +0300

    From: luz paz <luzpaz@users.noreply.github.com>
    Date: Sun, 22 Nov 2020 12:07:56 -0500
    
     Fix typos pt.2
(0097160)
eap   
2020-11-30 13:02   
(edited on: 2020-11-30 13:03)
Patch nb.2 is pushed to branch CR31939, please review. Most of changes are in comments, yet there are some in text strings, and couple of places where spaces in the end of lines are cleared.

(0097162)
git   
2020-11-30 13:55   
Branch CR31939 has been updated forcibly by kgv.

SHA-1: ad42f1c3c888ed43ce3b658b240aed9d38832e8d
(0097164)
git   
2020-11-30 14:03   
Branch CR31939 has been updated forcibly by kgv.

SHA-1: a110c4a3777de359b6bbe2b3baeb99fe34f2bdf7
(0097165)
kgv   
2020-11-30 14:06   
Please raise the second patch
- OCCT branch: CR31939.
(0097343)
bugmaster   
2020-12-05 11:56   
Combination -
OCCT branch : IR-2020-12-04
master SHA - 1e08a76f1e872a1f38931a6c3e8cf71396fc1209
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-12-04 SHA - cb56638fb6b31df41b28133f69a1dc202dcb56aa
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18090.67999999998 / 18052.040000000085 [+0.21%]
Products
Total CPU difference: 12342.950000000128 / 12326.850000000131 [+0.13%]
Windows-64-VC14:
OCCT
Total CPU difference: 19751.5 / 19705.828125 [+0.23%]
Products
Total CPU difference: 13772.515625 / 13793.796875 [-0.15%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0097365)
git   
2020-12-05 13:01   
Branch CR31939 has been deleted by inv.

SHA-1: a110c4a3777de359b6bbe2b3baeb99fe34f2bdf7