MantisBT - Open CASCADE
View Issue Details
0031909Open CASCADE[OCCT] OCCT:Visualizationpublic2020-11-05 16:142020-11-21 13:28
kgv 
bugmaster 
normalintegration request 
verifiedfixed 
[OCCT] 7.2.0 
[OCCT] 7.6.0* 
Not required
0031909: Visualization, AIS_Trihedron - replace maps with arrays
AIS_Trihedron and Prs3d_DatumAspect classes use NCollection_Map for storing properties of fixed length, which looks redundant and inefficient.
N/A
No tags attached.
child of 0027958closed bugmaster Visualization, AIS_Trihedron - add shaded presentation option 
Issue History
2020-11-05 16:14kgvNew Issue
2020-11-05 16:14kgvAssigned To => kgv
2020-11-05 16:14kgvSummaryVisualization, AIS_Trihedron - use arrays instead of maps => Visualization, AIS_Trihedron - replace maps with arrays
2020-11-05 16:16gitNote Added: 0096566
2020-11-05 16:17kgvRelationship addedchild of 0027958
2020-11-06 10:23kgvNote Added: 0096572
2020-11-06 10:23kgvAssigned Tokgv => osa
2020-11-06 10:23kgvSeverityminor => integration request
2020-11-06 10:23kgvStatusnew => resolved
2020-11-06 13:50osaNote Added: 0096587
2020-11-06 13:50osaAssigned Toosa => bugmaster
2020-11-06 13:50osaStatusresolved => reviewed
2020-11-21 12:39bugmasterChangeset attached => occt master 24f9d04c
2020-11-21 12:39bugmasterStatusreviewed => verified
2020-11-21 12:39bugmasterResolutionopen => fixed
2020-11-21 12:43bugmasterNote Added: 0096939
2020-11-21 12:50bugmasterTest case number => Not required
2020-11-21 13:28gitNote Added: 0096962

Notes
(0096566)
git   
2020-11-05 16:16   
Branch CR31909 has been created by kgv.

SHA-1: 5ccd55feba2c641bc3f6f6115ea888c9f3f3b1a8


Detailed log of new commits:

Author: kgv
Date: Thu Nov 5 12:30:46 2020 +0300

    0031909: Visualization, AIS_Trihedron - replace maps with arrays
    
    Prs3d_DatumAspect, AIS_Trihedron - redundant maps have been replaced by explicitly sized arrays.
    
    AIS_Trihedron::myHasOwnDatumAspect - removed unused class field.
    
    Prs3d_DatumAttribute, Prs3d_DatumParts, Prs3d_DatumAxes - enumeration values
    have been renamed to have full name prefix.
    
    vzbufftrihedron - fixed no more necessary Quantity_Color -> Quantity_NameOfColor convertion.
(0096572)
kgv   
2020-11-06 10:23   
Patch is ready for review
- OCCT branch: CR31909.

A couple of image differences (bugs/vis/bug22483_4, bugs/vis/bug22483_3) reflects changes in vzbufftrihedron command that does not convert color to name.
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31909-master-KGV/ [^]
(0096587)
osa   
2020-11-06 13:50   
The patch was reviewed without remarks
(0096939)
bugmaster   
2020-11-21 12:43   
Combination -
OCCT branch : IR-2020-11-20
master SHA - c5892d852bb462075f9db03f31085e35d7b59f35
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-11-20 SHA - a5d1f89f5fa83c955e6a604f57a5b590eb433b43
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18024.090000000127 / 17964.340000000077 [+0.33%]
Products
Total CPU difference: 12166.12000000011 / 12169.520000000111 [-0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 19696.90625 / 19723.125 [-0.13%]
Products
Total CPU difference: 13644.875 / 13567.078125 [+0.57%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0096962)
git   
2020-11-21 13:28   
Branch CR31909 has been deleted by inv.

SHA-1: 5ccd55feba2c641bc3f6f6115ea888c9f3f3b1a8