MantisBT - Open CASCADE
View Issue Details
0031709Open CASCADE[OCCT] OCCT:DRAWpublic2020-08-12 16:302020-09-05 12:40
kgv 
bugmaster 
normalintegration request 
verifiedfixed 
 
[OCCT] 7.5.0 
Not required
0031709: Draw Harness - move methods ViewerTest::ParseOnOff()/ParseColor() to package Draw
Parsing color and on/off arguments is a common task not specific to ViewerTest plugin, so that it is desired moving these methods to Draw package.
N/A
No tags attached.
related to 0031713verified bugmaster Draw Harness, IVtkDraw - add commands ivtksetcolor, ivtkaxo, ivtkclose, ivtksettransparency 
Issue History
2020-08-12 16:30kgvNew Issue
2020-08-12 16:30kgvAssigned To => kgv
2020-08-12 16:48gitNote Added: 0093480
2020-08-13 22:53kgvNote Added: 0093493
2020-08-13 22:53kgvAssigned Tokgv => osa
2020-08-13 22:53kgvStatusnew => resolved
2020-08-13 22:54kgvRelationship addedrelated to 0031713
2020-08-14 09:45gitNote Added: 0093497
2020-08-14 09:52osaNote Added: 0093500
2020-08-14 09:52osaAssigned Toosa => bugmaster
2020-08-14 09:52osaStatusresolved => reviewed
2020-08-16 11:38bugmasterNote Added: 0093507
2020-08-16 11:38bugmasterStatusreviewed => tested
2020-08-16 11:43bugmasterTest case number => Not required
2020-08-16 11:44bugmasterChangeset attached => occt master dae2a922
2020-08-16 11:44bugmasterStatustested => verified
2020-08-16 11:44bugmasterResolutionopen => fixed
2020-08-16 11:52gitNote Added: 0093509

Notes
(0093480)
git   
2020-08-12 16:48   
Branch CR31709 has been created by kgv.

SHA-1: 9f44e1ab5bc02ac2c676ddd7a512bf72516d93a7


Detailed log of new commits:

Author: kgv
Date: Wed Aug 12 15:58:22 2020 +0300

    0031709: Draw Harness - move methods ViewerTest::ParseOnOff()/ParseColor() to package Draw
    
    Methods ParseOnOff()/ParseColor() have been moved from package ViewerTest to Draw.
    Command "vlight -color" now accepts RGB values, not only name.
    Implementation of pload command has been cleaned up.
(0093493)
kgv   
2020-08-13 22:53   
Patch is ready for review, branches CR31709 in OCCT and OCC Products.

Tested in scope of 0031713:
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31713-master-KGV/view/PRODUCTS%20compile/ [^]
(0093497)
git   
2020-08-14 09:45   
Branch CR31709 has been updated forcibly by kgv.

SHA-1: f084c01dfb7f3af60f7f41f61d747d0c2eb5d192
(0093500)
osa   
2020-08-14 09:52   
The patch was reviewed
(0093507)
bugmaster   
2020-08-16 11:38   
Combination -
OCCT branch : IR-2020-08-14
master SHA - 12e6d49993ae1c998ad802086e0ff62e4f93c6a1
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-08-14 SHA - 538cec7d7ec12567665956502d9224b22edaab31
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17160.250000000116 / 17191.360000000128 [-0.18%]
Products
Total CPU difference: 11820.020000000079 / 11889.420000000087 [-0.58%]
Windows-64-VC14:
OCCT
Total CPU difference: 18724.890625 / 18788.5625 [-0.34%]
Products
Total CPU difference: 13316.109375 / 13265.75 [+0.38%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0093509)
git   
2020-08-16 11:52   
Branch CR31709 has been deleted by inv.

SHA-1: f084c01dfb7f3af60f7f41f61d747d0c2eb5d192