MantisBT - Open CASCADE
View Issue Details
0031636Open CASCADE[OCCT] PRODUCTS:Codingpublic2020-06-28 14:052020-11-21 13:30
kgv 
bugmaster 
normalminor 
verifiedfixed 
[OCCT] 7.4.0 
[OCCT] 7.6.0* 
Not required
0031636: Codig Rules, OMFAlgo - replace TCollection templates with NCollection
Package TCollection contains files related to old collections like TCollection_Array1.lxx, which are no more exist.

For this, the remnants of generic templates should be removed from OMFAlgo package.
Not required
No tags attached.
related to 0029642verified bugmaster Foundation Classes - deprecate TCollection classes except strings 
Issue History
2020-06-28 14:05kgvNew Issue
2020-06-28 14:05kgvAssigned To => kgv
2020-06-29 10:33gitNote Added: 0092829
2020-06-29 10:34kgvDescription Updatedbug_revision_view_page.php?rev_id=23080#r23080
2020-08-28 14:27kgvAssigned Tokgv => mzernova
2020-08-28 14:27kgvStatusnew => assigned
2020-08-28 14:27kgvTarget Version7.5.0 => 7.6.0*
2020-10-28 14:39gitNote Added: 0096333
2020-10-28 16:15gitNote Added: 0096337
2020-10-28 16:15gitNote Added: 0096338
2020-10-29 00:27mzernovaNote Added: 0096352
2020-10-29 00:29mzernovaAssigned Tomzernova => kgv
2020-10-29 00:29mzernovaStatusassigned => resolved
2020-10-29 00:29mzernovaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23907#r23907
2020-10-29 07:56kgvNote Added: 0096353
2020-10-29 07:56kgvAssigned Tokgv => mzernova
2020-10-29 07:56kgvStatusresolved => assigned
2020-10-31 10:10mzernovaAssigned Tomzernova => kgv
2020-10-31 10:10mzernovaStatusassigned => resolved
2020-11-02 10:40kgvNote Added: 0096438
2020-11-02 10:41kgvNote Edited: 0096438bug_revision_view_page.php?bugnote_id=96438#r23925
2020-11-02 10:42kgvAssigned Tokgv => mzernova
2020-11-02 10:42kgvStatusresolved => assigned
2020-11-16 13:45gitNote Added: 0096792
2020-11-16 13:47mzernovaAssigned Tomzernova => kgv
2020-11-16 13:47mzernovaStatusassigned => resolved
2020-11-16 14:48kgvNote Added: 0096795
2020-11-16 14:48kgvAssigned Tokgv => mzernova
2020-11-16 14:48kgvStatusresolved => assigned
2020-11-16 17:18gitNote Added: 0096800
2020-11-16 22:05abvRelationship addedrelated to 0029642
2020-11-17 09:39mzernovaNote Added: 0096812
2020-11-17 09:39mzernovaAssigned Tomzernova => kgv
2020-11-17 09:39mzernovaStatusassigned => resolved
2020-11-17 09:47kgvCategoryOCCT:Coding => PRODUCTS:Coding
2020-11-17 09:47kgvSummaryCodig Rules - eliminate dead code TCollection_Array1.lxx => Codig Rules, OMFAlgo - replace TCollection templates with NCollection
2020-11-17 14:03kgvNote Added: 0096823
2020-11-17 14:03kgvAssigned Tokgv => bugmaster
2020-11-17 14:03kgvStatusresolved => reviewed
2020-11-21 13:00bugmasterTest case number => Not required
2020-11-21 13:00bugmasterNote Added: 0096942
2020-11-21 13:00bugmasterStatusreviewed => verified
2020-11-21 13:00bugmasterResolutionopen => fixed
2020-11-21 13:02bugmasterNote Added: 0096944
2020-11-21 13:27gitNote Added: 0096949
2020-11-21 13:27gitNote Added: 0096950
2020-11-21 13:28gitNote Added: 0096971

Notes
(0092829)
git   
2020-06-29 10:33   
Branch CR31636 has been created by kgv.

SHA-1: b7eb5db40322c9c6aa1bac5c13ee75a73f08646b


Detailed log of new commits:

Author: kgv
Date: Mon Jun 29 10:35:07 2020 +0300

    0031636: Codig Rules - eliminate dead code TCollection_Array1.lxx
(0096333)
git   
2020-10-28 14:39   
Branch CR31636_1 has been created by mzernova.

SHA-1: d22c7e2795bf1c5ec1f25c5f86ba56abd48ceb80


Detailed log of new commits:

Author: kgv
Date: Mon Jun 29 10:35:07 2020 +0300

    0031636: Codig Rules - eliminate dead code TCollection_Array1.lxx
    
    (cherry picked from commit b7eb5db40322c9c6aa1bac5c13ee75a73f08646b)
(0096337)
git   
2020-10-28 16:15   
Branch CR31636_1 has been updated by mzernova.

SHA-1: 1bf654cceca7c28c766bbe2b56bf97b6202ce9c7


Detailed log of new commits:

Author: mzernova
Date: Wed Oct 28 16:03:10 2020 +0300

    Removed TCollection_SeqNode.hxx and TCollection_SeqNodePtr.hxx

(0096338)
git   
2020-10-28 16:15   
Branch CR31636_2 has been created by mzernova.

SHA-1: 555da1f3dce4770ed65bfa2253e6feb0052c9c8c


Detailed log of new commits:

Author: kgv
Date: Mon Jun 29 10:35:07 2020 +0300

    0031636: Codig Rules - eliminate dead code TCollection_Array1.lxx
(0096352)
mzernova   
2020-10-29 00:27   
http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31636_1-CR31636_1-mzernova/ [^]
(0096353)
kgv   
2020-10-29 07:56   
+OMFAlgo_List.gxx
+OMFAlgo_List.lxx
+OMFAlgo_ListIterator.gxx
+OMFAlgo_ListIterator.lxx
...
+#define OMFAlgo_DataMap_hxx <OMFAlgo_DataMapOfIntegerMapOfInteger.hxx>
+#include <OMFAlgo_DataMapIterator.gxx>
...

.lxx and .gxx files are remnants of the past - there should be no need in adding new .lxx files (except for large header-only templates) and should be a better way then defining .gxx files.
(0096438)
kgv   
2020-11-02 10:40   
(edited on: 2020-11-02 10:41)
+template <class TheKey, class TheItem, class TheHasher>
+class OMFAlgo_DataMap : public TCollection_BasicMap

Class description is missing.
It is unclear how this template is different from NCollection_DataMap and similar maps.

The same is for OMFAlgo_List - why not using NCollection_List?

(0096792)
git   
2020-11-16 13:45   
Branch CR31636_2 has been updated forcibly by mzernova.

SHA-1: 028bc2d260fc6ab2806c4d43a41d087caefac070
(0096795)
kgv   
2020-11-16 14:48   
Please try to get rid of redundant map collections.
(0096800)
git   
2020-11-16 17:18   
Branch CR31636_1 has been updated forcibly by mzernova.

SHA-1: 8e388343e768de6731a118fa88552e9ff2a41f28
(0096812)
mzernova   
2020-11-17 09:39   
OCCT branch: CR31636_2
Products branch: CR31636_1
(0096823)
kgv   
2020-11-17 14:03   
Please raise the patch
- OCCT branch: None
- Products branch: CR31636_3

http://jenkins-test-12.nnov.opencascade.com:8080/view/master-CR31636_3-KGV/ [^]
(0096942)
bugmaster   
2020-11-21 13:00   
Combination -
OCCT branch : IR-2020-11-20
master SHA - c5892d852bb462075f9db03f31085e35d7b59f35
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-11-20 SHA - a5d1f89f5fa83c955e6a604f57a5b590eb433b43
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 18024.090000000127 / 17964.340000000077 [+0.33%]
Products
Total CPU difference: 12166.12000000011 / 12169.520000000111 [-0.03%]
Windows-64-VC14:
OCCT
Total CPU difference: 19696.90625 / 19723.125 [-0.13%]
Products
Total CPU difference: 13644.875 / 13567.078125 [+0.57%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0096944)
bugmaster   
2020-11-21 13:02   
Fix has been integrated into master of occt-products repository
(0096949)
git   
2020-11-21 13:27   
Branch CR31636_1 has been deleted by inv.

SHA-1: 8e388343e768de6731a118fa88552e9ff2a41f28
(0096950)
git   
2020-11-21 13:27   
Branch CR31636_2 has been deleted by inv.

SHA-1: 028bc2d260fc6ab2806c4d43a41d087caefac070
(0096971)
git   
2020-11-21 13:28   
Branch CR31636 has been deleted by inv.

SHA-1: b7eb5db40322c9c6aa1bac5c13ee75a73f08646b