MantisBT - Open CASCADE
View Issue Details
0031622Open CASCADE[OCCT] OCCT:Samplespublic2020-06-20 22:532020-06-28 12:48
kgv 
bugmaster 
normalminor 
verifiedfixed 
[OCCT] 7.4.0 
[OCCT] 7.5.0* 
Not required
0031622: Samples - update MFC Animation sample with proper frame updates
MFC Animation sample in current state demonstrates broken animation logic - it ignores real elapsed time and blocks 3D viewer interactions.
N/A
No tags attached.
related to 0028087new bugmaster OCCT Samples Redesign 
child of 0030507closed bugmaster Visualization - introduce AIS_ViewController 
child of 0027764closed apn Visualization - add functionality for animation of 3D camera and interactive objects 
Issue History
2020-06-20 22:53kgvNew Issue
2020-06-20 22:53kgvAssigned To => kgv
2020-06-20 22:53kgvSeverityfeature => minor
2020-06-20 22:53kgvProduct Version => 7.4.0
2020-06-20 22:58gitNote Added: 0092627
2020-06-20 23:00kgvRelationship addedchild of 0030507
2020-06-20 23:01kgvRelationship addedchild of 0027764
2020-06-20 23:32kgvNote Added: 0092628
2020-06-20 23:32kgvAssigned Tokgv => nds
2020-06-20 23:32kgvStatusnew => resolved
2020-06-22 14:24ndsNote Added: 0092652
2020-06-22 14:24ndsAssigned Tonds => kgv
2020-06-22 14:24ndsStatusresolved => assigned
2020-06-22 15:29gitNote Added: 0092659
2020-06-22 15:29kgvNote Added: 0092660
2020-06-22 15:29kgvAssigned Tokgv => nds
2020-06-22 15:29kgvStatusassigned => resolved
2020-06-22 16:04ndsAssigned Tonds => bugmaster
2020-06-22 16:04ndsStatusresolved => reviewed
2020-06-25 22:43kgvRelationship addedrelated to 0028087
2020-06-28 11:28bugmasterNote Added: 0092793
2020-06-28 11:28bugmasterStatusreviewed => tested
2020-06-28 11:34bugmasterTest case number => Not required
2020-06-28 12:35bugmasterChangeset attached => occt master 64f128c1
2020-06-28 12:35bugmasterStatustested => verified
2020-06-28 12:35bugmasterResolutionopen => fixed
2020-06-28 12:48gitNote Added: 0092807

Notes
(0092627)
git   
2020-06-20 22:58   
Branch CR31622 has been created by kgv.

SHA-1: b6492c7e11614682e5b832577ed71c1b4e1de731


Detailed log of new commits:

Author: kgv
Date: Sat Jun 20 23:00:17 2020 +0300

    0031622: Samples - update MFC Animation sample with proper frame updates
    
    Animation sample has been updated to:
    - use reuse AIS_ViewController for general viewer manipulations;
    - update animation using elapsed time;
    - do not block camera manipilations;
    - get rid of redundant controls.
(0092628)
kgv   
2020-06-20 23:32   
Patch is ready for review in OCCT branch CR31622.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31622-master-KGV/view/SAMPLES/ [^]
(0092652)
nds   
2020-06-22 14:24   
Please, avoid adding additional levels in code:

void CAnimationView3D::update3dView()
{
  if (!myView.IsNull())
  {
    if (++myUpdateRequests == 1)
    {
      Invalidate (FALSE);
      UpdateWindow();
    }
  }
}
(0092659)
git   
2020-06-22 15:29   
Branch CR31622 has been updated forcibly by kgv.

SHA-1: 933ddb06b00874056c5bb400a2eb9cf5d876c0d7
(0092660)
kgv   
2020-06-22 15:29   
Remark has been applied.
(0092793)
bugmaster   
2020-06-28 11:28   
Combination -
OCCT branch : IR-2020-06-26
master SHA - 832a6f4412321ca784bbb36916dc740d04a05c0c
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-06-26 SHA - 180ab3ca4e501bda3da57c99a8ac8b220db33df3
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17164.36000000016 / 17160.400000000114 [+0.02%]
Products
Total CPU difference: 11173.720000000081 / 11197.400000000112 [-0.21%]
Windows-64-VC14:
OCCT
Total CPU difference: 18707.65625 / 18650.578125 [+0.31%]
Products
Total CPU difference: 13062.6875 / 13012.71875 [+0.38%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0092807)
git   
2020-06-28 12:48   
Branch CR31622 has been deleted by inv.

SHA-1: 933ddb06b00874056c5bb400a2eb9cf5d876c0d7