MantisBT - Open CASCADE
View Issue Details
0031619Open CASCADE[OCCT] OCCT:Samplespublic2020-06-20 02:102020-06-28 12:48
kgv 
kgv 
normalfeature 
verifiedfixed 
 
[OCCT] 7.5.0* 
Not required
0031619: Samples - update JNI sample to use Android Studio
It is desired updating JNI sample for building it using Android Studio (recommended by Google) instead of Eclipse.
N/A
No tags attached.
Issue History
2020-06-20 02:10kgvNew Issue
2020-06-20 02:10kgvAssigned To => kgv
2020-06-20 02:13gitNote Added: 0092587
2020-06-20 02:15gitNote Added: 0092588
2020-06-20 02:23gitNote Added: 0092589
2020-06-20 02:29gitNote Added: 0092590
2020-06-20 03:15gitNote Added: 0092591
2020-06-20 13:40kgvNote Added: 0092601
2020-06-20 13:40kgvAssigned Tokgv => nds
2020-06-20 13:40kgvStatusnew => resolved
2020-06-22 08:57ndsNote Added: 0092634
2020-06-22 08:57ndsAssigned Tonds => kgv
2020-06-22 09:14gitNote Added: 0092637
2020-06-22 09:17gitNote Added: 0092639
2020-06-22 09:18kgvNote Added: 0092640
2020-06-22 09:19kgvAssigned Tokgv => nds
2020-06-22 11:04ndsAssigned Tonds => kgv
2020-06-22 11:04ndsStatusresolved => reviewed
2020-06-22 11:25kgvAssigned Tokgv => bugmaster
2020-06-28 11:27bugmasterNote Added: 0092785
2020-06-28 11:27bugmasterStatusreviewed => tested
2020-06-28 11:29bugmasterTest case number => Not required
2020-06-28 12:35kgvChangeset attached => occt master bbe85f2b
2020-06-28 12:35kgvAssigned Tobugmaster => kgv
2020-06-28 12:35kgvStatustested => verified
2020-06-28 12:35kgvResolutionopen => fixed
2020-06-28 12:48gitNote Added: 0092809

Notes
(0092587)
git   
2020-06-20 02:13   
Branch CR31619 has been created by kgv.

SHA-1: 099deff5e00ed47d35628a156c389a2f517ff70f


Detailed log of new commits:

Author: kgv
Date: Sat Jun 20 02:14:51 2020 +0300

    0031619: Samples - update JNI sample to use Android Studio
    
    Project structure and project files have been updated to use Android Studio 4.0, gradle and CMake.
    Redundant OcctJni_Window has been replaced by Aspect_NeutralWindow.
(0092588)
git   
2020-06-20 02:15   
Branch CR31619 has been updated forcibly by kgv.

SHA-1: bede581c535f54ca1eade92f188cea00061adf39
(0092589)
git   
2020-06-20 02:23   
Branch CR31619 has been updated forcibly by kgv.

SHA-1: 6c277a0dc53f5c035de3e61d3d918847e74e9d86
(0092590)
git   
2020-06-20 02:29   
Branch CR31619 has been updated forcibly by kgv.

SHA-1: 630605c0adaa378e3d72bda946dbee6e5c970424
(0092591)
git   
2020-06-20 03:15   
Branch CR31619 has been updated forcibly by kgv.

SHA-1: e7dd10217adebd98c04875719400758b419bfca7
(0092601)
kgv   
2020-06-20 13:40   
Patch is ready for review in OCCT branch CR31619.
(0092634)
nds   
2020-06-22 08:57   
1. OcctJniActivity.java:
are the commented rows necessary?
//int isAlreadyGranted = myContext.checkSelfPermission (thePermission);
//boolean toShowInfo = shouldShowRequestPermissionRationale(thePermission);
//requestPermissions (new String[]{thePermission}, 0);

2. /samples/java/jniviewer/app/src/main/jni/CMakeLists.txt
are the commented rows necessary?
#add_library(lib_FreeImage SHARED IMPORTED)
...

3. /samples/java/jniviewer/gradle.properties.template
are the path rows should give the custom path, why 7.5.0?
OCCT_ROOT=c\:/android/occt-7.5.0
...
is the commented row necessary?
#FREEIMAGE_ROOT=c\:/android/freeimage-3.17-android

4. /samples/java/jniviewer/ReadMe.md

You might need re-entering Android SDK explicitly in File -> Project Structure -> SDK Locations settings.
(and NDK Location setting)
(0092637)
git   
2020-06-22 09:14   
Branch CR31619 has been updated forcibly by kgv.

SHA-1: a8f41b9fccf0a85fc9baff79520b9dae5ff6db0a
(0092639)
git   
2020-06-22 09:17   
Branch CR31619 has been updated forcibly by kgv.

SHA-1: bbe85f2b40ca7c2fdd08247b0c68f6d4b56bd1c2
(0092640)
kgv   
2020-06-22 09:18   
> 1. OcctJniActivity.java: are the commented rows necessary?
Removed.

> 2. are the commented rows necessary?
Yes, in case if OCCT was built with optional FreeImage library enabled.

> 3. why 7.5.0?
This is just a template. Renamed to occt-dev-android.

> 4. /samples/java/jniviewer/ReadMe.md
Amended.
(0092785)
bugmaster   
2020-06-28 11:27   
Combination -
OCCT branch : IR-2020-06-26
master SHA - 832a6f4412321ca784bbb36916dc740d04a05c0c
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-06-26 SHA - 180ab3ca4e501bda3da57c99a8ac8b220db33df3
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17164.36000000016 / 17160.400000000114 [+0.02%]
Products
Total CPU difference: 11173.720000000081 / 11197.400000000112 [-0.21%]
Windows-64-VC14:
OCCT
Total CPU difference: 18707.65625 / 18650.578125 [+0.31%]
Products
Total CPU difference: 13062.6875 / 13012.71875 [+0.38%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0092809)
git   
2020-06-28 12:48   
Branch CR31619 has been deleted by inv.

SHA-1: bbe85f2b40ca7c2fdd08247b0c68f6d4b56bd1c2