MantisBT - Open CASCADE
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031573Open CASCADE[OCCT] OCCT:Visualizationpublic2020-05-19 21:052020-12-02 17:12
Reportervsv 
Assigned Tobugmaster 
PrioritynormalSeverityfeature 
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version[OCCT] 7.5.0 
Target Version[OCCT] 7.5.0Fixed in Version[OCCT] 7.5.0 
Test case numberv3d/ivtk/seam_edges
Summary0031573: Visualization - Do not show seam edge for shading presentation with boundary edges in VTK
DescriptionSeam edges of such objects like cylinder, sphere, cone and so on must not be shown in shading mode with boundary edges switched On for VTK presentation. See attached example picture.
Steps To Reproduce
Additional information
and documentation updates
TagsNo tags attached.
Relationships
Attached Filespng seam_edge.png (33,979) 2020-05-19 21:05
https://tracker.dev.opencascade.org/
png seam_edges.png (21,174) 2020-05-25 12:12
https://tracker.dev.opencascade.org/
Issue History
Date ModifiedUsernameFieldChange
2020-05-19 21:05vsvNew Issue
2020-05-19 21:05vsvAssigned To => vsv
2020-05-19 21:05vsvFile Added: seam_edge.png
2020-05-20 09:35kgvRelationship addedchild of 0029787
2020-05-20 09:35kgvSeverityminor => feature
2020-05-20 15:49gitNote Added: 0092264
2020-05-20 16:47kgvNote Added: 0092265
2020-05-21 17:30gitNote Added: 0092295
2020-05-22 12:21gitNote Added: 0092301
2020-05-25 09:56gitNote Added: 0092317
2020-05-25 10:19gitNote Added: 0092318
2020-05-25 12:12vsvFile Added: seam_edges.png
2020-05-25 12:14vsvNote Added: 0092322
2020-05-25 12:14vsvAssigned Tovsv => kgv
2020-05-25 12:37kgvNote Added: 0092324
2020-05-25 12:37kgvAssigned Tokgv => bugmaster
2020-05-25 12:37kgvStatusnew => resolved
2020-05-25 12:37kgvStatusresolved => reviewed
2020-05-29 09:49bugmasterNote Added: 0092394
2020-05-29 09:49bugmasterStatusreviewed => tested
2020-05-29 09:51bugmasterTest case number => v3d/ivtk/seam_edges
2020-05-30 12:13bugmasterChangeset attached => occt master 2ba1172b
2020-05-30 12:13bugmasterStatustested => verified
2020-05-30 12:13bugmasterResolutionopen => fixed
2020-05-30 12:26gitNote Added: 0092412
2020-12-02 16:43emoFixed in Version => 7.5.0
2020-12-02 17:12emoStatusverified => closed

Notes
(0092264)
git   
2020-05-20 15:49   
Branch CR31573 has been created by vsv.

SHA-1: 2569f7433aa9927ab3ad5678db4cbf4e78a5d4c1


Detailed log of new commits:

Author: vsv
Date: Wed May 20 15:50:15 2020 +0300

    0031573: Visualization - Do not show seam edge for shading presentation with boundary edges in VTK
(0092265)
kgv   
2020-05-20 16:47   
It would be more consistent following similar logic checking upper continuity GeomAbs_Shape implemented by method fillFaceBoundaries() in StdPrs_ShadedShape.cxx (ideally reusing the code, but at least following common approach).

G2 could be used to filter seem edges.
(0092295)
git   
2020-05-21 17:30   
Branch CR31573 has been updated forcibly by vsv.

SHA-1: 072c0df83df08511dcb936961297bc45891881fc
(0092301)
git   
2020-05-22 12:21   
Branch CR31573 has been updated forcibly by vsv.

SHA-1: dc8949045fea4d92d8b92eb31a39175a37997c74
(0092317)
git   
2020-05-25 09:56   
Branch CR31573 has been updated forcibly by vsv.

SHA-1: cc91f1efdaf43e2a26efc25899e657f7345eed46
(0092318)
git   
2020-05-25 10:19   
Branch CR31573 has been updated forcibly by vsv.

SHA-1: cf5d92c000b04a9d7d785fbd7edeafa30bd7422d
(0092322)
vsv   
2020-05-25 12:14   
Compilation and tests of the patch is finished in http://vm-jenkins-test-12.nnov.opencascade.com/view/CR31573-master-vsv/ [^]
Picture from a test of this functionality is attached.
(0092324)
kgv   
2020-05-25 12:37   
Please raise the patch in OCCT branch CR31573.
(0092394)
bugmaster   
2020-05-29 09:49   
Combination -
OCCT branch : WEEK-22
master SHA - 872f98d9ef76db68b45bb744a6f56788f134d9e7
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : WEEK-22 SHA - 0948de4c2124aea8b36e4e2373bac22c08a4c7dc
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17185.300000000076 / 17188.26000000018 [-0.02%]
Products
Total CPU difference: 11192.350000000066 / 11217.810000000067 [-0.23%]
Windows-64-VC14:
OCCT
Total CPU difference: 18662.4375 / 18659.515625 [+0.02%]
Products
Total CPU difference: 12991.78125 / 13006.1875 [-0.11%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0092412)
git   
2020-05-30 12:26   
Branch CR31573 has been deleted by inv.

SHA-1: cf5d92c000b04a9d7d785fbd7edeafa30bd7422d