MantisBT - Open CASCADE
View Issue Details
0031544Open CASCADE[OCCT] OCCT:Visualizationpublic2020-04-29 21:282020-05-16 14:21
vsv 
bugmaster 
normalfeature 
verifiedfixed 
[OCCT] 7.4.0 
[OCCT] 7.5.0* 
v3d/ivtk/boundary_draw
0031544: Visualization, IVtkTools_DisplayModeFilter - show boundaries of faces in shading mode of VTK presentation
Provide possibility to show boundaries of shaded faces for VTK objects in VTK viewer.
No tags attached.
png IVtkTest.png (4,456) 2020-05-12 09:08
https://tracker.dev.opencascade.org/
Issue History
2020-04-29 21:28vsvNew Issue
2020-04-29 21:28vsvAssigned To => vsv
2020-04-29 21:34gitNote Added: 0091878
2020-04-30 11:31kgvNote Added: 0091890
2020-04-30 12:00gitNote Added: 0091892
2020-05-08 15:14vsvTarget Version7.4.0 => 7.5.0*
2020-05-08 18:13gitNote Added: 0092018
2020-05-12 09:08vsvFile Added: IVtkTest.png
2020-05-12 09:25gitNote Added: 0092069
2020-05-12 09:47kgvSummaryVisualization - show boundaries of faces in shading mode of VTK presentation => Visualization, IVtk - show boundaries of faces in shading mode of VTK presentation
2020-05-12 09:48kgvSummaryVisualization, IVtk - show boundaries of faces in shading mode of VTK presentation => Visualization, IVtkTools_DisplayModeFilter - show boundaries of faces in shading mode of VTK presentation
2020-05-12 10:01gitNote Added: 0092070
2020-05-12 16:09gitNote Added: 0092074
2020-05-12 18:46vsvNote Added: 0092077
2020-05-12 18:46vsvAssigned Tovsv => kgv
2020-05-12 18:50kgvNote Added: 0092078
2020-05-12 18:50kgvAssigned Tokgv => bugmaster
2020-05-12 18:50kgvStatusnew => resolved
2020-05-12 18:50kgvStatusresolved => reviewed
2020-05-15 12:36gitNote Added: 0092138
2020-05-15 12:41kgvNote Added: 0092139
2020-05-15 12:41kgvAssigned Tobugmaster => vsv
2020-05-15 12:41kgvStatusreviewed => feedback
2020-05-15 14:17gitNote Added: 0092147
2020-05-15 14:18vsvNote Added: 0092148
2020-05-15 14:18vsvAssigned Tovsv => kgv
2020-05-15 14:24kgvNote Added: 0092150
2020-05-15 14:25kgvAssigned Tokgv => vsv
2020-05-15 14:25kgvNote Edited: 0092150bug_revision_view_page.php?bugnote_id=92150#r22943
2020-05-15 14:29gitNote Added: 0092151
2020-05-15 14:30vsvNote Added: 0092152
2020-05-15 14:30vsvAssigned Tovsv => kgv
2020-05-15 14:34kgvNote Added: 0092154
2020-05-15 14:34kgvAssigned Tokgv => bugmaster
2020-05-15 14:34kgvStatusfeedback => reviewed
2020-05-16 13:58bugmasterNote Added: 0092173
2020-05-16 13:58bugmasterStatusreviewed => tested
2020-05-16 14:05bugmasterTest case number => v3d/ivtk/boundary_draw
2020-05-16 14:07bugmasterChangeset attached => occt master 4db6748c
2020-05-16 14:07bugmasterStatustested => verified
2020-05-16 14:07bugmasterResolutionopen => fixed
2020-05-16 14:21gitNote Added: 0092179

Notes
(0091878)
git   
2020-04-29 21:34   
Branch CR0031544 has been created by vsv.

SHA-1: 4479c55a27e4d10710beff64c1252be68480af74


Detailed log of new commits:

Author: vsv
Date: Wed Apr 29 21:34:50 2020 +0300

    0031544: Visualization - show boundaries of faces in shading mode of VTK presentation
(0091890)
kgv   
2020-04-30 11:31   
+typedef NCollection_DataMap<IVtk_DisplayMode, IVtk_IdTypeMap> IVtk_DisplayModeMap;

I think that considering current IVtk_DisplayMode definition
typedef enum
{
  DM_Wireframe = 0, //!< Wireframe display mode
  DM_Shading   = 1  //!< Shaded display mode
} IVtk_DisplayMode;

It would be simpler replacing a map with a C array (of size IVtk_DisplayMode_NB, to be added close to IVtk_DisplayMode definition).
(0091892)
git   
2020-04-30 12:00   
Branch CR0031544 has been deleted by vsv.

SHA-1: 4479c55a27e4d10710beff64c1252be68480af74
(0092018)
git   
2020-05-08 18:13   
Branch CR31544 has been created by vsv.

SHA-1: d2ce1da9eff182e1d4f4c9936c9e7afa4cd8fb88


Detailed log of new commits:

Author: vsv
Date: Fri May 8 18:14:49 2020 +0300

    0031544: Visualization - show boundaries of faces in shading mode of VTK presentation
(0092069)
git   
2020-05-12 09:25   
Branch CR31544 has been updated forcibly by vsv.

SHA-1: f8cc83b1b63bdaef8b93911599ca98a8942094bf
(0092070)
git   
2020-05-12 10:01   
Branch CR31544 has been updated forcibly by vsv.

SHA-1: 63f38aab186452d1e0664f22975bd66d3c1119b8
(0092074)
git   
2020-05-12 16:09   
Branch CR31544 has been updated forcibly by vsv.

SHA-1: 093e11ba1442b3d98f2caf10f5de02f8bf1e4260
(0092077)
vsv   
2020-05-12 18:46   
Compilation and tests of the integrated modification was finished with success:
http://vm-jenkins-test-12.nnov.opencascade.com/view/CR31544-master-vsv/ [^]
(0092078)
kgv   
2020-05-12 18:50   
Please raise the patch in OCCT branch CR31544.
(0092138)
git   
2020-05-15 12:36   
Branch CR31544 has been updated forcibly by vsv.

SHA-1: 8ca560d74038a28a36798b04e5b1bd94dd4c99f1
(0092139)
kgv   
2020-05-15 12:41   
+  IVtk_IdTypeMap*       myModesDefinition;

Please avoid redundant dynamic allocations - define array of known length.
(0092147)
git   
2020-05-15 14:17   
Branch CR31544 has been updated forcibly by vsv.

SHA-1: c2c7645a5adadb033e6567cbd096ad1ace59518b
(0092148)
vsv   
2020-05-15 14:18   
Done. Dynamic allocation replaced by static array
(0092150)
kgv   
2020-05-15 14:24   
(edited on: 2020-05-15 14:25)
+ cmakebuild.bat
+ draw.bat
+ env.bat
+ msvc.bat

Unexpected local files in commit, please remove.

(0092151)
git   
2020-05-15 14:29   
Branch CR31544 has been updated forcibly by vsv.

SHA-1: 9422df615ab1f35496debadccb3348117c8c2d45
(0092152)
vsv   
2020-05-15 14:30   
Done
(0092154)
kgv   
2020-05-15 14:34   
Dear bugmaster,

please check updated patch.
(0092173)
bugmaster   
2020-05-16 13:58   
Combination -
OCCT branch : IR-2020-05-15
master SHA - 4db6748cc52edc0d8306eb2e436baa97d0db22a5
a206de37fbfa0bf71bd534ae47192bbec23b8522
Products branch : IR-2020-05-15 SHA - 891f2be718304b17c8581488e621b13e8a77f1c5
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 17198.74000000018 / 17177.020000000186 [+0.13%]
Products
Total CPU difference: 11197.280000000079 / 11272.470000000078 [-0.67%]
Windows-64-VC14:
OCCT
Total CPU difference: 18657.328125 / 18646.015625 [+0.06%]
Products
Total CPU difference: 13005.046875 / 13180.21875 [-1.33%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0092179)
git   
2020-05-16 14:21   
Branch CR31544 has been deleted by inv.

SHA-1: 9422df615ab1f35496debadccb3348117c8c2d45