MantisBT - Open CASCADE
View Issue Details
0031458Open CASCADE[OCCT] OCCT:Visualizationpublic2020-03-22 12:432020-03-28 13:48
kgv 
bugmaster 
normalintegration request 
verifiedfixed 
 
[OCCT] 7.5.0 
Not required
0031458: Visualization - refine classes across Prs3d and StdPrs packages
Prs3d and StdPrs packages have the following description (cut off from existing documentation):

- Prs3d provides: a presentation object, an attribute manager (color, width, etc.), generic objects.
- StdPrs is for specific geometries and topologies.
- DsgPrs is for dimensions, relations and trihedra.

There are several deviations within the actual class list, which is desired to be fixed.
N/A
No tags attached.
child of 0031401new kgv Visualization - revise Toolkits dependency graph 
Issue History
2020-03-22 12:43kgvNew Issue
2020-03-22 12:43kgvAssigned To => kgv
2020-03-22 13:26gitNote Added: 0091165
2020-03-22 13:30kgvRelationship addedchild of 0031401
2020-03-22 13:51gitNote Added: 0091166
2020-03-22 14:44gitNote Added: 0091168
2020-03-22 15:20gitNote Added: 0091170
2020-03-22 20:10gitNote Added: 0091176
2020-03-22 21:40kgvNote Added: 0091179
2020-03-22 21:40kgvAssigned Tokgv => osa
2020-03-22 21:40kgvStatusnew => resolved
2020-03-23 08:44gitNote Added: 0091184
2020-03-27 09:29gitNote Added: 0091291
2020-03-27 09:57osaNote Added: 0091292
2020-03-27 09:57osaAssigned Toosa => bugmaster
2020-03-27 09:57osaStatusresolved => reviewed
2020-03-28 13:34bugmasterNote Added: 0091314
2020-03-28 13:34bugmasterStatusreviewed => tested
2020-03-28 13:35bugmasterTest case number => Not required
2020-03-28 13:36bugmasterChangeset attached => occt master 7f24b768
2020-03-28 13:36bugmasterStatustested => verified
2020-03-28 13:36bugmasterResolutionopen => fixed
2020-03-28 13:46gitNote Added: 0091315

Notes
(0091165)
git   
2020-03-22 13:26   
Branch CR31458 has been created by kgv.

SHA-1: 485a6f71bbbaf81879bc05558c68a3e19c783c06


Detailed log of new commits:

Author: kgv
Date: Sat Mar 14 13:32:48 2020 +0300

    0031458: Visualization - refine classes across Prs3d and StdPrs packages
    
    Prs3d::GetDeflection() has been moved to StdPrs_ToolTriangulatedShape::GetDeflection().
    Prs3d_ShapeTool has been moved to StdPrs_ShapeTool.
    Code collecting free edges on Poly_Triangulation
    has been moved out from StdPrs_WFShape to Prs3d::AddFreeEdges().
    StdPrs_BndBox has been moved to Prs3d_BndBox.
    Geom_Transformation has been replaced by TopLoc_Datum3D within visualization classes.
    
    Select3D_SensitiveCircle constructor now takes gp_Circ instead of Geom_Circle.
    StdSelect_ViewerSelector3d has been moved to SelectMgr_ViewerSelector3d.
    Methods ::GetPoint3d() and ::ArrayBounds() has been moved
    from subclass Select3D_SensitiveCircle to the base class Select3D_SensitiveCurve.
    StdSelect_ViewerSelector3d::computeSensitivePrs() has been moved to SelectMgr::ComputeSensitivePrs().
    
    Removed unused declarations StdSelect_Prs, StdSelect_DisplayMode,
    StdSelect_SensitivityMode, StdSelect_TypeOfResult, SelectMgr_SOPtr, TColQuantity.
    
    Package Graphic3d has been moved from TKV3d to TKService.
(0091166)
git   
2020-03-22 13:51   
Branch CR31458 has been updated forcibly by kgv.

SHA-1: aa33a5967ba3548066c621785fbc44515d40c5db
(0091168)
git   
2020-03-22 14:44   
Branch CR31458 has been updated forcibly by kgv.

SHA-1: c1556a3cf4e8429716d39ea37696406d61764794
(0091170)
git   
2020-03-22 15:20   
Branch CR31458 has been updated forcibly by kgv.

SHA-1: dce7955e80b8ed37e97756c73e1a86a82c2e8f46
(0091176)
git   
2020-03-22 20:10   
Branch CR31458 has been updated forcibly by kgv.

SHA-1: 3089a6a86064e60ec9ac1e4986ad1cc0456517e8
(0091179)
kgv   
2020-03-22 21:40   
Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31458-CR31458-KGV [^]
(0091184)
git   
2020-03-23 08:44   
Branch CR31458 has been updated forcibly by kgv.

SHA-1: e0b19445bb798c13fe367e68b803a26df5eaf28d
(0091291)
git   
2020-03-27 09:29   
Branch CR31458 has been updated forcibly by kgv.

SHA-1: 9075aabd23ff0728959237b1fb1bd6a14f6e944f
(0091292)
osa   
2020-03-27 09:57   
The patch was reviewed
(0091314)
bugmaster   
2020-03-28 13:34   
Combination -
OCCT branch : IR-2020-03-27
master SHA - 420f5c868231b05a936c35a8f6a7aaf311cbad64
b063b8738ddd5eb1c5bbbdac861e8d2f7864961f
Products branch : IR-2020-03-27 SHA - 61a33c5381d589ae31e1bab6ea750b3fbf4915f6
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16866.29000000024 / 16846.320000000138 [+0.12%]
Products
Total CPU difference: 11324.27000000008 / 11306.210000000074 [+0.16%]
Windows-64-VC14:
OCCT
Total CPU difference: 18291.046875 / 18268.796875 [+0.12%]
Products
Total CPU difference: 13224.34375 / 13110.609375 [+0.87%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention
(0091315)
git   
2020-03-28 13:46   
Branch CR31458 has been deleted by inv.

SHA-1: 9075aabd23ff0728959237b1fb1bd6a14f6e944f