MantisBT - Open CASCADE
View Issue Details
0031431Open CASCADE[OCCT] OCCT:Visualizationpublic2020-03-14 20:272020-03-22 11:39
kgv 
kgv 
normalintegration request 
verifiedfixed 
 
[OCCT] 7.5.0* 
Not required
0031431: Visualization, PrsMgr_PresentableObject - simplify HLR computing interface
Existing HLR computation interface within PrsMgr_PresentableObject is overcomplicated - there are numerous methods for doing the same thing.

Therefore, it is proposed revising and simplifying interface.
N/A
No tags attached.
child of 0031401new kgv Visualization - revise Toolkits dependency graph 
Issue History
2020-03-14 20:27kgvNew Issue
2020-03-14 20:27kgvAssigned To => kgv
2020-03-14 20:34gitNote Added: 0090944
2020-03-14 20:58gitNote Added: 0090945
2020-03-14 21:03kgvRelationship addedchild of 0031401
2020-03-16 10:02gitNote Added: 0090948
2020-03-16 11:23gitNote Added: 0090952
2020-03-16 12:28gitNote Added: 0090960
2020-03-16 12:56gitNote Added: 0090964
2020-03-16 16:56gitNote Added: 0090975
2020-03-16 18:44kgvNote Added: 0090979
2020-03-16 18:44kgvAssigned Tokgv => osa
2020-03-16 18:44kgvStatusnew => resolved
2020-03-17 18:09osaNote Added: 0090992
2020-03-17 18:09osaAssigned Toosa => bugmaster
2020-03-17 18:09osaStatusresolved => reviewed
2020-03-19 16:31kgvChangeset attached => occt master b5163d2f
2020-03-19 16:31kgvAssigned Tobugmaster => kgv
2020-03-19 16:31kgvStatusreviewed => verified
2020-03-19 16:31kgvResolutionopen => fixed
2020-03-22 11:31gitNote Added: 0091128
2020-03-22 11:31gitNote Added: 0091129
2020-03-22 11:39bugmasterNote Added: 0091152
2020-03-22 11:39bugmasterTest case number => Not required

Notes
(0090944)
git   
2020-03-14 20:34   
Branch CR31431 has been created by kgv.

SHA-1: a67e60d81a3bb9a770176288dc2f50dc24c5b34b


Detailed log of new commits:

Author: kgv
Date: Sat Mar 14 20:34:46 2020 +0300

    0031431: Visualization, PrsMgr_PresentableObject - simplify HLR computing interface
    
    Multiple PrsMgr_PresentableObject::Compute() methods have been replaced by single one
    PrsMgr_PresentableObject::computeHLR().
    Dummy implementations of previously declared methods have been removed
    from AIS classes not implementng HLR presentation.
    Class Prs3d_Projector has been removed and Graphic3d_Camera is now passed directly,
    so that redundant dependency from HLRAlgo_Projector in Prs3d interfaces has been eliminated.
    StdPrs_HLRShape and StdPrs_HLRPolyShape now implement common interface StdPrs_HLRShapeI.
(0090945)
git   
2020-03-14 20:58   
Branch CR31431 has been updated forcibly by kgv.

SHA-1: 6613d8d9832f72a9f65a71787ba7ac202509ca8f
(0090948)
git   
2020-03-16 10:02   
Branch CR31431_1 has been created by kgv.

SHA-1: e3d5dc6d98cb2db027b4b8f9c9e0ce0ff2b454c0


No new revisions were added by this update.
(0090952)
git   
2020-03-16 11:23   
Branch CR31431_1 has been updated forcibly by kgv.

SHA-1: 889b3d21603d29a13b141c90f7462898a671ebcc
(0090960)
git   
2020-03-16 12:28   
Branch CR31431_1 has been updated forcibly by kgv.

SHA-1: 0d35ae20c8032cba9d20a1cb61583c3830e38cbb
(0090964)
git   
2020-03-16 12:56   
Branch CR31431_1 has been updated forcibly by kgv.

SHA-1: 7c6ae05dc557db8cff99ac7b75de6834e9bd08ef
(0090975)
git   
2020-03-16 16:56   
Branch CR31431_1 has been updated forcibly by kgv.

SHA-1: b5163d2f8d19e9120fc9c019f3e1fd41100c8b11
(0090979)
kgv   
2020-03-16 18:44   
Patch is ready for review.

http://jenkins-test-12.nnov.opencascade.com:8080/view/CR31431_1-CR31431_1-KGV/ [^]
(0090992)
osa   
2020-03-17 18:09   
The patch was reviewed without remarks.
(0091128)
git   
2020-03-22 11:31   
Branch CR31431_1 has been deleted by inv.

SHA-1: b5163d2f8d19e9120fc9c019f3e1fd41100c8b11
(0091129)
git   
2020-03-22 11:31   
Branch CR31431 has been deleted by inv.

SHA-1: 6613d8d9832f72a9f65a71787ba7ac202509ca8f
(0091152)
bugmaster   
2020-03-22 11:39   
Combination -
OCCT branch : IR-2020-03-20
master SHA - 7ef1f9b7c1d9301c158a593dc5facb5a33450318
fe4497f3246e6bc1ced97ac331c148f0809ded15
Products branch : IR-2020-03-20 SHA - f10b867b449ebfa55e0a3c8cb276ae511f9cf7f2
was compiled on Linux, MacOS and Windows platforms and tested in optimize mode.

Number of compiler warnings:
No new/fixed warnings

Regressions/Differences/Improvements:
No regressions/differences

CPU differences:
Debian80-64:
OCCT
Total CPU difference: 16845.960000000137 / 16685.300000000094 [+0.96%]
Products
Total CPU difference: 11305.960000000074 / 11298.700000000106 [+0.06%]
Windows-64-VC14:
OCCT
Total CPU difference: 18268.609375 / 18088.765625 [+0.99%]
Products
Total CPU difference: 13110.078125 / 13084.390625 [+0.20%]


Image differences :
No differences that require special attention

Memory differences :
No differences that require special attention